byrongamatos and Claude Sonnet 4.6
6c15ed9dda
fix(h3d-carve-16): Toby r1 — F1 ternary, F2 dead DI, F3 naming guard, F4 smoke honesty
...
F1 (HIGH): Fix truncated-ternary in _bgLoadSettings — setZoomSmoothing and
setTiltSmoothing were closing before the ternary, storing the boolean
_bgHasStored(...) result instead of the camera-smoothing value. Move
closing ) to after : _cameraSmoothing. Add kill tests for both setters
asserting the argument contains '?'.
F2 (MED): Remove 13 dead DI params (5 lines) from createSceneInit signature
and matching entries from screen.js wiring:
- FRET_WIRE_HIT_OP / HIT_INTENSITY / HIT_DECAY (renderer.js only)
- updateStringHighlights (declared null, never called)
- getIsDestroyed (screen.js lifecycle flag, not scene-init's concern)
- setChartEnv/PrevT, setBcBeatIdx/NoteIdx/ChordIdx (BC chart-sync: per-frame)
- setTintR/G/B (BC tint: per-frame, managed outside scene-init)
DI count repinned: 183 → 178.
F3 (LOW): Add naming-correspondence guard — for every getX in the DI,
assert a matching setX exists unless getX is in READ_ONLY (6 pinned
stable-ref getters that scene-init never writes).
F4 (honesty): Rename smoke test — was 'setters called before null-T throw'
(wrong: null canvas returns before T is accessed, no setter is called).
Now: 'factory construction + null-canvas early guard'.
Remove dead di stub entries (FRET_WIRE_HIT_*, getIsDestroyed,
updateStringHighlights) that no longer exist in the DI signature.
Suite: 427/427 (h3d glob).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com >
Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW
2026-09-06 07:21:01 +02:00
..
2026-07-11 16:33:03 +02:00
2026-06-16 18:47:13 +02:00
2026-07-19 12:16:02 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-16 18:47:13 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-07-12 14:22:19 +02:00
2026-07-05 23:50:30 +02:00
2026-07-10 23:19:20 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-07-11 18:18:00 +02:00
2026-06-23 11:03:01 +02:00
2026-09-03 18:34:02 +02:00
2026-07-15 10:50:55 +02:00
2026-07-19 11:27:52 +02:00
2026-07-23 11:26:32 +02:00
2026-06-23 11:03:01 +02:00
2026-07-02 18:42:26 +02:00
2026-07-12 13:43:57 +02:00
2026-07-05 23:37:39 +02:00
2026-07-19 11:52:51 +02:00
2026-07-19 11:52:51 +02:00
2026-07-15 00:36:20 +02:00
2026-07-10 23:19:20 +02:00
2026-09-05 22:47:48 +02:00
2026-09-05 18:32:25 +02:00
2026-09-05 09:03:10 +02:00
2026-09-05 09:55:36 +02:00
2026-09-05 22:47:48 +02:00
2026-09-05 22:47:48 +02:00
2026-09-05 19:19:57 +02:00
2026-09-06 06:29:27 +02:00
2026-09-05 22:47:48 +02:00
2026-09-05 22:47:48 +02:00
2026-09-06 06:29:27 +02:00
2026-09-05 16:07:37 +02:00
2026-09-05 07:19:58 +02:00
2026-09-05 22:47:48 +02:00
2026-09-05 16:37:20 +02:00
2026-09-05 12:40:34 +02:00
2026-09-05 23:37:57 +02:00
2026-06-22 13:27:21 +02:00
2026-09-05 15:14:53 +02:00
2026-09-05 16:37:20 +02:00
2026-09-06 06:29:27 +02:00
2026-09-06 06:29:27 +02:00
2026-09-06 01:35:59 +02:00
2026-07-02 00:40:52 +02:00
2026-09-06 07:21:01 +02:00
2026-09-06 06:29:27 +02:00
2026-09-06 01:00:02 +02:00
2026-09-05 22:47:48 +02:00
2026-09-05 17:51:54 +02:00
2026-09-06 06:29:27 +02:00
2026-09-06 06:29:27 +02:00
2026-09-05 07:42:18 +02:00
2026-09-05 08:02:00 +02:00
2026-09-06 06:29:27 +02:00
2026-07-12 12:24:40 +02:00
2026-06-23 11:03:01 +02:00
2026-09-05 20:32:15 +02:00
2026-09-05 22:47:48 +02:00
2026-09-05 20:32:15 +02:00
2026-07-19 11:27:52 +02:00
2026-07-11 19:22:14 +02:00
2026-07-10 23:19:20 +02:00
2026-07-12 12:24:40 +02:00
2026-09-05 22:47:48 +02:00
2026-07-15 00:36:16 +02:00
2026-07-10 23:19:20 +02:00
2026-07-10 23:19:20 +02:00
2026-09-06 06:46:08 +02:00
2026-09-05 20:32:15 +02:00
2026-09-06 06:46:08 +02:00
2026-07-11 20:58:41 +02:00
2026-07-11 22:44:03 +02:00
2026-07-12 00:19:59 +02:00
2026-06-16 19:36:53 +01:00
2026-07-03 14:35:07 +02:00
2026-07-13 00:35:09 +02:00
2026-07-11 21:32:31 +02:00
2026-07-23 11:26:32 +02:00
2026-06-23 11:03:01 +02:00
2026-07-12 16:06:28 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-07-11 23:26:35 +02:00
2026-07-15 12:39:25 +02:00
2026-07-03 13:07:47 +02:00
2026-07-11 23:26:35 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-07-11 18:18:00 +02:00
2026-07-12 00:19:59 +02:00
2026-07-12 00:19:59 +02:00
2026-07-11 18:18:00 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-06-23 11:03:01 +02:00
2026-07-11 22:44:03 +02:00
2026-07-11 20:58:41 +02:00
2026-07-12 14:08:45 +02:00
2026-07-12 16:05:50 +02:00
2026-07-12 14:22:19 +02:00
2026-07-11 22:05:22 +02:00
2026-07-12 11:56:07 +02:00
2026-07-11 21:52:51 +02:00
2026-07-11 23:26:35 +02:00
2026-07-12 14:22:19 +02:00
2026-06-16 18:47:13 +02:00
2026-06-23 11:03:01 +02:00
2026-07-12 14:22:19 +02:00
2026-06-16 18:47:13 +02:00
2026-07-11 19:37:44 +02:00
2026-07-11 19:37:44 +02:00
2026-06-28 13:58:14 +02:00
2026-07-02 14:03:05 +02:00
2026-06-29 10:42:41 +02:00
2026-07-02 14:52:40 +02:00
2026-07-03 14:35:07 +02:00
2026-07-11 23:30:30 +02:00
2026-06-28 14:10:15 +02:00
2026-07-19 00:10:53 -05:00
2026-06-28 12:39:13 +02:00
2026-06-29 12:26:29 +02:00
2026-07-19 00:04:30 -05:00
2026-07-05 00:19:46 +02:00
2026-07-02 13:57:58 +02:00
2026-06-29 14:44:56 +02:00
2026-07-13 15:07:28 +02:00
2026-06-16 18:47:13 +02:00
2026-06-23 11:03:01 +02:00
2026-07-14 22:11:52 +02:00
2026-07-15 12:39:25 +02:00
2026-07-11 18:41:52 +02:00
2026-06-23 11:03:01 +02:00
2026-09-03 14:37:34 +02:00
2026-07-11 17:09:18 +02:00
2026-07-01 11:07:58 +02:00
2026-07-05 00:16:42 +02:00