mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-10-02 11:11:47 +00:00
byrongamatosandClaude Sonnet 4.6
6c15ed9dda
F1 (HIGH): Fix truncated-ternary in _bgLoadSettings — setZoomSmoothing and setTiltSmoothing were closing before the ternary, storing the boolean _bgHasStored(...) result instead of the camera-smoothing value. Move closing ) to after : _cameraSmoothing. Add kill tests for both setters asserting the argument contains '?'. F2 (MED): Remove 13 dead DI params (5 lines) from createSceneInit signature and matching entries from screen.js wiring: - FRET_WIRE_HIT_OP / HIT_INTENSITY / HIT_DECAY (renderer.js only) - updateStringHighlights (declared null, never called) - getIsDestroyed (screen.js lifecycle flag, not scene-init's concern) - setChartEnv/PrevT, setBcBeatIdx/NoteIdx/ChordIdx (BC chart-sync: per-frame) - setTintR/G/B (BC tint: per-frame, managed outside scene-init) DI count repinned: 183 → 178. F3 (LOW): Add naming-correspondence guard — for every getX in the DI, assert a matching setX exists unless getX is in READ_ONLY (6 pinned stable-ref getters that scene-init never writes). F4 (honesty): Rename smoke test — was 'setters called before null-T throw' (wrong: null canvas returns before T is accessed, no setter is called). Now: 'factory construction + null-canvas early guard'. Remove dead di stub entries (FRET_WIRE_HIT_*, getIsDestroyed, updateStringHighlights) that no longer exist in the DI signature. Suite: 427/427 (h3d glob). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW