mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-09-12 17:18:30 +00:00
byrongamatosandClaude Sonnet 4.6
7623ad85e3
- createRenderer factory DI: 241 params (consts, fn-refs, 33 pool getters, material/settings/camera/ND getters, 35 setters) - screen.js: tombstone + createRenderer wiring after createNoteRenderer + createCamera wirings (§1 ruling: createNoteRenderer called from screen.js) - Restore createArp wiring + _resetStringDependentCaches to screen.js (accidentally dropped during carve; both needed in IIFE scope) - smoothNow: correction 3 — setter form setFrameNow(v); return v (no bare return (_frameNow = raw)) - _applyNoteCamTargets callers: 2 sites (7940/9923); correction 2 verified - lookaheadSmoothCamStep callers: 3 sites (9963/9974/9978); correction 2 verified - plugin.json: bump 3.50.0 → 3.51.0 Tests (16 files updated to scan renderer.js): - highway_3d_renderer.test.js: new, 15 tests — export contract, DI count (241), tombstone, caller-list corrections, smoothNow semantics, ordering - highway_3d_arp_deferral.test.js: add renderer.js scan (deferChordGems / noteStreamCoversArpShape moved to renderer.js) - highway_3d_lean_sustain.test.js: add renderer.js scan; update to setLeanSus/getLeanSus() getter form - highway_3d_smooth_clock_pause.test.js: fix literal-newline syntax error; update to setClkAudioT/setClkPerf/setFrameNow setter form; update new-sample regex to match getClkAudioT() - highway_3d_slide_target.test.js: add renderer.js to src scan - highway_3d_sustain_rail.test.js: assert against rendererSrc (pattern moved from U-section) - highway_chart_transform.test.js: add utils.js scan (_openStringPitchLabels- ForTuning moved to src/utils.js by h3d-carve-3) - highway_note_state.test.js: add renderer.js scan (_ndGetNoteState / _ndHasProvider captures in renderer.js update()) - highway_3d_camera_bootstrap.test.js: setter form for camSnapped/curX/ measureStarts; renderer.js added to scan - highway_3d_camera_framing.test.js: renderer.js added; setMeasureStarts/ setCamSnapped setter form in assertions Suite: 1395/1396 (test 46 pre-existing failure unrelated to carve-15) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW
56 lines
3.0 KiB
JavaScript
56 lines
3.0 KiB
JavaScript
// Pins the arpeggio chord-gem deferral gating in plugins/highway_3d/screen.js
|
|
// (feedBack#262). Without these guards, an over-eager `deferChordGems` makes
|
|
// arpeggio frames empty when standalone notes don't actually cover the shape,
|
|
// and an under-eager one duplicates gems on top of the standalone passage.
|
|
//
|
|
// Source-level only — same strategy as the other tests/js/ files.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'screen.js');
|
|
// h3d-carve-12: chordShapeCoveredByStandaloneNotes moved to src/arp.js
|
|
const ARP_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'arp.js');
|
|
// h3d-carve-15: deferChordGems / noteStreamCoversArpShape moved to src/renderer.js
|
|
const RENDERER_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'renderer.js');
|
|
|
|
test('chordShapeCoveredByStandaloneNotes helper exists with the expected signature', () => {
|
|
const src = fs.readFileSync(ARP_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/function\s+chordShapeCoveredByStandaloneNotes\s*\(\s*ch\s*,\s*shape\s*,\s*notesArr\s*,\s*timeWin\s*\)/,
|
|
'helper that scans the note stream for shape coverage must be in src/arp.js (moved from screen.js by h3d-carve-12)',
|
|
);
|
|
});
|
|
|
|
test('deferChordGems gates both synth and explicit+covered branches on note-stream coverage', () => {
|
|
// Either branch firing without coverage produces the empty-lavender-frame
|
|
// regression PR #262 fixed. Pin both predicates so a refactor that drops
|
|
// one gate fails the test.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/const\s+deferChordGems\s*=\s*\(\s*ch\.h3dSynth\s*&&\s*noteStreamCoversArpShape\(\)\s*\)\s*\|\|\s*inferredArpPattern\s*\|\|\s*\(\s*hsHintFrame\.explicit\s*&&\s*hsHintFrame\.covered\s*&&\s*noteStreamCoversArpShape\(\)\s*\)/,
|
|
'deferChordGems must guard the h3dSynth and explicit+covered branches with the coverage check',
|
|
);
|
|
});
|
|
|
|
test('noteStreamCoversArpShape is computed lazily (called, not eagerly bound)', () => {
|
|
// Eager allocation regressed perf on dense charts (Copilot review on PR
|
|
// #262). The shape must be a callable so short-circuit evaluation skips
|
|
// the note-stream scan when neither gating branch needs it.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/const\s+noteStreamCoversArpShape\s*=\s*(?:\(\s*\)\s*=>|function(?:\s+\w+)?\s*\(\s*\))/,
|
|
'noteStreamCoversArpShape must be an arrow/function so the scan is lazy',
|
|
);
|
|
assert.doesNotMatch(
|
|
fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + fs.readFileSync(RENDERER_JS, 'utf8'),
|
|
/const\s+noteStreamCoversArpShape\s*=\s*chordShapeCoveredByStandaloneNotes\(/,
|
|
'noteStreamCoversArpShape must not eagerly invoke the coverage helper',
|
|
);
|
|
});
|