3 Commits

Author	SHA1	Message	Date
Byron Gamatos	09f7e450a5	refactor(app): give formatTime a home — a leaf format.js, one fewer host hook (R3a) (#895) ... static/js/format.js (17). One function. Retires the formatTime hook: 12 -> 11. WHY A MODULE FOR ONE FUNCTION. formatTime was a host hook — loops.js and section-practice.js both reached back through the seam for it. It is ALSO, by pure accident of who calls it, inside the dependency closure of the library carve that comes next. Leaving it there would have made loops.js and section-practice.js import the LIBRARY in order to format a timestamp — nonsense, and a cycle waiting to happen. Same rule as the transport carve: a hook is a cycle you agreed to live with; an import is a dependency you actually have. formatTime has a real owner. It just isn't app.js, and it certainly isn't the library. Give it a home and both consumers import it directly. A leaf on purpose. Anything else that turns out to be a shared pure formatter belongs here too; nothing does yet (I checked — formatBadge, _safeImageUrl and _fetchJsonOrThrow have no callers outside the library), so nothing else is here. node 1040/1040, host contract 2/2, ESLint 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 23:27:17 +02:00
Byron Gamatos	8bec8d2466	refactor(app): carve the playback transport out of app.js — and RETIRE 8 host hooks (R3a) (#894) ... static/js/transport.js (377) — bodies VERBATIM. app.js 6,643 → 6,316. THIS IS THE FIRST CARVE THAT SUBTRACTS HOOKS INSTEAD OF ADDING THEM. Every carve before this one added host hooks: a module pulled out of app.js still had to call back into it. But four modules were all reaching through the seam for the SAME handful of names — _audioSeek, _audioTime, setPlayButtonState, _songEventPayload, jucePlayer. Those names have an owner, and it isn't app.js. Give them one, and the consumers import them directly: count-in.js 5 hooks -> 0 (host import deleted) juce-audio.js 4 hooks -> 0 (host import deleted) loops.js 6 hooks -> 4 section-practice.js 10 hooks -> 7 ---------------------------------------------------------- configureHost() 20 hooks -> 12 A hook is a cycle you agreed to live with. An import is a dependency you actually have. Prefer the import whenever the name has a real owner. _audioSeekGen now stays PRIVATE. It has exactly one writer — _resetAudioSeekState(), which moved with it — so readers get audioSeekGen() and nobody outside can desync it. Strictly better than the hook it replaces, which handed out a getter and left the writer behind in app.js. THE SCAN HAD A HOLE, AND IT BIT. Picking the carve by dependency closure over app.js's own top-level decls said this cluster was downward-closed. It wasn't: _currentPlaybackSnapshot reads loopA/loopB — which live in ./js/loops.js, and loops.js imports transport. The scan saw nothing, because loopA STOPPED BEING an app.js decl the moment loops.js was carved out. Any dependency scan of a partly-carved monolith has to resolve the imports too, or it will confidently hand you a cycle. Added that pass; it found exactly one back-edge, and _currentPlaybackSnapshot stays in app.js (as does restartCurrentSong, which calls _cancelCountIn). app.js is the root — it imports both sides for free. TESTS. Four harnesses retargeted (play_button_reroute_guard, song_event_payload, song_seek -> transport.js; playback_app_adapter SPLIT, since _installPlaybackTransportAdapter stayed behind). The two CENSUS tests — "≥8 song:* emit sites", "every seek callsite passes a reason" — now scan app.js AND every static/js/*.js, not one file. Pointed at a single file, their count silently shrinks as code leaves, which reads as "someone deleted an emit" or, worse, passes while genuinely missing sites. Both bite-tested: stripping a _songEventPayload() from an emit and adding a reason-less _audioSeek() each fail the suite. VERIFIED. A/B against origin/main, real song, real playback: song:play payload is exactly {audioT, chartT, perfNow, time}; song:seek carries reason "seek-by" with finite from/to; all five song:* events fire; seekBy advances the clock; restartCurrentSong returns to zero; the play button's aria-pressed tracks state. IDENTICAL on all 21 probes, zero page errors. pytest 2396, node 1040/1040, host contract 2/2, ESLint 0 (no-cycle clean), Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 23:26:35 +02:00
Byron Gamatos	cb236e6c04	refactor(app): carve the A–B loop out of app.js (R3a) (#888) ... static/js/loops.js (261) — bodies VERBATIM. app.js 8,421 → 8,224. The second slice out of the strongly-connected core. It OWNS the loop state — loopA, loopB, _loopMutationGen. Nothing outside writes them: restartCurrentSong() looked like it did, but it declares its own local `let loopA/loopB` shadows, so the module-level bindings only ever change in setLoop / setLoopStart / setLoopEnd / clearLoop. All four move here. No state container. DIRECTION IS THE WHOLE DESIGN. loops and section-practice are mutually dependent — the SCC in miniature. clearLoop() must drop section-practice's selection, and practiceSection() must call setLoop(). Both edges cannot be imports or no-cycle (rightly) rejects it. So: section-practice -> reaches loops through the HOST SEAM (host.setLoop, …) loops -> imports section-practice DIRECTLY section-practice is the higher-level feature — a consumer of loops, not the reverse — so it is the one that takes the indirection. app.js hands the loop module's exports across into the seam for it. Graph stays acyclic; no-cycle passes. THE CONTRACT TEST EARNED ITS KEEP IMMEDIATELY. It failed on the first build with "these hooks are wired by app.js but no module reads them: playSong". My dependency scan had counted a mention of playSong() inside a COMMENT in loops.js as a real call. Wired but unused is precisely the "fossil of a rename" case the test exists for — and it caught it on a path no test executes. VERIFIED BY DRIVING BOTH SIDES OF THE SEAM. A/B against origin/main in two browsers, real song loaded: * setLoop(5,12) -> true; getLoop() -> 5,12 — IDENTICAL * clearLoop() (loops -> section-practice, a direct import) -> getLoop() -> null,null — IDENTICAL * onPhraseNext() (section-practice -> loops, ACROSS THE SEAM) -> ok — IDENTICAL * loadSavedLoop / saveCurrentLoop / deleteSelectedLoop on window — IDENTICAL * zero page errors either side. An unwired hook throws, so a live app is itself proof the seam is wired. Harness: loop_api extracts the loop helpers by signature — retargeted to loops.js, `export` stripped for the vm sandbox, and the sandbox's existing _audioSeek / _audioTime / formatTime spies are now routed through a `host` object so every assertion holds unchanged, just through the indirection the real code uses. It is SPLIT: one test still reads app.js for the window.feedBack API surface, which stayed. pytest 2396, node 1040/1040, ESLint 0 (no-cycle clean), tailwind clean. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 21:32:31 +02:00