mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-10 18:59:56 +00:00
topkoa
e5cbea2e9f
The option-heavy player UIs (mixer, camera director, viz, audio routing)
all live in the rail popovers, which are exclusive: openPopFor() closes
the last one before opening the next. You cannot watch the mixer while
riding the camera, and both vanish the moment you look at the highway.
Add `window.feedBack.panes` — a core registry for live UI that is
authored once as `mount(root, ctx)` and hosted anywhere. Panes are
non-exclusive, and they survive song switches structurally: the dock is a
body child outside every .screen, so the per-song teardown never sees it.
The adoption cost for a plugin is two calls:
feedBack.panes.register({ id, title, icon, mount, unmount });
feedBack.panes.attachChip(myExistingDialogEl, id);
attachChip injects THE standard pop-out chip. Clicking it opens the pane
and hides the plugin's dialog, leaving a stub to bring it back. Core owns
the hide/restore, so every plugin's pop-out looks and behaves the same —
which is the point. It hides via a dedicated .fb-pane-detached class, not
.hidden/[hidden], because the dialogs we attach to already toggle those.
Everything a pane may touch arrives through `ctx` — never a global. That
is what will let the same mount() run inside a pop-out window, a separate
JS realm with no window.feedBack, no window.highway and no audio graph:
ctx.call(domain, cmd, payload) -> the capability bus
ctx.on(event, fn) -> the feedBack bus (allowlisted)
ctx.subscribe(stream, fn) -> playhead / meters
ctx.state.get/set -> persisted, main realm is the only writer
ctx.playhead(), ctx.song(), ctx.toast(), ctx.close()
ctx tracks every subscription it hands out and drops them on unmount, so
a pane cannot leak listeners across a dock/undock cycle.
Streams exist because an AnalyserNode cannot cross a window boundary:
levels are reduced to numbers in the realm that owns the audio graph.
One shared rAF loop, refcounted against live subscriptions, dirty-checked
before fan-out, and stopped dead when the last pane closes.
Hosts register themselves with the manager rather than being imported by
it — the dock lands at priority 0 (the floor, always available), so the
OS pane window can drop in later without this code changing.
Ships two built-in panes: Now Playing (the reference pane — reads the bus,
a stream, and levels, and touches no globals) and Mixer (the same faders
as the rail, via ctx.call('audio-mix', ...), with the chip attached to the
real #mixer-control). Plus a "Panes" rail popover to open panes that have
no dialog of their own; the system tray will mirror that list.
Note the dock sits at z-index 110, not on the docs/plugin-v3-ui.md ladder
(transport 20, rail 30, popovers 40) — those live INSIDE #player's
stacking context, and #player is itself fixed at z-index 100. A dock below
100 is invisible on the one screen panes exist for. Body-level ladder:
#player 100 < dock 110 < toasts 120 < modals 200.
Pop-out windows, the system tray, manifest-declared panes and mirrorGlobal
(the window.__h3dCamCtl proxy the camera director needs) follow.
Signed-off-by: topkoa <topkoa@gmail.com>
109 lines
3.9 KiB
JavaScript
109 lines
3.9 KiB
JavaScript
/*
|
|
* fee[dB]ack — pane dock (the in-window pane host).
|
|
*
|
|
* A right-edge stack of cards, one per open pane. Deliberately NOT a rail
|
|
* popover: the rail is exclusive (player-chrome.js openPopFor closes the last
|
|
* one before opening the next), which is precisely why you can't watch the
|
|
* mixer while riding the camera. Cards here coexist.
|
|
*
|
|
* Song-switch survival is structural, not defended. `#fb-pane-dock` is appended
|
|
* to <body>, outside every `.screen`, so the per-song teardown never sees it —
|
|
* and `playSong()` ends in `showScreen('player')`, whose id === 'player' short-
|
|
* circuits the teardown branch anyway. Nothing to reset, nothing to re-mount.
|
|
*
|
|
* Registers itself as the `dock` host at priority 0 — the floor. Whatever else
|
|
* exists (an OS pane window), a pane can always land here.
|
|
*/
|
|
(function () {
|
|
'use strict';
|
|
|
|
const panes = window.feedBack && window.feedBack.panes;
|
|
if (!panes || typeof panes.registerHost !== 'function') {
|
|
console.error('[panes] pane-manager.js must load before pane-dock.js');
|
|
return;
|
|
}
|
|
|
|
let dockEl = null;
|
|
const cards = new Map(); // paneId -> card element
|
|
|
|
function dock() {
|
|
if (dockEl && dockEl.isConnected) return dockEl;
|
|
dockEl = document.getElementById('fb-pane-dock');
|
|
if (!dockEl) {
|
|
dockEl = document.createElement('div');
|
|
dockEl.id = 'fb-pane-dock';
|
|
dockEl.className = 'fb-pane-dock';
|
|
dockEl.setAttribute('role', 'region');
|
|
dockEl.setAttribute('aria-label', 'Panes');
|
|
document.body.appendChild(dockEl);
|
|
}
|
|
return dockEl;
|
|
}
|
|
|
|
function _syncEmpty() {
|
|
const d = dock();
|
|
d.classList.toggle('is-empty', cards.size === 0);
|
|
}
|
|
|
|
function mount(spec) {
|
|
const card = document.createElement('section');
|
|
card.className = 'fb-pane-card';
|
|
card.dataset.paneId = spec.id;
|
|
card.setAttribute('aria-label', spec.title);
|
|
|
|
const head = document.createElement('header');
|
|
head.className = 'fb-pane-card-head';
|
|
|
|
const title = document.createElement('span');
|
|
title.className = 'fb-pane-card-title';
|
|
// textContent, not innerHTML — a pane title can come from a plugin
|
|
// manifest, i.e. from outside core.
|
|
title.textContent = spec.icon + ' ' + spec.title;
|
|
|
|
const close = document.createElement('button');
|
|
close.type = 'button';
|
|
close.className = 'fb-pane-card-btn';
|
|
close.setAttribute('aria-label', 'Close ' + spec.title);
|
|
close.title = 'Close';
|
|
close.textContent = '✕';
|
|
close.addEventListener('click', () => panes.close(spec.id));
|
|
|
|
head.appendChild(title);
|
|
head.appendChild(close);
|
|
|
|
const body = document.createElement('div');
|
|
body.className = 'fb-pane-card-body fb-selectable';
|
|
|
|
card.appendChild(head);
|
|
card.appendChild(body);
|
|
dock().appendChild(card);
|
|
cards.set(spec.id, card);
|
|
_syncEmpty();
|
|
|
|
// The pane mounts into the body, never the card — so it cannot reach
|
|
// (or accidentally destroy) the chrome that owns its close button.
|
|
return body;
|
|
}
|
|
|
|
function unmount(id) {
|
|
const card = cards.get(id);
|
|
if (card) card.remove();
|
|
cards.delete(id);
|
|
_syncEmpty();
|
|
}
|
|
|
|
function focus(id) {
|
|
const card = cards.get(id);
|
|
if (!card) return;
|
|
card.scrollIntoView({ block: 'nearest', behavior: 'smooth' });
|
|
// Re-trigger the flash even if the class is already there (repeat focus
|
|
// of the same card would otherwise be a no-op animation).
|
|
card.classList.remove('is-flash');
|
|
void card.offsetWidth;
|
|
card.classList.add('is-flash');
|
|
setTimeout(() => card.classList.remove('is-flash'), 700);
|
|
}
|
|
|
|
panes.registerHost({ id: 'dock', priority: 0, available: () => !!document.body, mount, unmount, focus });
|
|
})();
|