mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-10 18:59:56 +00:00
The option-heavy player UIs (mixer, camera director, viz, audio routing)
all live in the rail popovers, which are exclusive: openPopFor() closes
the last one before opening the next. You cannot watch the mixer while
riding the camera, and both vanish the moment you look at the highway.
Add `window.feedBack.panes` — a core registry for live UI that is
authored once as `mount(root, ctx)` and hosted anywhere. Panes are
non-exclusive, and they survive song switches structurally: the dock is a
body child outside every .screen, so the per-song teardown never sees it.
The adoption cost for a plugin is two calls:
feedBack.panes.register({ id, title, icon, mount, unmount });
feedBack.panes.attachChip(myExistingDialogEl, id);
attachChip injects THE standard pop-out chip. Clicking it opens the pane
and hides the plugin's dialog, leaving a stub to bring it back. Core owns
the hide/restore, so every plugin's pop-out looks and behaves the same —
which is the point. It hides via a dedicated .fb-pane-detached class, not
.hidden/[hidden], because the dialogs we attach to already toggle those.
Everything a pane may touch arrives through `ctx` — never a global. That
is what will let the same mount() run inside a pop-out window, a separate
JS realm with no window.feedBack, no window.highway and no audio graph:
ctx.call(domain, cmd, payload) -> the capability bus
ctx.on(event, fn) -> the feedBack bus (allowlisted)
ctx.subscribe(stream, fn) -> playhead / meters
ctx.state.get/set -> persisted, main realm is the only writer
ctx.playhead(), ctx.song(), ctx.toast(), ctx.close()
ctx tracks every subscription it hands out and drops them on unmount, so
a pane cannot leak listeners across a dock/undock cycle.
Streams exist because an AnalyserNode cannot cross a window boundary:
levels are reduced to numbers in the realm that owns the audio graph.
One shared rAF loop, refcounted against live subscriptions, dirty-checked
before fan-out, and stopped dead when the last pane closes.
Hosts register themselves with the manager rather than being imported by
it — the dock lands at priority 0 (the floor, always available), so the
OS pane window can drop in later without this code changing.
Ships two built-in panes: Now Playing (the reference pane — reads the bus,
a stream, and levels, and touches no globals) and Mixer (the same faders
as the rail, via ctx.call('audio-mix', ...), with the chip attached to the
real #mixer-control). Plus a "Panes" rail popover to open panes that have
no dialog of their own; the system tray will mirror that list.
Note the dock sits at z-index 110, not on the docs/plugin-v3-ui.md ladder
(transport 20, rail 30, popovers 40) — those live INSIDE #player's
stacking context, and #player is itself fixed at z-index 100. A dock below
100 is invisible on the one screen panes exist for. Body-level ladder:
#player 100 < dock 110 < toasts 120 < modals 200.
Pop-out windows, the system tray, manifest-declared panes and mirrorGlobal
(the window.__h3dCamCtl proxy the camera director needs) follow.
Signed-off-by: topkoa <topkoa@gmail.com>
136 lines
5.2 KiB
JavaScript
136 lines
5.2 KiB
JavaScript
/*
|
|
* fee[dB]ack — the pop-out chip.
|
|
*
|
|
* One affordance, core-owned, identical everywhere: the small ⇱ button a plugin
|
|
* drops into a dialog it already has.
|
|
*
|
|
* feedBack.panes.register({ id: 'camera_director', title: 'Camera', mount, unmount });
|
|
* feedBack.panes.attachChip(myDialogEl, 'camera_director');
|
|
*
|
|
* That is the entire adoption cost. Clicking the chip opens the pane in its host
|
|
* and hides `myDialogEl`; a stub takes its place so the user can find it again;
|
|
* closing the pane un-hides the dialog and restores the chip. The plugin writes
|
|
* no show/hide logic — if it did, every plugin would invent a slightly different
|
|
* one, which is exactly the inconsistency this exists to prevent.
|
|
*
|
|
* Hiding uses `.fb-pane-detached`, NOT the `hidden` class or `[hidden]`, because
|
|
* the dialogs being hidden here already toggle those themselves (the core mixer
|
|
* popover, every rail popover). Two owners of one class is a bug waiting for a
|
|
* bad day; a dedicated class composes cleanly with whatever the dialog does.
|
|
*/
|
|
(function () {
|
|
'use strict';
|
|
|
|
const panes = window.feedBack && window.feedBack.panes;
|
|
if (!panes || typeof panes.register !== 'function') {
|
|
console.error('[panes] pane-manager.js must load before pane-chip.js');
|
|
return;
|
|
}
|
|
|
|
// paneId -> { el, chip, stub, spec }
|
|
const attached = new Map();
|
|
|
|
function _makeChip(spec) {
|
|
const b = document.createElement('button');
|
|
b.type = 'button';
|
|
b.className = 'fb-pane-chip';
|
|
b.title = 'Pop out';
|
|
b.setAttribute('aria-label', 'Pop out ' + spec.title);
|
|
b.textContent = '⇱';
|
|
b.addEventListener('click', (e) => {
|
|
// Rail popovers close on any document click that lands outside them
|
|
// (player-chrome.js). Without this the popover would close under the
|
|
// chip mid-click, which reads as the button not working.
|
|
e.stopPropagation();
|
|
e.preventDefault();
|
|
panes.detach(spec.id);
|
|
});
|
|
return b;
|
|
}
|
|
|
|
function _makeStub(spec) {
|
|
const s = document.createElement('button');
|
|
s.type = 'button';
|
|
s.className = 'fb-pane-stub';
|
|
s.setAttribute('aria-label', 'Bring ' + spec.title + ' back');
|
|
s.title = 'Bring it back';
|
|
const glyph = document.createElement('span');
|
|
glyph.className = 'fb-pane-stub-glyph';
|
|
glyph.textContent = '⇲';
|
|
const label = document.createElement('span');
|
|
label.textContent = spec.title + ' is popped out';
|
|
s.appendChild(glyph);
|
|
s.appendChild(label);
|
|
s.addEventListener('click', (e) => {
|
|
e.stopPropagation();
|
|
e.preventDefault();
|
|
panes.close(spec.id);
|
|
});
|
|
return s;
|
|
}
|
|
|
|
function _onOpened(rec) {
|
|
rec.el.classList.add('fb-pane-detached');
|
|
if (!rec.stub.isConnected) rec.el.parentNode.insertBefore(rec.stub, rec.el);
|
|
}
|
|
|
|
function _onClosed(rec) {
|
|
rec.el.classList.remove('fb-pane-detached');
|
|
rec.stub.remove();
|
|
}
|
|
|
|
/**
|
|
* attachChip(el, paneId, opts)
|
|
*
|
|
* `el` — the dialog to hide when the pane pops out. The chip is injected
|
|
* into `el.querySelector('[data-pane-header]')` when present, else
|
|
* prepended to `el` itself.
|
|
* `opts` — { header: Element } to place the chip somewhere specific.
|
|
*
|
|
* Returns a detach function that removes the chip and stub and restores the
|
|
* dialog — call it if your plugin tears its dialog down.
|
|
*/
|
|
function attachChip(el, paneId, opts) {
|
|
opts = opts || {};
|
|
if (!(el instanceof Element)) throw new TypeError('panes.attachChip: el must be an Element');
|
|
const spec = panes.get(paneId);
|
|
if (!spec) { console.warn('[panes] attachChip: register the pane first:', paneId); return () => {}; }
|
|
if (attached.has(paneId)) { console.warn('[panes] attachChip: already attached:', paneId); return () => {}; }
|
|
|
|
const chip = _makeChip(spec);
|
|
const stub = _makeStub(spec);
|
|
const host = opts.header || el.querySelector('[data-pane-header]') || el;
|
|
if (host === el) host.insertBefore(chip, host.firstChild);
|
|
else host.appendChild(chip);
|
|
|
|
const rec = { el, chip, stub, spec };
|
|
attached.set(paneId, rec);
|
|
|
|
// Reconcile immediately: register() reopens a pane the user left open at
|
|
// last unload, and that can land before (or after) attachChip runs.
|
|
if (panes.isOpen(paneId)) _onOpened(rec);
|
|
|
|
return () => {
|
|
if (attached.get(paneId) !== rec) return;
|
|
attached.delete(paneId);
|
|
chip.remove();
|
|
_onClosed(rec);
|
|
};
|
|
}
|
|
|
|
// One pair of bus listeners for every chip, rather than one pair per chip.
|
|
const bus = window.feedBack;
|
|
if (bus && typeof bus.on === 'function') {
|
|
bus.on('panes:opened', (e) => {
|
|
const rec = attached.get(e.detail && e.detail.id);
|
|
if (rec) _onOpened(rec);
|
|
});
|
|
bus.on('panes:closed', (e) => {
|
|
const rec = attached.get(e.detail && e.detail.id);
|
|
if (rec) _onClosed(rec);
|
|
});
|
|
}
|
|
|
|
window.feedBack.panes.attachChip = attachChip;
|
|
})();
|