mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-12 11:49:28 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
98 lines
4.0 KiB
JavaScript
98 lines
4.0 KiB
JavaScript
'use strict';
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const SONGS_JS = path.join(__dirname, '..', '..', 'static', 'v3', 'songs.js');
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
|
|
function extractBlock(src, startMarker) {
|
|
const start = src.indexOf(startMarker);
|
|
if (start === -1) throw new Error(`extractBlock: '${startMarker}' not found`);
|
|
const openBrace = src.indexOf('{', start);
|
|
let depth = 1;
|
|
let i = openBrace + 1;
|
|
while (i < src.length && depth > 0) {
|
|
const ch = src[i];
|
|
if (ch === '{') depth++;
|
|
else if (ch === '}') depth--;
|
|
i++;
|
|
}
|
|
if (depth !== 0) throw new Error(`extractBlock: unbalanced braces after '${startMarker}'`);
|
|
return src.slice(start, i);
|
|
}
|
|
|
|
function loadTuningHelpers() {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const start = src.indexOf('function _looksLikeRawTuningOffsets(');
|
|
const endMarker = 'window.feedBack.parseRawTuningOffsets = parseRawTuningOffsets;';
|
|
const end = src.indexOf(endMarker);
|
|
if (start === -1 || end === -1) throw new Error('tuning helpers not found');
|
|
const sandbox = { window: { feedBack: {} }, exports: {} };
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(
|
|
src.slice(start, end + endMarker.length) + '\n'
|
|
+ 'exports.displayTuningName = displayTuningName;\n'
|
|
+ 'exports.displayTuningTargets = displayTuningTargets;\n'
|
|
+ 'exports.parseRawTuningOffsets = parseRawTuningOffsets;',
|
|
sandbox
|
|
);
|
|
return sandbox.exports;
|
|
}
|
|
|
|
function renderSongCardBadge(song, helpers) {
|
|
const esc = (s) => String(s == null ? '' : s).replace(/[&<>"']/g, (c) => (
|
|
{ '&': '&', '<': '<', '>': '>', '"': '"', "'": ''' }[c]));
|
|
const tuningLabel = helpers.displayTuningName(song.tuning_name || song.tuning);
|
|
if (!tuningLabel) return '';
|
|
const rawOffsets = helpers.parseRawTuningOffsets(song.tuning_offsets)
|
|
|| helpers.parseRawTuningOffsets(song.tuning_name || song.tuning);
|
|
const targetNotes = (tuningLabel === 'Custom Tuning' && rawOffsets)
|
|
? helpers.displayTuningTargets(rawOffsets, { tuningName: tuningLabel })
|
|
: '';
|
|
if (targetNotes) {
|
|
return '<span class="absolute top-2 left-2 bg-fb-mid text-black text-[9px] font-bold px-1.5 py-0.5 rounded-sm leading-tight max-w-[5.5rem] text-center">'
|
|
+ esc('Custom Tuning') + '<br><span class="font-semibold tracking-wide">' + esc(targetNotes) + '</span></span>';
|
|
}
|
|
return '<span class="absolute top-2 left-2 bg-fb-mid text-black text-[10px] font-bold px-1.5 py-0.5 rounded-sm">' + esc(tuningLabel) + '</span>';
|
|
}
|
|
|
|
const helpers = loadTuningHelpers();
|
|
|
|
test('v3 songs.js uses display helpers for album-art tuning badge', () => {
|
|
const src = fs.readFileSync(SONGS_JS, 'utf8');
|
|
assert.match(src, /displayTuningName\(song\.tuning_name \|\| song\.tuning\)/);
|
|
assert.match(src, /displayTuningTargets/);
|
|
assert.match(src, /parseRawTuningOffsets/);
|
|
});
|
|
|
|
test('raw offset tuning_name does not appear in rendered card HTML', () => {
|
|
const html = renderSongCardBadge({ tuning_name: '-2 0 0 0 -2' }, helpers);
|
|
assert.doesNotMatch(html, /-2 0 0 0 -2/);
|
|
assert.match(html, /Custom Tuning/);
|
|
});
|
|
|
|
test('custom tuning card shows low-to-high note sequence when offsets available', () => {
|
|
const html = renderSongCardBadge({
|
|
tuning_name: 'Custom Tuning',
|
|
tuning_offsets: [-2, 0, 0, 0, -2, -2],
|
|
}, helpers);
|
|
assert.match(html, /Custom Tuning/);
|
|
assert.match(html, /D A D G A D/);
|
|
assert.doesNotMatch(html, /6:|D2|5th/);
|
|
});
|
|
|
|
test('known tuning appears unchanged in card HTML', () => {
|
|
const html = renderSongCardBadge({ tuning_name: 'E Standard' }, helpers);
|
|
assert.match(html, /E Standard/);
|
|
assert.doesNotMatch(html, /<br>/);
|
|
});
|
|
|
|
test('missing tuning hides badge', () => {
|
|
const html = renderSongCardBadge({ tuning_name: '' }, helpers);
|
|
assert.equal(html, '');
|
|
});
|