mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
af2949677a
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
47 lines
2.2 KiB
Markdown
47 lines
2.2 KiB
Markdown
# FeedBack Note Detect Benchmark — v1
|
|
|
|
A short test piece for tuning FeedBack's `note_detect` plugin. Eight
|
|
exercises, each isolating a specific detection failure mode. Run with
|
|
**Detect** enabled, play through, then export the diagnostic JSON
|
|
(Settings → Plugins → Note Detection → Download Diagnostic JSON, or
|
|
the button on the end-of-session summary modal).
|
|
|
|
- **Tempo**: 90 BPM
|
|
- **Tuning**: E standard (no capo)
|
|
- **Audio**: metronome click track only (downbeat = louder + higher
|
|
tone). Play *over* the click — `note_detect` listens to your guitar
|
|
signal, not the audio in this file.
|
|
- **Duration**: 139 s
|
|
|
|
## Sections
|
|
|
|
| Section | Tests | Watch in the diagnostic |
|
|
|---|---|---|
|
|
| A. Open strings (low→high→low) | Basic mono detection on each open string | `pure` (mic/audio chain), per-string accuracy |
|
|
| B. 5th-fret positions | Fretted-note detection across all 6 strings | per-string variance |
|
|
| C. 12th-fret octaves | Higher-frequency detection — YIN's octave-up risk | `sharp` bin spiking |
|
|
| D. Sustained notes (4 s) | The `active` held-on-pitch glow | `sharp`/`flat` drift while held |
|
|
| E. Hammer-on / pull-off | Transient detection without a fresh pick attack | `pure` (no transient registered) |
|
|
| F. Power chords (2-string) | Chord leniency on sparse voicings | `chordPartial` |
|
|
| G. Open major chords | Chord leniency on dense voicings (E, A, D, G) | `chordPartial` |
|
|
| H. Bends (half- + whole-step) | Single-note pitch tolerance with pitch in motion | `sharp` bin |
|
|
|
|
## Reporting
|
|
|
|
Share the JSON (schema `note_detect.diagnostic.v1`). It includes:
|
|
|
|
- Hit/miss totals split single-note vs chord
|
|
- Primary-cause bin per miss (pure / chord-partial / early / late / sharp / flat)
|
|
- Per-string hit rate
|
|
- Signed timing- and pitch-error percentiles (p10 / median / p90)
|
|
- Detection settings snapshot (method, tolerances, leniency)
|
|
- Per-judgment event log (capped at 2000 events) with the chart note's
|
|
technique flags so each miss can be re-binned by `SUS`/`B`/`H`/etc. offline
|
|
- `benchmark_hint`: `{title, artist, arrangement}` — filter on these
|
|
to bucket reports from different runs of this benchmark.
|
|
|
|
## Source
|
|
|
|
Built by `docs/benchmarks/note_detect_v1/build_benchmark.py` in the
|
|
feedBack repo. Tweak the exercise list there and regenerate.
|