mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-19 06:52:38 +00:00
main's JS suite has been red since the recent v3-library and player refactors landed. 17 of 18 failures were test harnesses/regexes that went stale behind real, intentional code changes; one was a genuine contract violation in the code. Code fix: - session-resume seek passed 'resume' as its _audioSeek reason; the documented contract (enforced by song_seek.test.js) requires multi-word kebab-case. Renamed to 'session-resume' — no consumer string-matches specific reasons, so this is rename-safe. Test updates (each pins the CURRENT contract): - highway_colors_facade: inject HWC_PRESETS + applyHighwayStringPreset (new preset feature); lock presets/applyPreset into the surface test - loop_api: stub _updateEditRegionBtn (new edit-region UI hook) - song_close: sandbox gets window.feedBack.playQueue; assert a real close abandons the queue (the new queue-aware behavior) - v3_keep_practicing: the shelf moved from client-side /api/stats/recent dedupe+gating to the server-side practice-suggestions recommender — tests now pin that (fetch, arrangement-aware card click, Promise.all) - v3_songs_tuning: card row variable renamed song → shown (grouped cards) - live_guitar_tone_source: accept literal ’ where ’ drifted in copy - legacy_shim_hits: normalize CRLF before fixed-width region() slicing (Windows-only failure; char windows shrank by one char per line) Suite: 987/987 locally (Windows), previously 968/987 (and 18 red on CI). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
100 lines
4.2 KiB
JavaScript
100 lines
4.2 KiB
JavaScript
'use strict';
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const SONGS_JS = path.join(__dirname, '..', '..', 'static', 'v3', 'songs.js');
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
|
|
function extractBlock(src, startMarker) {
|
|
const start = src.indexOf(startMarker);
|
|
if (start === -1) throw new Error(`extractBlock: '${startMarker}' not found`);
|
|
const openBrace = src.indexOf('{', start);
|
|
let depth = 1;
|
|
let i = openBrace + 1;
|
|
while (i < src.length && depth > 0) {
|
|
const ch = src[i];
|
|
if (ch === '{') depth++;
|
|
else if (ch === '}') depth--;
|
|
i++;
|
|
}
|
|
if (depth !== 0) throw new Error(`extractBlock: unbalanced braces after '${startMarker}'`);
|
|
return src.slice(start, i);
|
|
}
|
|
|
|
function loadTuningHelpers() {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const start = src.indexOf('function _looksLikeRawTuningOffsets(');
|
|
const endMarker = 'window.feedBack.parseRawTuningOffsets = parseRawTuningOffsets;';
|
|
const end = src.indexOf(endMarker);
|
|
if (start === -1 || end === -1) throw new Error('tuning helpers not found');
|
|
const sandbox = { window: { feedBack: {} }, exports: {} };
|
|
vm.createContext(sandbox);
|
|
vm.runInContext(
|
|
src.slice(start, end + endMarker.length) + '\n'
|
|
+ 'exports.displayTuningName = displayTuningName;\n'
|
|
+ 'exports.displayTuningTargets = displayTuningTargets;\n'
|
|
+ 'exports.parseRawTuningOffsets = parseRawTuningOffsets;',
|
|
sandbox
|
|
);
|
|
return sandbox.exports;
|
|
}
|
|
|
|
function renderSongCardBadge(song, helpers) {
|
|
const esc = (s) => String(s == null ? '' : s).replace(/[&<>"']/g, (c) => (
|
|
{ '&': '&', '<': '<', '>': '>', '"': '"', "'": ''' }[c]));
|
|
const tuningLabel = helpers.displayTuningName(song.tuning_name || song.tuning);
|
|
if (!tuningLabel) return '';
|
|
const rawOffsets = helpers.parseRawTuningOffsets(song.tuning_offsets)
|
|
|| helpers.parseRawTuningOffsets(song.tuning_name || song.tuning);
|
|
const targetNotes = (tuningLabel === 'Custom Tuning' && rawOffsets)
|
|
? helpers.displayTuningTargets(rawOffsets, { tuningName: tuningLabel })
|
|
: '';
|
|
if (targetNotes) {
|
|
return '<span class="absolute top-2 left-2 bg-fb-mid text-black text-[9px] font-bold px-1.5 py-0.5 rounded-sm leading-tight max-w-[5.5rem] text-center">'
|
|
+ esc('Custom Tuning') + '<br><span class="font-semibold tracking-wide">' + esc(targetNotes) + '</span></span>';
|
|
}
|
|
return '<span class="absolute top-2 left-2 bg-fb-mid text-black text-[10px] font-bold px-1.5 py-0.5 rounded-sm">' + esc(tuningLabel) + '</span>';
|
|
}
|
|
|
|
const helpers = loadTuningHelpers();
|
|
|
|
test('v3 songs.js uses display helpers for album-art tuning badge', () => {
|
|
const src = fs.readFileSync(SONGS_JS, 'utf8');
|
|
// The card renderer's row variable was renamed song → shown when grouped
|
|
// cards landed (the badge reads the representative chart); accept either.
|
|
assert.match(src, /displayTuningName\((?:song|shown)\.tuning_name \|\| (?:song|shown)\.tuning\)/);
|
|
assert.match(src, /displayTuningTargets/);
|
|
assert.match(src, /parseRawTuningOffsets/);
|
|
});
|
|
|
|
test('raw offset tuning_name does not appear in rendered card HTML', () => {
|
|
const html = renderSongCardBadge({ tuning_name: '-2 0 0 0 -2' }, helpers);
|
|
assert.doesNotMatch(html, /-2 0 0 0 -2/);
|
|
assert.match(html, /Custom Tuning/);
|
|
});
|
|
|
|
test('custom tuning card shows low-to-high note sequence when offsets available', () => {
|
|
const html = renderSongCardBadge({
|
|
tuning_name: 'Custom Tuning',
|
|
tuning_offsets: [-2, 0, 0, 0, -2, -2],
|
|
}, helpers);
|
|
assert.match(html, /Custom Tuning/);
|
|
assert.match(html, /D A D G A D/);
|
|
assert.doesNotMatch(html, /6:|D2|5th/);
|
|
});
|
|
|
|
test('known tuning appears unchanged in card HTML', () => {
|
|
const html = renderSongCardBadge({ tuning_name: 'E Standard' }, helpers);
|
|
assert.match(html, /E Standard/);
|
|
assert.doesNotMatch(html, /<br>/);
|
|
});
|
|
|
|
test('missing tuning hides badge', () => {
|
|
const html = renderSongCardBadge({ tuning_name: '' }, helpers);
|
|
assert.equal(html, '');
|
|
});
|