feedBack/docs/testing-plugins.md
Miguel_LZPF b45751164f
fix: address PR #332 review feedback
Addresses 12 of 13 review comments from Copilot and CodeRabbit on
PR #332. One comment (no-manifests in validate-plugins.yml) is
declined and answered inline; the rest are applied here.

Substantive fixes:

- .github/workflows/validate-plugins.yml — add --noconftest to the
  schema-tests step. tests/conftest.py imports structlog at module
  level, but the CI job only installs requirements-test.txt
  (pytest/httpx/jsonschema), so pytest collection would fail at
  conftest import. The schema tests don't use shared fixtures, so
  skipping conftest is safe and avoids dragging the full runtime
  requirements into a 2 KB validation job. (Copilot)

- schema/plugin.schema.json — tighten the server_files regex on both
  settings.server_files and diagnostics.server_files to match the
  runtime _validate_relpath rules in plugins/__init__.py. The
  previous regex only blocked absolute paths, drive letters,
  backslashes, and "..". The runtime also rejects "//", "./",
  "/./", and leading-dotfile segments. Schema-valid manifests are
  now also load-time-valid. Verified the regex against 12 cases:
  the 3 in-tree manifests still validate. (Copilot)

- .claude/skills/plugin-validate/SKILL.md — add a per-iteration
  plugin_ok flag so we no longer print "OK <path>" after an earlier
  FAIL in the same manifest. Schema-pass + id-mismatch previously
  produced both FAIL and OK lines for one plugin. (CodeRabbit)

- docs/websocket-protocol.md — clarify song_info.tuning array length
  is source-dependent (typically 6 guitar, 4 bass, but extended-range
  GP imports can be 7/8/5/6). Recommend highway.getStringCount() for
  the authoritative count. Line 30 already said this; the table row
  on line 12 was the stale half. (CodeRabbit)

Trivial fixes:

- .claude/rules/plugin-author.md — "wants included" -> "wants to
  include" in the settings.server_files rule. (CodeRabbit)

- Markdown MD040 — add `text` language tags to 7 bare-fence code
  blocks across AGENTS.md, docs/PLUGIN_AUTHORING.md,
  docs/testing-plugins.md, docs/plugin-logging.md, .claude/README.md,
  .claude/agents/slopsmith-reviewer.md, and
  .claude/skills/plugin-validate/SKILL.md (two fences). (CodeRabbit)

Declined:

- .github/workflows/validate-plugins.yml no-manifests -> exit 0
  (CodeRabbit suggested exit 1). Plugins in this repo are in-tree,
  not submodules (no .gitmodules, git submodule status empty), and
  the workflow has a path filter on plugins/**/plugin.json so it
  only runs when a manifest actually changes. Exit 0 is correct.
  Answered inline on the PR.

Verification:
  pytest tests/test_plugin_schema.py -v --noconftest    # 8 passed
  python -c "import json,glob,jsonschema; s=json.load(open('schema/plugin.schema.json')); [jsonschema.validate(json.load(open(p)), s) for p in sorted(glob.glob('plugins/*/plugin.json'))]"
  # ok — all 3 in-tree manifests validate against tightened schema
Signed-off-by: Miguel_LZPF <mgcdreamer@gmail.com>
2026-06-18 00:38:51 -07:00

5.0 KiB

Testing plugins

Slopsmith has three test surfaces — Python unit/integration tests (pytest), JS plugin-API contract tests (Node), and end-to-end browser tests (Playwright). This doc covers what to use when.

Test layout

tests/
├── conftest.py          Shared pytest fixtures (isolate_logging)
├── test_plugins.py      Plugin loader + load_sibling + collision tests (includes reset_plugin_state)
├── test_song.py         Wire-format serialization round-trips
├── test_*.py            Per-feature backend tests
├── js/                  Node --test JS plugin-API contract tests
└── browser/             Playwright end-to-end tests

Running tests

pytest                              # All Python tests
pytest tests/test_plugins.py -v     # Specific file
pytest -k "load_sibling" -v         # Pattern match

npm run test:js                     # Node-native JS contract tests
npm run install:playwright          # One-time: install Chromium
npm test                            # Playwright browser tests
npm run test:headed                 # Playwright with visible browser
npm run test:debug                  # Playwright inspector

CI runs pytest on every push/PR to main (Python 3.12).

Shared fixtures

isolate_logging (in conftest.py)

Saves and restores handlers, level, and propagate flag on the slopsmith, uvicorn, uvicorn.error, and uvicorn.access loggers, plus calls structlog.reset_defaults(). Import into any test module that calls configure_logging() so mutations don't bleed across tests.

def test_my_log_thing(isolate_logging):
    configure_logging()
    # ... assertions

reset_plugin_state (in test_plugins.py)

Local fixture used by plugin-loader tests. Saves and restores:

  • plugins.LOADED_PLUGINS
  • any plugin_* keys in sys.modules
  • the bare names the tests simulate (util, extractor) in sys.modules
  • sys.path (the loader mutates it)

Also unsets SLOPSMITH_PLUGINS_DIR for the test's duration via monkeypatch so a CI env that pre-sets it can't leak real user plugins into a tmp-path-driven test.

If you're authoring a plugin that ships top-level helper modules, model new tests on the patterns in test_plugins.py — use reset_plugin_state to guarantee a clean import slate.

Backend test patterns

  • Wire-format round-trips. test_song.py is the model: pure serialization tests, no fixtures, narrative docstring. Pattern: build a Song/Arrangement/Note, serialize, deserialize, assert equal.
  • Loader behaviour. test_plugins.py uses tmp-path-driven plugin roots + reset_plugin_state + _make_plugin / _run_load_plugins helpers. Adopt these helpers for any new loader-touching tests.
  • Async / WebSocket. Tests for FastAPI WebSocket endpoints use httpx.AsyncClient and app.websocket_connect(). See test_audio.py and test_highway_3d_routes.py for examples.

JS contract tests (tests/js/)

Plain node --test files. No browser, no server. Cover the plugin-API surface as exposed on window.slopsmith and related globals. Run with npm run test:js.

Use these when a plugin needs to assert against the API contract without spinning up a real browser. They run in seconds; CI can grow these without slowing.

Browser tests (tests/browser/)

Playwright + Chromium. playwright.config.ts runs serially (workers: 1) and boots a real Slopsmith instance via Docker Compose. Traces / video on failure.

What's currently covered: page load and keyboard shortcuts. No plugin E2E patterns yet — if you're adding the first one for your plugin, set the precedent. Suggested structure:

import { test, expect } from '@playwright/test';

test('my plugin loads its navbar entry', async ({ page }) => {
    await page.goto('/');
    await expect(page.getByRole('link', { name: 'My Plugin' })).toBeVisible();
});

test('my plugin shortcut fires', async ({ page }) => {
    await page.goto('/#plugin-my_plugin');
    await page.keyboard.press('k');
    await expect(page.getByTestId('my-plugin-toggle')).toHaveAttribute('aria-pressed', 'true');
});

Prefer data-testid over text-based selectors so refactors don't break tests.

Debugging

  • Browser console shortcut inventory. _listShortcuts() prints every registered shortcut, its scope, and source.
  • LOG_FORMAT=json pytest — get machine-readable test logs.
  • pytest -s — disable output capture (handy for print()-style debug, though prefer log.debug() in production code).
  • Playwright trace viewernpx playwright show-trace test-results/.../trace.zip after a failure.