mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-23 21:32:33 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
104 lines
2.3 KiB
Markdown
104 lines
2.3 KiB
Markdown
# Browser Tests
|
|
|
|
This directory contains Playwright browser tests for FeedBack keyboard shortcuts.
|
|
|
|
## Prerequisites
|
|
|
|
1. **FeedBack web server**: Tests need the server reachable at `http://localhost:8000`.
|
|
Playwright auto-starts it via `webServer.command` in `playwright.config.ts`, so manual
|
|
startup is optional. Start it manually if you want to debug the server, run tests
|
|
outside Playwright, or skip the per-run boot delay:
|
|
```bash
|
|
LIBRARY_PATH=/path/to/your/library docker compose up -d
|
|
```
|
|
Playwright reuses an already-running server locally (`reuseExistingServer: true`).
|
|
|
|
2. **Node.js installed**: Required for running Playwright tests
|
|
```bash
|
|
node --version # Should be v18 or higher
|
|
```
|
|
|
|
## Installation
|
|
|
|
Install dependencies:
|
|
```bash
|
|
npm install
|
|
```
|
|
|
|
Install Playwright browsers:
|
|
```bash
|
|
npm run install:playwright
|
|
```
|
|
|
|
## Running Tests
|
|
|
|
Run all tests:
|
|
```bash
|
|
npm test
|
|
```
|
|
|
|
Run tests in headed mode (watch the browser):
|
|
```bash
|
|
npm run test:headed
|
|
```
|
|
|
|
Debug tests with interactive inspector:
|
|
```bash
|
|
npm run test:debug
|
|
```
|
|
|
|
## Test Files
|
|
|
|
- `basic-load.spec.ts` - Basic app load and shortcut registry availability
|
|
- `check-errors.spec.ts` - Check for console errors
|
|
- `keyboard-shortcuts.spec.ts` - Comprehensive keyboard shortcut tests
|
|
|
|
## Writing Tests
|
|
|
|
Tests use Playwright's test API. Example:
|
|
|
|
```typescript
|
|
import { test, expect } from '@playwright/test';
|
|
|
|
test('my test', async ({ page }) => {
|
|
await page.goto('/');
|
|
await page.waitForSelector('.screen.active');
|
|
|
|
// Interact with the page
|
|
await page.keyboard.press('?');
|
|
|
|
// Assert
|
|
await expect(page.locator('#shortcuts-modal')).toBeVisible();
|
|
});
|
|
```
|
|
|
|
## Troubleshooting
|
|
|
|
### Container won't start
|
|
If the Docker container exits immediately, check the logs:
|
|
```bash
|
|
docker compose logs
|
|
```
|
|
|
|
Common issue: Missing dependencies. Rebuild the container:
|
|
```bash
|
|
docker compose build --no-cache
|
|
docker compose up -d
|
|
```
|
|
|
|
### Tests timeout
|
|
Increase timeout in `playwright.config.ts` if needed.
|
|
|
|
### LIBRARY_PATH not set
|
|
Make sure to set the LIBRARY_PATH environment variable:
|
|
```bash
|
|
LIBRARY_PATH=~/feedBack-library docker compose up -d
|
|
```
|
|
|
|
## CI/CD
|
|
|
|
In CI environments, Playwright will:
|
|
- Run tests in headless mode
|
|
- Retry failed tests up to 2 times
|
|
- Generate HTML report with screenshots/videos on failure
|