mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-22 04:41:23 +00:00
b6098e3695
* perf(harness): add 2D-highway frame-time measurement + capture the R3c gate (H0) scripts/perf-baseline.mjs gains a `--song` mode: it wraps requestAnimationFrame before any page script, TAGS the frames the highway actually painted (via highway.addDrawHook), starts playback, and reports draw-frame p50/p95/p99 over `--frames` seconds across `--runs` runs. Tagging is the point — ~half the rAF callbacks are other cheap loops (~0.1 ms); averaging them in would hide a renderer regression, so only draw frames are counted. This is the metric the plan says gates the highway.js split (R3c) but the harness never measured (it did server latency + boot + heap only, and the R0 numbers were against an empty library). docs/perf-baseline.md now records the pre-lift baseline on the Arcturus feedpak: p50 ~2.2 ms, p95 spread 2.7-3.2 ms across 3 runs. The H-container lift (next) re-runs this on the same box and must stay within noise. Maintainer/CI-only tooling; the existing no-`--song` run is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * perf(harness): close page on error + MD040 fence + CHANGELOG (CodeRabbit) - frameTimeOnce now closes its page in a finally, so a failing run doesn't leak the page until the final browser.close() (CodeRabbit). - fenced code block gets a bash language hint (MD040). - CHANGELOG mentions the new --song frame-time mode. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
93 lines
3.7 KiB
Markdown
93 lines
3.7 KiB
Markdown
# Perf baseline — module-migration refactor
|
||
|
||
The refactor promises "measured runtime wins, no hand-waved perf claims" and
|
||
"screen-entry and frame-time no worse." This is the baseline to hold it to.
|
||
Rerun the harness after every phase (R0 → R3c) and compare.
|
||
|
||
## Running it
|
||
|
||
```
|
||
# 1. start core against a library with real charts (see caveat below)
|
||
CONFIG_DIR=… DLC_DIR=/path/to/songs PYTHONPATH=lib \
|
||
python3 -m uvicorn server:app --host 127.0.0.1 --port 8000
|
||
|
||
# 2. capture (maintainer/CI-only; uses the committed Playwright chromium)
|
||
node scripts/perf-baseline.mjs --base http://127.0.0.1:8000 --n 60 --soak 30
|
||
```
|
||
|
||
The script prints a markdown block; paste it under "Results" below with the date
|
||
and the commit it was taken at.
|
||
|
||
## What it measures
|
||
|
||
- **Server latency** — p50/p95/p99 over N requests for `/api/version`,
|
||
`/api/plugins`, `/api/library`, `/api/library/artists`.
|
||
- **Cold boot → interactive** — full page load to `networkidle`.
|
||
- **JS heap** — `performance.memory.usedJSHeapSize` after load and after an idle
|
||
soak (a leak signal across a session).
|
||
- **Plugin-script shape** — how many plugin `<script>`s the loader injected (a
|
||
"the app booted with its plugins" sanity signal).
|
||
|
||
**Not yet captured — needs a seeded library with charts** (fill in when run
|
||
against a real environment): playback **frame-time p95** on the 2D and 3D
|
||
highway, and **screen-entry** (plugin inject → interactive) for
|
||
editor / notedetect / highway_3d with a chart loaded. These are the
|
||
perf-sensitive numbers that gate the `highway.js` split (R3c); the harness has
|
||
the hooks, they just need real songs in `DLC_DIR`.
|
||
|
||
## Results
|
||
|
||
### R3c pre-lift baseline — 2026-07-10 (2D highway draw cost)
|
||
|
||
The gate for the `highway.js` split. Captured on a seeded library (the 33 MB
|
||
Arcturus feedpak) with the new `--song` mode, which measures **per-frame draw
|
||
cost** — rAF callbacks are tagged via `highway.addDrawHook`, so only frames the
|
||
highway actually painted count (the other ~half are cheap no-op loops that would
|
||
otherwise mask a regression). Any `highway.js` change must re-run this on the
|
||
same machine and stay within noise of these numbers.
|
||
|
||
```bash
|
||
node scripts/perf-baseline.mjs --base http://127.0.0.1:8300 \
|
||
--song "Arcturus - The Sham Mirrors - Kinetic.feedpak"
|
||
```
|
||
|
||
| run | draw frames | p50 | p95 | p99 | max |
|
||
|---|---|---|---|---|---|
|
||
| 1 | 53/106 | 2.2 | 3.2 | 3.6 | 3.6 |
|
||
| 2 | 50/100 | 2.2 | 2.9 | 3.2 | 3.2 |
|
||
| 3 | 53/106 | 2.1 | 2.7 | 3.5 | 3.5 |
|
||
|
||
**p50 ≈ 2.2 ms · p95 spread 2.7–3.2 ms** (3 runs × 10 s playback, headless
|
||
chromium on the dev box). The `H`-container lift changes each closure-slot read
|
||
to a `H.<slot>` property load; this is the number that proves it doesn't cost the
|
||
hot loop.
|
||
|
||
### R0 baseline — 2026-07-08 (branch `feat/r0-plugin-module-rails`)
|
||
|
||
> ⚠️ A quick capture (`--n 50 --soak 8`) against an **empty** library (no charts
|
||
> in `DLC_DIR`), so the `/api/library*` and boot numbers are floor values —
|
||
> re-take on a seeded environment with the recommended `--n 60 --soak 30` for the
|
||
> real R0 baseline before comparing R1+ against it. Recorded here to prove the
|
||
> harness and lock the methodology.
|
||
|
||
Server latency (ms), n=50:
|
||
|
||
| Endpoint | status | p50 | p95 | p99 |
|
||
|---|---|---|---|---|
|
||
| `/api/version` | 200 | 0.9 | 1.8 | 22.3 |
|
||
| `/api/plugins` | 200 | 1.6 | 2.1 | 3.4 |
|
||
| `/api/library?limit=60` | 200 | 1.4 | 1.7 | 2.9 |
|
||
| `/api/library/artists` | 200 | 1.3 | 1.8 | 2.7 |
|
||
|
||
Client:
|
||
|
||
| Metric | Value |
|
||
|---|---|
|
||
| Cold boot → networkidle | 1268 ms |
|
||
| JS heap after load | 10.1 MB |
|
||
| JS heap after idle soak | 10.1 MB (no idle growth) |
|
||
| Plugin scripts injected | 12 |
|
||
|
||
No plugin has migrated yet, so all 12 are classic. When the R1 pilot (stems)
|
||
lands, cold-boot / heap should not regress.
|