2 Commits

Include renames

Author	SHA1	Message	Date
3 people	d9fa6d3f55	refactor(highway): make the highway global explicit before the module flip (R3c) (#912) ... 73 bare `highway.x` references -> `window.highway.x`, across app.js and 10 other files. Provably a NO-OP today. It is the precondition for flipping highway.js to a module. ━━━ WHY THIS HAS TO LAND FIRST ━━━ highway.js is a CLASSIC script. Its top-level `const highway = createHighway()` therefore creates a GLOBAL LEXICAL BINDING — visible as a bare name to every other classic script AND to every ES module. 73 call sites quietly rely on that. The moment highway.js becomes a module, that binding is gone. `const` in a module is module-scoped, not global. Every one of those 73 sites becomes a ReferenceError, and the flip is impossible until they say what they mean. `window.highway = highway` is already set, to the same object, on the same line. So this is an identity rewrite — verified in the browser below. ━━━ THE REWRITE BIT ME THREE TIMES. REGEX IS NOT ENOUGH FOR THIS. ━━━ 1. A SHADOWED LOCAL. capabilities/note-detection.js does `const highway = window.highway`. Its 9 bare uses are LOCAL and already correct; a blind rewrite would have emitted `const window.highway = window.highway`. Excluded. 2. HALF-CONVERTED GUARDS — the dangerous one. Six sites read `typeof highway !== 'undefined' && highway && typeof highway.setTime === 'function'`. The regex converted the CONSEQUENT and left the TEST, which is WORSE than not touching them: after the flip `typeof highway` is 'undefined', so each guard is PERMANENTLY FALSE and the code behind it silently never runs. transport.js's was the seek->setTime sync: the chart clock would have quietly desynced after every seek, with nothing failing. All six now test window.highway. 3. TWO MORE BARE REFERENCES, found by Codex [P2] and confirmed by an AST scan: app.js:3114 and :3176 use `highway && typeof window.highway.getSections === 'function'`. My grep searched for `typeof highway`, not `highway &&`. After the flip these throw, the catch swallows it, and the editor silently falls back to a ±4s edit window and arrangement 0. Regex missed a shadow, a half-conversion, and two bare reads. The final check is an AST pass that resolves scopes and reports every `highway` identifier not bound locally. It now reports ZERO. VERIFIED. A/B against origin/main in two browsers, 15 probes, IDENTICAL, zero page errors: window.highway is the same object as the bare global, the whole API surface resolves, a real song plays, the chart clock advances, getPerf().drawMs > 0 — and `seek syncs chart` passes, which is the exact guard I nearly broke in (2). node 1045, pytest 2416, ESLint 0, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 11:56:07 +02:00
3 people	8bec8d2466	refactor(app): carve the playback transport out of app.js — and RETIRE 8 host hooks (R3a) (#894) ... static/js/transport.js (377) — bodies VERBATIM. app.js 6,643 → 6,316. THIS IS THE FIRST CARVE THAT SUBTRACTS HOOKS INSTEAD OF ADDING THEM. Every carve before this one added host hooks: a module pulled out of app.js still had to call back into it. But four modules were all reaching through the seam for the SAME handful of names — _audioSeek, _audioTime, setPlayButtonState, _songEventPayload, jucePlayer. Those names have an owner, and it isn't app.js. Give them one, and the consumers import them directly: count-in.js 5 hooks -> 0 (host import deleted) juce-audio.js 4 hooks -> 0 (host import deleted) loops.js 6 hooks -> 4 section-practice.js 10 hooks -> 7 ---------------------------------------------------------- configureHost() 20 hooks -> 12 A hook is a cycle you agreed to live with. An import is a dependency you actually have. Prefer the import whenever the name has a real owner. _audioSeekGen now stays PRIVATE. It has exactly one writer — _resetAudioSeekState(), which moved with it — so readers get audioSeekGen() and nobody outside can desync it. Strictly better than the hook it replaces, which handed out a getter and left the writer behind in app.js. THE SCAN HAD A HOLE, AND IT BIT. Picking the carve by dependency closure over app.js's own top-level decls said this cluster was downward-closed. It wasn't: _currentPlaybackSnapshot reads loopA/loopB — which live in ./js/loops.js, and loops.js imports transport. The scan saw nothing, because loopA STOPPED BEING an app.js decl the moment loops.js was carved out. Any dependency scan of a partly-carved monolith has to resolve the imports too, or it will confidently hand you a cycle. Added that pass; it found exactly one back-edge, and _currentPlaybackSnapshot stays in app.js (as does restartCurrentSong, which calls _cancelCountIn). app.js is the root — it imports both sides for free. TESTS. Four harnesses retargeted (play_button_reroute_guard, song_event_payload, song_seek -> transport.js; playback_app_adapter SPLIT, since _installPlaybackTransportAdapter stayed behind). The two CENSUS tests — "≥8 song:* emit sites", "every seek callsite passes a reason" — now scan app.js AND every static/js/*.js, not one file. Pointed at a single file, their count silently shrinks as code leaves, which reads as "someone deleted an emit" or, worse, passes while genuinely missing sites. Both bite-tested: stripping a _songEventPayload() from an emit and adding a reason-less _audioSeek() each fail the suite. VERIFIED. A/B against origin/main, real song, real playback: song:play payload is exactly {audioT, chartT, perfNow, time}; song:seek carries reason "seek-by" with finite from/to; all five song:* events fire; seekBy advances the clock; restartCurrentSong returns to zero; the play button's aria-pressed tracks state. IDENTICAL on all 21 probes, zero page errors. pytest 2396, node 1040/1040, host contract 2/2, ESLint 0 (no-cycle clean), Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 23:26:35 +02:00