4 Commits

Include renames

Author	SHA1	Message	Date
3 people	8bec8d2466	refactor(app): carve the playback transport out of app.js — and RETIRE 8 host hooks (R3a) (#894) ... static/js/transport.js (377) — bodies VERBATIM. app.js 6,643 → 6,316. THIS IS THE FIRST CARVE THAT SUBTRACTS HOOKS INSTEAD OF ADDING THEM. Every carve before this one added host hooks: a module pulled out of app.js still had to call back into it. But four modules were all reaching through the seam for the SAME handful of names — _audioSeek, _audioTime, setPlayButtonState, _songEventPayload, jucePlayer. Those names have an owner, and it isn't app.js. Give them one, and the consumers import them directly: count-in.js 5 hooks -> 0 (host import deleted) juce-audio.js 4 hooks -> 0 (host import deleted) loops.js 6 hooks -> 4 section-practice.js 10 hooks -> 7 ---------------------------------------------------------- configureHost() 20 hooks -> 12 A hook is a cycle you agreed to live with. An import is a dependency you actually have. Prefer the import whenever the name has a real owner. _audioSeekGen now stays PRIVATE. It has exactly one writer — _resetAudioSeekState(), which moved with it — so readers get audioSeekGen() and nobody outside can desync it. Strictly better than the hook it replaces, which handed out a getter and left the writer behind in app.js. THE SCAN HAD A HOLE, AND IT BIT. Picking the carve by dependency closure over app.js's own top-level decls said this cluster was downward-closed. It wasn't: _currentPlaybackSnapshot reads loopA/loopB — which live in ./js/loops.js, and loops.js imports transport. The scan saw nothing, because loopA STOPPED BEING an app.js decl the moment loops.js was carved out. Any dependency scan of a partly-carved monolith has to resolve the imports too, or it will confidently hand you a cycle. Added that pass; it found exactly one back-edge, and _currentPlaybackSnapshot stays in app.js (as does restartCurrentSong, which calls _cancelCountIn). app.js is the root — it imports both sides for free. TESTS. Four harnesses retargeted (play_button_reroute_guard, song_event_payload, song_seek -> transport.js; playback_app_adapter SPLIT, since _installPlaybackTransportAdapter stayed behind). The two CENSUS tests — "≥8 song:* emit sites", "every seek callsite passes a reason" — now scan app.js AND every static/js/*.js, not one file. Pointed at a single file, their count silently shrinks as code leaves, which reads as "someone deleted an emit" or, worse, passes while genuinely missing sites. Both bite-tested: stripping a _songEventPayload() from an emit and adding a reason-less _audioSeek() each fail the suite. VERIFIED. A/B against origin/main, real song, real playback: song:play payload is exactly {audioT, chartT, perfNow, time}; song:seek carries reason "seek-by" with finite from/to; all five song:* events fire; seekBy advances the clock; restartCurrentSong returns to zero; the play button's aria-pressed tracks state. IDENTICAL on all 21 probes, zero page errors. pytest 2396, node 1040/1040, host contract 2/2, ESLint 0 (no-cycle clean), Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 23:26:35 +02:00
3 people	5fb28d5c5a	refactor(app): lift the shared player state onto a container (R3a) (#889) ... static/js/player-state.js — one exported object, two fields. app.js's 70 reference sites rewritten. Provably a no-op; nothing shrinks. WHY NOW. Every slice carved out of app.js so far only ever READ the state it shared (loopA/loopB, _audioSeekGen, currentFilename), so a read-only getter hook was enough and no container was needed — twice I checked and twice I got away with it. That runs out at count-in: it genuinely WRITES `isPlaying` (it starts and stops playback, 4 sites) and `lastAudioTime` (2). `import { isPlaying }` then `isPlaying = true` THROWS — an imported binding cannot be assigned to. So the state has to live on an object: `S.isPlaying = true` is a property write, and works from any module holding the same S. Same shape stems, studio, and editor all converged on. DELIBERATELY SMALL. app.js has ~104 top-level `let` scalars; lifting all of them is a ~977-site rewrite for no benefit, because most are private to one cluster and travel with it. Only what a carved module must WRITE goes here. Add on demand. THE REWRITE IS AST-DRIVEN, NOT TEXTUAL — and that is not fussiness. Of 100 textual occurrences of these two names, only 70 resolve to the module binding: * 22 are member accesses (`someObj.isPlaying`, `window.feedBack.isPlaying`) * 4 are the LOCAL PARAMETER of `function setPlayButtonState(isPlaying)` — a blind replace yields `function setPlayButtonState(S.isPlaying)` * 1 is an object key * 2 are shorthand properties `{ isPlaying }`, which must become `{ isPlaying: S.isPlaying }` — and acorn gives a shorthand's key and value the SAME range, so rewriting both produced `isPlaying: S.isPlaying: S.isPlaying` until I deduped by range A find-and-replace corrupts all 29. The rewrite walks the AST, skips shadows, member properties and keys, and replaces identifier RANGES. `window.feedBack.isPlaying` — the PUBLIC mirror — is a different thing and is untouched. Two test sandboxes stub it; those were left alone deliberately. VERIFIED WITH REAL PLAYBACK. A/B against origin/main in two browsers, real song: togglePlay -> the public mirror goes true -> false -> true across two toggles, the audio element's paused state follows, seekBy works — IDENTICAL, zero page errors. Harnesses: 8 vm-sandbox suites slice playback code out of app.js and now see S.isPlaying — juce_engine_reroute, loop_restart, play_button_reroute_guard, playback_app_adapter, song_restart, song_seek, speed_reset, and the python idempotence source-assert. Each gets the same container in its sandbox; every assertion is unchanged. pytest 2396, node 1040/1040, ESLint 0, tailwind clean, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 21:52:51 +02:00
4 people	af2949677a	rename: slopsmith → feedBack, byron → got-feedBack (#537) ... * Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-23 11:03:01 +02:00
byrongamatos	6c110398b4	Clean release snapshot	2026-06-16 18:47:13 +02:00