The plugin loader runs a synchronous 'pip install' for each plugin's
requirements.txt at startup (1800s timeout each), and only wrote a success
marker — so a plugin whose install fails (heavy optional deps like
torch/whisperx/demucs on a machine that can't build them, or offline)
re-attempts and re-blocks startup on EVERY boot. On a distributed host
(slopsmith-desktop) this hangs the backend past the app's readiness window.
- Honour SLOPSMITH_SKIP_PLUGIN_INSTALL: hosts that bundle their own runtime
(e.g. the desktop app) set it to skip the blocking startup install entirely.
The plugin still loads and degrades gracefully when its optional deps are
absent.
- Write a .failed_<plugin> marker (req-hash keyed) on a failed install and skip
re-attempting the same failing requirements on subsequent boots — retry only
when requirements.txt changes or the marker is cleared. Marker reads are
guarded (unreadable marker -> treat as no-match, never raises out); the
success path writes the success marker and clears any stale failure marker in
independent best-effort blocks so a successful install can never be recorded
as a sticky failure.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
(cherry picked from commit 3fa776c6cd1a569bb4206c91fd89cedf4b00f17d)
- diagnostics_redact: keep '.psarc' in the song-filename scrub regex.
The purge swapped it for '.archive' (not a real extension), which
would leak real .psarc filenames still on users' disks into
diagnostic bundles. This is a redaction allow-list, not brand text.
- sloppak: the legacy lyrics-source alias was a no-op
({"notechart": "notechart"}), so old manifests with
lyrics_source=="sng" fell back to "xml" instead of migrating.
Map {"sng": "notechart"} so the rename stays back-compatible.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reword comments/docstrings/strings and rename identifiers that referenced
the external game and its file formats:
- format-id "psarc" -> "archive"; local vars psarc_path -> song_path,
psarc_base -> tone_base
- lyrics provenance value "sng" -> "notechart" (legacy "sng" still accepted)
- highway_3d fret-ghost scope value "rocksmith" -> "chords" (invalid/legacy
values fall back to the default, preserving behaviour)
- neutralise references in prose, test names/data, .gitattributes and docs
No functional change beyond the renamed identifiers; all Python compiles.
Remove the vestigial encrypted-archive ingestion path that the loader can
no longer service:
- scanner no longer lists .psarc files; library is sloppaks + loose folders
- upload endpoint accepts .sloppak only (drop .psarc + magic-byte branch)
- delete endpoint handles sloppak/loose only
- drop the psarc_platform (pc/mac) setting, its validation and tests
- default CONFIG_DIR no longer references an external game data folder
- drop the now-unused pycryptodome dependency (no module imports it)
- correct stale comments that described scanning as archive decryption
Updates test_settings_api / test_settings_export to match (scan fixtures
now build .sloppak stubs).
Drop an orphaned 4 MB binary fixture that no test references, and fix
two docstrings that inaccurately described the scanner as performing
archive decryption. The loader is sloppak/loose-folder only and does
not decode proprietary archives (see lib/scan_worker.py).
