got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-09-13 07:18:32 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(library): wire "Identify by audio" in the tabbed popup's Match tab

Browse Source 
The AcoustID Identify button (#759) merged in referencing an out-of-scope
`panel` in the wiring — a leftover from the pre-popup fix-match modal that my
tab refactor renamed to `root`. Under strict mode that threw, so the handler
never attached and the button did nothing. Scope it to `root` (the tab body),
which is where the search-results area it renders into lives.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
ChrisBeWithYou
2026-07-05 21:06:59 +02:00
committed by byrongamatos
co-authored by Claude Opus 4.8
parent 9ace7a3401
commit 9e827d8353
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/v3/match-review.js
+4 -1
View File
@@ -412,7 +412,10 @@
const go = () => runSearch(root, song); const go = () => runSearch(root, song);
root.querySelector('[data-mr-search-go]')?.addEventListener('click', go); root.querySelector('[data-mr-search-go]')?.addEventListener('click', go);
input?.addEventListener('keydown', (e) => { if (e.key === 'Enter') { e.preventDefault(); go(); } }); input?.addEventListener('keydown', (e) => { if (e.key === 'Enter') { e.preventDefault(); go(); } });
panel.querySelector('[data-mr-identify]')?.addEventListener('click', () => runIdentify(panel, song)); // Identify-by-audio (AcoustID, #759) renders its hits into the same
// search-results area — scope to `root` (the tab body / panel), not the
// out-of-scope `panel` the pre-refactor #759 wiring referenced.
root.querySelector('[data-mr-identify]')?.addEventListener('click', () => runIdentify(root, song));
} }
// ── Tabbed single-song popup (slice 4) ─────────────────────────────────── // ── Tabbed single-song popup (slice 4) ───────────────────────────────────