From 9e827d8353ad186c4595de87fc63ece77373df3a Mon Sep 17 00:00:00 2001 From: ChrisBeWithYou Date: Sat, 4 Jul 2026 18:25:11 -0500 Subject: [PATCH] fix(library): wire "Identify by audio" in the tabbed popup's Match tab MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The AcoustID Identify button (#759) merged in referencing an out-of-scope `panel` in the wiring — a leftover from the pre-popup fix-match modal that my tab refactor renamed to `root`. Under strict mode that threw, so the handler never attached and the button did nothing. Scope it to `root` (the tab body), which is where the search-results area it renders into lives. Co-Authored-By: Claude Opus 4.8 (1M context) --- static/v3/match-review.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/static/v3/match-review.js b/static/v3/match-review.js index ebeaea1..23cf5b2 100644 --- a/static/v3/match-review.js +++ b/static/v3/match-review.js @@ -412,7 +412,10 @@ const go = () => runSearch(root, song); root.querySelector('[data-mr-search-go]')?.addEventListener('click', go); input?.addEventListener('keydown', (e) => { if (e.key === 'Enter') { e.preventDefault(); go(); } }); - panel.querySelector('[data-mr-identify]')?.addEventListener('click', () => runIdentify(panel, song)); + // Identify-by-audio (AcoustID, #759) renders its hits into the same + // search-results area — scope to `root` (the tab body / panel), not the + // out-of-scope `panel` the pre-refactor #759 wiring referenced. + root.querySelector('[data-mr-identify]')?.addEventListener('click', () => runIdentify(root, song)); } // ── Tabbed single-song popup (slice 4) ───────────────────────────────────