got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-11 11:19:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(drum_highway_3d): enlarge note gems ~20% for readability (#713)

Browse Source 
Disc radius 3.6->4.3, cymbal 3.0->3.6 (heights proportional) — hands-on
feedback said the gems were hard to read at the default camera. All
variant shapes key off these radii; accents still fit the lane gap.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Byron Gamatos
2026-07-02 09:22:02 +02:00
committed by GitHub
co-authored by Claude Fable 5
parent 3e2703d8e1
commit 9b4bef3fd1
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/drum_highway_3d/screen.js
+9 -4
View File
@@ -83,10 +83,15 @@
// Note dimensions (world units). All keyed to K so scale changes // Note dimensions (world units). All keyed to K so scale changes
// propagate. // propagate.
const DISC_R_BASE = 3.6 * K; // drum disc radius // Bumped ~20% (3.6/3.0 → 4.3/3.6) after hands-on feedback: the gems
const DISC_H = 1.2 * K; // drum disc thickness // were hard to read at the default camera. Accent scale (1.25×) still
const CYMBAL_R = 3.0 * K; // cymbal gem radius // fits the 12*K lane gap: 4.3*2*1.25 = 10.75. Every dependent shape
const CYMBAL_H = 1.6 * K; // cymbal gem height // (halo/ghost/open rings, snare stripe, bell dot, flam grace) keys off
// these radii, so the whole family scales together.
const DISC_R_BASE = 4.3 * K; // drum disc radius
const DISC_H = 1.4 * K; // drum disc thickness
const CYMBAL_R = 3.6 * K; // cymbal gem radius
const CYMBAL_H = 1.9 * K; // cymbal gem height
// ─── Piece vocabulary (mirrors lib/drums.py PIECES) ────────────── // ─── Piece vocabulary (mirrors lib/drums.py PIECES) ──────────────
// Used for kit configuration: user picks which of these pieces they // Used for kit configuration: user picks which of these pieces they