From 9b4bef3fd1c4f8a230c0ad46549afdabc435388e Mon Sep 17 00:00:00 2001 From: Byron Gamatos Date: Thu, 2 Jul 2026 09:22:02 +0200 Subject: [PATCH] fix(drum_highway_3d): enlarge note gems ~20% for readability (#713) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Disc radius 3.6->4.3, cymbal 3.0->3.6 (heights proportional) — hands-on feedback said the gems were hard to read at the default camera. All variant shapes key off these radii; accents still fit the lane gap. Co-authored-by: Claude Fable 5 --- plugins/drum_highway_3d/screen.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/plugins/drum_highway_3d/screen.js b/plugins/drum_highway_3d/screen.js index 11e1107..89eaa70 100644 --- a/plugins/drum_highway_3d/screen.js +++ b/plugins/drum_highway_3d/screen.js @@ -83,10 +83,15 @@ // Note dimensions (world units). All keyed to K so scale changes // propagate. - const DISC_R_BASE = 3.6 * K; // drum disc radius - const DISC_H = 1.2 * K; // drum disc thickness - const CYMBAL_R = 3.0 * K; // cymbal gem radius - const CYMBAL_H = 1.6 * K; // cymbal gem height + // Bumped ~20% (3.6/3.0 → 4.3/3.6) after hands-on feedback: the gems + // were hard to read at the default camera. Accent scale (1.25×) still + // fits the 12*K lane gap: 4.3*2*1.25 = 10.75. Every dependent shape + // (halo/ghost/open rings, snare stripe, bell dot, flam grace) keys off + // these radii, so the whole family scales together. + const DISC_R_BASE = 4.3 * K; // drum disc radius + const DISC_H = 1.4 * K; // drum disc thickness + const CYMBAL_R = 3.6 * K; // cymbal gem radius + const CYMBAL_H = 1.9 * K; // cymbal gem height // ─── Piece vocabulary (mirrors lib/drums.py PIECES) ────────────── // Used for kit configuration: user picks which of these pieces they