mirror of
https://github.com/got-feedBack/feedBack-desktop.git
synced 2026-09-11 01:44:11 +00:00
refactor(audio): extract EngineState with intent/state split (phase 1)
Moves the shared run-state atomics (currentSampleRate, block sizes, duplexMode, run flags) into slopsmith::EngineState (src/audio/engine/) so later extracted units take EngineState& and stay unit-testable without JUCE devices. AudioEngine binds the members back by reference under their historical names — zero call-site churn, behavior-identical. The old audioRunning conflated user intent with device state (deep-read §3/§6); it is now state.deviceRunning (same semantics, isAudioRunning compat pinned) plus a new state.userWantsAudio written only by startAudio/stopAudio. Nothing reads the intent flag yet — phase 8 flips setAudioDevices' restart decision onto it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
eeb83cbdbc
commit
eb40b87dea
@@ -12,3 +12,7 @@ target_compile_features(packed_stereo_ring_test PRIVATE cxx_std_20)
|
||||
find_package(Threads REQUIRED)
|
||||
target_link_libraries(packed_stereo_ring_test PRIVATE Threads::Threads)
|
||||
add_test(NAME packed_stereo_ring COMMAND packed_stereo_ring_test)
|
||||
|
||||
add_executable(engine_state_test engine_state_test.cpp)
|
||||
target_compile_features(engine_state_test PRIVATE cxx_std_17)
|
||||
add_test(NAME engine_state COMMAND engine_state_test)
|
||||
|
||||
@@ -0,0 +1,53 @@
|
||||
// Phase 1 unit test for EngineState (docs/audio-engine-tlc.md §5): the
|
||||
// intent/state transition table. Mirrors how AudioEngine drives the two
|
||||
// flags — startAudio/stopAudio write BOTH (intent + state), the device
|
||||
// callbacks write deviceRunning ONLY — and pins the Phase 0.b compat
|
||||
// decision that isAudioRunning() reports DEVICE STATE: a transient device
|
||||
// stop flips it false even though the user never pressed Stop.
|
||||
|
||||
#include "../../src/audio/engine/EngineState.h"
|
||||
|
||||
#include <cassert>
|
||||
#include <cstdio>
|
||||
|
||||
using slopsmith::EngineState;
|
||||
|
||||
// The write sets, as AudioEngine performs them.
|
||||
static void userStart(EngineState& s) { s.userWantsAudio.store(true); s.deviceRunning.store(true); }
|
||||
static void userStop(EngineState& s) { s.userWantsAudio.store(false); s.deviceRunning.store(false); }
|
||||
static void deviceAboutToStart(EngineState& s) { s.deviceRunning.store(true); }
|
||||
static void deviceStopped(EngineState& s) { s.deviceRunning.store(false); }
|
||||
// isAudioRunning() facade == deviceRunning (compat pin).
|
||||
static bool isAudioRunning(const EngineState& s) { return s.deviceRunning.load(); }
|
||||
|
||||
int main()
|
||||
{
|
||||
EngineState s;
|
||||
assert(!s.userWantsAudio.load() && !isAudioRunning(s));
|
||||
|
||||
// User starts audio.
|
||||
userStart(s);
|
||||
assert(s.userWantsAudio.load() && isAudioRunning(s));
|
||||
|
||||
// Transient device stop (WASAPI exclusive mid-start hiccup): device state
|
||||
// drops, intent survives — this is the split that fixes deep-read §3.
|
||||
deviceStopped(s);
|
||||
assert(s.userWantsAudio.load() && "transient stop must not erase user intent");
|
||||
assert(!isAudioRunning(s) && "compat pin: isAudioRunning reports device state");
|
||||
|
||||
// JUCE auto-restart brings the device back without user action.
|
||||
deviceAboutToStart(s);
|
||||
assert(s.userWantsAudio.load() && isAudioRunning(s));
|
||||
|
||||
// Explicit user stop clears both.
|
||||
userStop(s);
|
||||
assert(!s.userWantsAudio.load() && !isAudioRunning(s));
|
||||
|
||||
// A stray device start (auto-restart after user stop) must not fabricate
|
||||
// intent: device state true, intent still false.
|
||||
deviceAboutToStart(s);
|
||||
assert(!s.userWantsAudio.load() && isAudioRunning(s));
|
||||
|
||||
std::puts("engine_state: all transitions passed");
|
||||
return 0;
|
||||
}
|
||||
Reference in New Issue
Block a user