got-feedBack/feedBack-desktop
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack-desktop.git synced 2026-08-17 14:08:21 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(nightly): ship a single portable zip on Windows

Browse Source 
vpk pack emitted a Portable.zip (Update.exe stub wrapping win-unpacked)
alongside the plain feedback-windows-x64.zip, so testers saw two
different portable downloads. Pass --noPortable to suppress it and add
artifacts/**/*.zip to the publish globs so the plain zip (and the macOS
tester zip) land on the rolling nightly release instead of only in
workflow artifacts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
OmikronApex
2026-07-12 22:51:35 +02:00
co-authored by Claude Fable 5
parent ce242a6bcf
commit 970bd5068e
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/nightly.yml
+5
View File
@@ -200,6 +200,9 @@ jobs:
# Windows: pack the electron-builder unpacked dir into Velopack release # Windows: pack the electron-builder unpacked dir into Velopack release
# assets (per-machine MSI, *-full.nupkg, *-delta.nupkg, # assets (per-machine MSI, *-full.nupkg, *-delta.nupkg,
# releases.win-x64-nightly.json). Unsigned (same as build.yml's win pack). # releases.win-x64-nightly.json). Unsigned (same as build.yml's win pack).
# --noPortable: vpk's Portable.zip (Update.exe stub wrapping the app) is
# suppressed — the plain feedback-windows-x64.zip above is the one
# portable tester download.
# See build.yml's "Velopack pack (Windows)" for the --msi / Setup.exe # See build.yml's "Velopack pack (Windows)" for the --msi / Setup.exe
# policy rationale — this is a channel-swapped copy of it. # policy rationale — this is a channel-swapped copy of it.
- name: Velopack pack (Windows) - name: Velopack pack (Windows)
@@ -220,6 +223,7 @@ jobs:
--channel "win-x64-nightly" \ --channel "win-x64-nightly" \
--packDir release/win-unpacked \ --packDir release/win-unpacked \
--mainExe "$mainexe" \ --mainExe "$mainexe" \
--noPortable \
--msi \ --msi \
--instLocation PerMachine \ --instLocation PerMachine \
-o release/velopack -o release/velopack
@@ -364,6 +368,7 @@ jobs:
artifacts/**/velopack/**/* artifacts/**/velopack/**/*
artifacts/**/*.AppImage artifacts/**/*.AppImage
artifacts/**/*.deb artifacts/**/*.deb
artifacts/**/*.zip
) )
# Filter to real files (globs that matched nothing expand to nothing # Filter to real files (globs that matched nothing expand to nothing
# under nullglob, but guard against directories sneaking in). # under nullglob, but guard against directories sneaking in).