From 970bd5068e1e0f0b89efcb18a0e3035db156c897 Mon Sep 17 00:00:00 2001 From: OmikronApex Date: Sun, 12 Jul 2026 22:51:35 +0200 Subject: [PATCH] fix(nightly): ship a single portable zip on Windows vpk pack emitted a Portable.zip (Update.exe stub wrapping win-unpacked) alongside the plain feedback-windows-x64.zip, so testers saw two different portable downloads. Pass --noPortable to suppress it and add artifacts/**/*.zip to the publish globs so the plain zip (and the macOS tester zip) land on the rolling nightly release instead of only in workflow artifacts. Co-Authored-By: Claude Fable 5 --- .github/workflows/nightly.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 561ccf5..98e2701 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -200,6 +200,9 @@ jobs: # Windows: pack the electron-builder unpacked dir into Velopack release # assets (per-machine MSI, *-full.nupkg, *-delta.nupkg, # releases.win-x64-nightly.json). Unsigned (same as build.yml's win pack). + # --noPortable: vpk's Portable.zip (Update.exe stub wrapping the app) is + # suppressed — the plain feedback-windows-x64.zip above is the one + # portable tester download. # See build.yml's "Velopack pack (Windows)" for the --msi / Setup.exe # policy rationale — this is a channel-swapped copy of it. - name: Velopack pack (Windows) @@ -220,6 +223,7 @@ jobs: --channel "win-x64-nightly" \ --packDir release/win-unpacked \ --mainExe "$mainexe" \ + --noPortable \ --msi \ --instLocation PerMachine \ -o release/velopack @@ -364,6 +368,7 @@ jobs: artifacts/**/velopack/**/* artifacts/**/*.AppImage artifacts/**/*.deb + artifacts/**/*.zip ) # Filter to real files (globs that matched nothing expand to nothing # under nullglob, but guard against directories sneaking in).