got-feedBack/feedBack-desktop
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack-desktop.git synced 2026-08-17 22:12:30 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(ci): rename entitlements file — vpk requires .entitlements extension

Browse Source 
Nightly run 29093119570 failed:
  --signEntitlements does not have an .entitlements extension
vpk validates the file extension. Rename
resources/entitlements.mac.plist -> entitlements.mac.entitlements
and update all references (electron-builder config, sign-macos-binaries.sh,
both workflows). Content unchanged; codesign/electron-builder accept any
extension.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
OmikronApex
2026-07-10 15:04:31 +02:00
co-authored by Claude Fable 5
parent 1046b71f34
commit 83b8b66fe7
5 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/build.yml
+1 -1
View File
@@ -449,7 +449,7 @@ jobs:
--mainExe "$mainexe" \ --mainExe "$mainexe" \
-o release/velopack \ -o release/velopack \
--signAppIdentity "$APPLE_SIGNING_IDENTITY" \ --signAppIdentity "$APPLE_SIGNING_IDENTITY" \
--signEntitlements "$PWD/resources/entitlements.mac.plist" \ --signEntitlements "$PWD/resources/entitlements.mac.entitlements" \
--notaryProfile "velopack-notary" --notaryProfile "velopack-notary"
fi fi
.github/workflows/nightly.yml
+1 -1
View File
@@ -304,7 +304,7 @@ jobs:
--mainExe "$mainexe" \ --mainExe "$mainexe" \
-o release/velopack \ -o release/velopack \
--signAppIdentity "$APPLE_SIGNING_IDENTITY" \ --signAppIdentity "$APPLE_SIGNING_IDENTITY" \
--signEntitlements "$PWD/resources/entitlements.mac.plist" \ --signEntitlements "$PWD/resources/entitlements.mac.entitlements" \
--notaryProfile "velopack-notary" --notaryProfile "velopack-notary"
fi fi
package.json
+2 -2
View File
@@ -111,8 +111,8 @@
"icon": "resources/icons/icon.icns", "icon": "resources/icons/icon.icns",
"hardenedRuntime": true, "hardenedRuntime": true,
"gatekeeperAssess": false, "gatekeeperAssess": false,
"entitlements": "resources/entitlements.mac.plist", "entitlements": "resources/entitlements.mac.entitlements",
"entitlementsInherit": "resources/entitlements.mac.plist", "entitlementsInherit": "resources/entitlements.mac.entitlements",
"notarize": true, "notarize": true,
"extendInfo": { "extendInfo": {
"NSMicrophoneUsageDescription": "fee[dB]ack needs microphone access for guitar input and note detection." "NSMicrophoneUsageDescription": "fee[dB]ack needs microphone access for guitar input and note detection."
resources/entitlements.mac.plist → resources/entitlements.mac.entitlements
View File
scripts/sign-macos-binaries.sh
+1 -1
View File
@@ -29,7 +29,7 @@ fi
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
PROJECT_DIR="$(dirname "$SCRIPT_DIR")" PROJECT_DIR="$(dirname "$SCRIPT_DIR")"
ENTITLEMENTS="$PROJECT_DIR/resources/entitlements.mac.plist" ENTITLEMENTS="$PROJECT_DIR/resources/entitlements.mac.entitlements"
if [[ ! -f "$ENTITLEMENTS" ]]; then if [[ ! -f "$ENTITLEMENTS" ]]; then
echo "[sign-macos] entitlements file missing: $ENTITLEMENTS" >&2 echo "[sign-macos] entitlements file missing: $ENTITLEMENTS" >&2