From 83b8b66fe7b9db206c1d0e0278bf4c183dd9c7f9 Mon Sep 17 00:00:00 2001 From: OmikronApex Date: Fri, 10 Jul 2026 15:04:31 +0200 Subject: [PATCH] =?UTF-8?q?fix(ci):=20rename=20entitlements=20file=20?= =?UTF-8?q?=E2=80=94=20vpk=20requires=20.entitlements=20extension?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Nightly run 29093119570 failed: --signEntitlements does not have an .entitlements extension vpk validates the file extension. Rename resources/entitlements.mac.plist -> entitlements.mac.entitlements and update all references (electron-builder config, sign-macos-binaries.sh, both workflows). Content unchanged; codesign/electron-builder accept any extension. Co-Authored-By: Claude Fable 5 --- .github/workflows/build.yml | 2 +- .github/workflows/nightly.yml | 2 +- package.json | 4 ++-- .../{entitlements.mac.plist => entitlements.mac.entitlements} | 0 scripts/sign-macos-binaries.sh | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) rename resources/{entitlements.mac.plist => entitlements.mac.entitlements} (100%) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 588bfbe..597a05d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -449,7 +449,7 @@ jobs: --mainExe "$mainexe" \ -o release/velopack \ --signAppIdentity "$APPLE_SIGNING_IDENTITY" \ - --signEntitlements "$PWD/resources/entitlements.mac.plist" \ + --signEntitlements "$PWD/resources/entitlements.mac.entitlements" \ --notaryProfile "velopack-notary" fi diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 999243b..561ccf5 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -304,7 +304,7 @@ jobs: --mainExe "$mainexe" \ -o release/velopack \ --signAppIdentity "$APPLE_SIGNING_IDENTITY" \ - --signEntitlements "$PWD/resources/entitlements.mac.plist" \ + --signEntitlements "$PWD/resources/entitlements.mac.entitlements" \ --notaryProfile "velopack-notary" fi diff --git a/package.json b/package.json index c60a750..83bac93 100644 --- a/package.json +++ b/package.json @@ -111,8 +111,8 @@ "icon": "resources/icons/icon.icns", "hardenedRuntime": true, "gatekeeperAssess": false, - "entitlements": "resources/entitlements.mac.plist", - "entitlementsInherit": "resources/entitlements.mac.plist", + "entitlements": "resources/entitlements.mac.entitlements", + "entitlementsInherit": "resources/entitlements.mac.entitlements", "notarize": true, "extendInfo": { "NSMicrophoneUsageDescription": "fee[dB]ack needs microphone access for guitar input and note detection." diff --git a/resources/entitlements.mac.plist b/resources/entitlements.mac.entitlements similarity index 100% rename from resources/entitlements.mac.plist rename to resources/entitlements.mac.entitlements diff --git a/scripts/sign-macos-binaries.sh b/scripts/sign-macos-binaries.sh index f8a368e..b537ef1 100755 --- a/scripts/sign-macos-binaries.sh +++ b/scripts/sign-macos-binaries.sh @@ -29,7 +29,7 @@ fi SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" PROJECT_DIR="$(dirname "$SCRIPT_DIR")" -ENTITLEMENTS="$PROJECT_DIR/resources/entitlements.mac.plist" +ENTITLEMENTS="$PROJECT_DIR/resources/entitlements.mac.entitlements" if [[ ! -f "$ENTITLEMENTS" ]]; then echo "[sign-macos] entitlements file missing: $ENTITLEMENTS" >&2