got-feedBack/feedBack-desktop
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack-desktop.git synced 2026-09-10 23:04:09 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

feat(panes): a pane window can never go behind the app

Browse Source 
A pane is a control surface for the thing you are looking at. Clicking the
highway to play — the single most common thing anyone does here — raises the
main window, and a plain sibling window slides straight behind it. You would
fish the mixer back out from behind the game every time you touched the game.
That is not a pop-out, it is a hiding place.

Parent each pane window to the main window. That is the precise amount of "in
front": the pane always floats above fee[dB]ack, and behaves like any other
window against everything else.

Deliberately NOT setAlwaysOnTop. That would put a pane above the user's browser
and editor too — a surprising thing to inflict on someone for opening a mixer.
alwaysOnTop still composes on top of this for a pane the user explicitly wants
above everything.

The trade, accepted: the OS ties parent and child together, so minimizing
fee[dB]ack hides its panes and restoring brings them back. That is what a
companion window should do.

Failure is non-fatal — a pane that can be buried is still a working pane.

Signed-off-by: topkoa <topkoa@gmail.com>
This commit is contained in:
topkoa
2026-07-12 22:32:30 -04:00
parent 1133205e87
commit 0878ae2682
1 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/pane-hosts.ts
+26
View File
@@ -170,6 +170,32 @@ export function adoptPaneWindow(win: BrowserWindow, paneId: string): void {
win.setMinimumSize(PANE_SIZING.minWidth, PANE_SIZING.minHeight);
if (saved.alwaysOnTop === true) win.setAlwaysOnTop(true);
// A PANE CAN NEVER GO BEHIND THE APP.
//
// A pane is a control surface for the thing you are looking at. Clicking the
// highway to play — the single most common thing anyone does here — raises the
// main window, and a plain sibling window would slide straight behind it. You
// would have to fish the mixer back out from behind the game every time you
// touched the game. That is not a pop-out, it is a hiding place.
//
// Parenting to the main window (rather than setAlwaysOnTop) is the precise
// amount of "in front": the pane always floats above fee[dB]ack, and behaves
// like any other window against everything else. Always-on-top would put it
// above the user's browser and editor too — a surprising thing to inflict on
// someone for opening a mixer.
//
// alwaysOnTop remains available on top of this for a pane the user explicitly
// wants above EVERYTHING; the two compose.
const main = getMainWindow();
if (main && !main.isDestroyed()) {
try {
win.setParentWindow(main);
} catch (err) {
// Not fatal: a pane that can be buried is still a working pane.
console.warn(`[panes] could not parent ${paneId} to the main window:`, err);
}
}
// A pane is a companion to the app, not an entry to it: keep it off the taskbar
// so it never masquerades as a second fee[dB]ack.
win.setSkipTaskbar(true);