H3cJP/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-03-18 19:32:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

FifoPlayer: Fix hang when taking screenshot during FIFO log playback

Browse Source 
Don't copy null terminators from the log's `header.gameid` into
`FifoDataFile`'s `m_game_id`.

Doing so would cause an infinite loop in `Core::GenerateScreenshotName`
as the various concatenations and `fmt::format` calls would then
effectively drop all the timestamps and disambiguating arbitrary numbers
since they followed the null terminator in the gameid, and so the
`File::Exists` calls would always return true.

Fixes https://bugs.dolphin-emu.org/issues/14002.
This commit is contained in:
Dentomologist 2026-03-16 00:49:38 -07:00 committed by OatmealDome
parent c9ea4e3b8e
commit 5c9e4f8e47
No known key found for this signature in database
GPG Key ID: A4BFAB0C67513B91
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/Core/FifoPlayer/FifoDataFile.cpp
View File

@ -274,7 +274,8 @@ std::unique_ptr<FifoDataFile> FifoDataFile::Load(const std::string& filename, bo
}
else
{
dataFile->m_game_id = std::string{header.gameid, DEFAULT_GAME_ID.size()};
const size_t gameid_length = strnlen(header.gameid, DEFAULT_GAME_ID.size());
dataFile->m_game_id = std::string{header.gameid, gameid_length};
}
if (flagsOnly)