H3cJP/citra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
26,080 Commits 7 Branches 3 Tags
698c854d5bcd5c021e94dea9bea44e6b07e1c53d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Sebastian ValleandGitHub 9ef45f00bf GPU/MMEInterpreter: Ignore the 'exit' flag when it's executed inside a delay slot. 
It seems instructions marked with the 'exit' flag will not cause an exit when executed within a delay slot.

This was hwtested by fincs.
 2019-05-12 16:38:51 -05:00
Sebastian ValleandGitHub e5dfbe22ee Merge pull request #1956 from lioncash/process-thread 
kernel/process: Start the main thread using the specified ideal core
 2018-12-30 20:32:41 -05:00
Subv c4c19fa6c1 Removed unused file. 
This is a leftover from #1792
 2018-12-03 23:52:38 -05:00
Subv b873253da1 GPU: Don't try to route PFIFO methods (0-0x40) to the other engines. 2018-12-03 23:52:18 -05:00
Sebastian ValleandGitHub 1ad158b2bb Merge pull request #1843 from lioncash/table 
hle/service: Update function tables for erpt:c and usb's IClientEpSession
 2018-12-03 12:21:28 -05:00
Subv 583bd20f02 Services/VI: Dereferencing an uninitialized std::optional is undefined behavior. 
Assert that it is not empty before using it in the DequeueBuffer wait callback.
 2018-11-30 16:06:49 -05:00
Subv 8ba21e28cf Logging: Change the TimeStretch::Process log from debug to trace level. 
This function is called too many times and makes the debug logging basically unusable due to the spam.
 2018-09-20 22:33:54 -05:00
Subv 9cd5c61fcf RasterizerGL: Use the correct framebuffer when clearing via the CLEAR_BUFFERS register. 
Previously we were clearing the default backbuffer framebuffer.

Found thanks to a Piglit test :)
 2018-09-20 22:31:53 -05:00
Subv c878a819d7 Shaders: Implemented multiple-word loads and stores to and from attribute memory. 
This seems to be an optimization performed by nouveau.
 2018-09-15 11:21:21 -05:00
Subv bb5eb4f20a GPU: Basic implementation of the Kepler Inline Memory engine (p2mf). 
This engine writes data from a FIFO register into the configured address.
 2018-09-12 13:57:08 -05:00
Subv fdb199290b GPU/DMA: Partially implemented the 'enable_2d' bit in the DMA engine. 
When not set, this tells the GPU to only use the X size when performing a DMA copy.
This is only implemented for linear->linear and tiled->tiled copies. Conversion copies still retain the assert.

This bit is unset by some games for various purposes, and by nouveau when copying the vertex buffers.
 2018-09-08 16:02:16 -05:00
Sebastian ValleandGitHub f170159fde Merge pull request #1166 from lioncash/typo 
filesystem: Fix typo in log message
 2018-08-25 07:19:46 -05:00
Subv e3bddf8137 Shaders: Implement depth writing in fragment shaders. 
We'll write <last color output reg + 2> to gl_FragDepth.
 2018-08-20 21:57:56 -05:00
Subv eac3cf301c Shaders: Fixed the coords in TEX with Texture2D. 
The X and Y coordinates should be in gpr8 and gpr8+1, respectively.

This fixes the cutscene rendering in Sonic Mania.
 2018-08-20 20:45:46 -05:00
Subv fc5b489b0f Shaders: Log and crash when using an unimplemented texture type in a texture sampling instruction. 2018-08-20 20:44:56 -05:00
Subv 2b9eee4d1e GPU: Implemented the logic op functionality of the GPU. 
This will ASSERT if blending is enabled at the same time as logic ops.
 2018-08-20 18:44:47 -05:00
Subv f24ab6d9e6 GLState: Allow enabling/disabling GL_COLOR_LOGIC_OP independently from blending. 2018-08-20 18:43:11 -05:00
Subv 6bcdf37d4f GPU: Added registers for the logicop functionality. 2018-08-20 18:42:36 -05:00
Subv 7784ce1854 Shaders: Write all the enabled color outputs when a fragment shader exits. 
We were only writing to the first render target before.
Note that this is only the GLSL side of the implementation, supporting multiple render targets requires more changes in the OpenGL renderer.

Dual Source blending is not implemented and stuff that uses it might not work at all.
 2018-08-20 17:31:25 -05:00
Subv d7c68fbb12 Rasterizer: Reinterpret the raw texture bytes instead of blitting (and thus doing format conversion) to a new texture when a game requests an old texture address with a different format. 2018-08-20 15:20:35 -05:00
Subv 3fe77be392 Rasterizer: Don't attempt to copy over the old texture's data when doing a format reinterpretation if we're only going to clear the framebuffer. 2018-08-20 15:20:35 -05:00
Subv 6cf719a4ab Shaders/TEXS: Fixed the component mask in the TEXS instruction. 
Previously we could end up with a TEXS that didn't write any outputs, this was wrong.
 2018-08-19 17:09:40 -05:00
Subv f7edbcd7a3 Shaders/TEXS: Fixed the component mask in the TEXS instruction. 
Previously we could end up with a TEXS that didn't write any outputs, this was wrong.
 2018-08-19 14:00:12 -05:00
Subv 7fb406c3fc Shader: Implemented the TLD4 and TLD4S opcodes using GLSL's textureGather. 
It is unknown how TLD4S determines the sampler type, more research is needed.
 2018-08-19 12:57:58 -05:00
Subv 3ef4b3d4b4 Shader: Use the right sampler type in the TEX, TEXS and TLDS instructions. 
Different sampler types have their parameters in different registers.
 2018-08-19 12:57:54 -05:00
Subv 73b937b190 Shader: Added bitfields for the texture type of the various sampling instructions. 2018-08-19 12:57:51 -05:00
Subv 656758fd81 Shaders: Added decodings for TLD4 and TLD4S 2018-08-19 12:57:08 -05:00
Subv 1b92ae136f Shaders: Added decodings for the LDG and STG instructions. 2018-08-19 00:46:34 -05:00
Subv 731701a2d2 Shaders: Implemented the gl_FrontFacing input attribute (attr 63). 2018-08-19 00:14:34 -05:00
Subv 9b1c49a9cf Shader: Remove an unneeded assert, the negate bit is implemented for conversion instructions. 2018-08-18 14:48:05 -05:00
Subv e0f66c1fbf GLRasterizer: Implemented instanced vertex arrays. 
Before each draw call, for every enabled vertex array configured as instanced, we take the current instance id and divide it by its configured divisor, then we multiply that by the corresponding stride and increment the start address by the resulting amount. This way we can simulate the vertex array being incremented once per instance without actually using OpenGL's instancing functions.
 2018-08-18 14:42:26 -05:00
Subv 8335b2f115 Shader: Implemented the predicate and mode arguments of LOP. 
The mode can be used to set the predicate to true depending on the result of the logic operation. In some cases, this means discarding the result (writing it to register 0xFF (Zero)).

This is used by Super Mario Odyssey.
 2018-08-18 14:36:37 -05:00
Subv ff358d97e8 Shaders: Implemented a stack for the SSY/SYNC instructions. 
The SSY instruction pushes an address into the stack, and the SYNC instruction pops it. The current stack depth is 20, we should figure out if this is enough or not.
 2018-08-18 10:48:12 -05:00
Subv 2e95ba2e9c Shaders: Corrected the 'abs' and 'neg' bit usage in the float arithmetic instructions. 
We should definitely audit our shader generator for more errors like this.
 2018-08-18 10:22:42 -05:00
Subv 91140f6c0a Shader/Conversion: Implemented the negate bit in F2F and I2I instructions. 2018-08-15 09:27:43 -05:00
Subv 38592a3b5e Shader/I2F: Implemented the negate I2F_C instruction variant. 2018-08-15 09:25:02 -05:00
Subv 40ecdda19e Shader/F2I: Implemented the negate bit in the I2F instruction 2018-08-15 09:18:55 -05:00
Subv 5ef447cc0e Shader/F2I: Implemented the F2I_C instruction variant. 2018-08-15 09:16:35 -05:00
Subv 11c221cc62 Shader/F2I: Implemented the negate bit in the F2I instruction. 2018-08-15 09:15:55 -05:00
Subv c5284efd4f Rasterizer: Implemented instanced rendering. 
We keep track of the current instance and update an uniform in the shaders to let them know which instance they are.

Instanced vertex arrays are not yet implemented.
 2018-08-14 22:25:07 -05:00
Subv d923766042 CPU/Timing: Use an approximated amortized amount of ticks when advancing timing. 
We divide the number of ticks to add by the number of cores (4) to obtain a more or less rough estimate of the actual number of ticks added. This assumes that all 4 cores are doing similar work. Previously we were adding ~4 times the number of ticks, thus making the games think that time was going way too fast.

This lets us bypass certain hangs in some games like Breath of the Wild.

We should modify our CoreTiming to support multiple cores (both running in a single thread, and in multiple host threads).
 2018-08-12 20:41:28 -05:00
Subv a9877c8f65 Kernel/SVC: Don't reschedule the current core when creating a new thread. 
The current core may have nothing to do with the core where the new thread was scheduled to run. In case it's the same core, then the following PrepareReshedule call will take care of that.
 2018-08-12 20:38:37 -05:00
Subv 2e7802ad7d Core/HLE: Make the 'reschedule_pending' flag atomic. 
Another thread may write to this variable while the core in question is in the middle of checking for a reschedule request.
 2018-08-12 18:41:12 -05:00
Subv 3a338d9286 CPU/HLE: Lock the HLE mutex before performing a reschedule. 
Another thread might be in the middle of an SVC, thus altering the state of the schedulers.
 2018-08-12 18:41:11 -05:00
Subv 84b542c386 Kernel/Threads: Lock the HLE mutex when executing the wakeup callback. 
Another thread might be in the middle of a reschedule, thus altering the state of the schedulers.
 2018-08-12 18:41:11 -05:00
Subv 0135b328ed Kernel/Thread: Always use the threadsafe option when scheduling wakeups. 
WakeAfterDelay might be called from any host thread, so err on the side of caution and use the thread-safe CoreTiming::ScheduleEventThreadsafe.

Note that CoreTiming is still far from thread-safe, there may be more things we have to work on for it to be up to par with what we want.
 2018-08-12 18:40:56 -05:00
Subv 5224cc49c4 Kernel/Mutex: Don't duplicate threads in the mutex waiter list. 
Exit from AddMutexWaiter early if the thread is already waiting for a mutex owned by the owner thread.

This accounts for the possibility of a thread that is waiting on a condition variable being awakened twice in a row.

Also added more validation asserts.

This should fix one of the random crashes in Breath Of The Wild.
 2018-08-12 16:35:27 -05:00
Subv 969326bd58 GPU/Maxwell3D: Implemented an alternative set of blend factors. 
These are used by nouveau and some games like SMO.
 2018-08-11 20:57:16 -05:00
Subv 2dad1204e8 RasterizerGL: Ignore invalid/unset vertex attributes. 
This should make the es2gears example not crash anymore.
 2018-08-11 20:36:40 -05:00
Subv c1ad973881 GPU/Shader: Don't predicate instructions that don't have a predicate field (SSY). 2018-08-11 16:00:14 -05:00
Subv 305a05f820 GPU/Shaders: Implemented SSY and SYNC as a way to modify control flow during shader execution. 
SSY sets the target label to jump to when the SYNC instruction is executed.
 2018-08-11 15:55:11 -05:00
Subv 8191273a3d MacroInterpreter: Avoid left shifting negative values. 
The branch target is signed, so multiply by 4 instead of left shifting by 2
 2018-07-30 20:38:24 -05:00
Subv e119e17d18 nvhost_gpu: Added checks to ensure we don't read past the end of the entries when handling a GPU command list. 2018-07-30 20:09:13 -05:00
Subv 2482aca7c3 nvhost_ctrl_gpu: Only read the input parameters if they are actually there. 
Passing nullptr to memcpy is undefined behavior.
 2018-07-30 20:08:36 -05:00
Subv f85cff0f48 GPU: Allow using R16F as a render target format. 2018-07-26 08:52:21 -05:00
Sebastian ValleandGitHub 1958d07d7d Merge pull request #828 from lioncash/ldr 
service: Add ldr services
 2018-07-25 23:44:13 -05:00
Sebastian ValleandGitHub 8ac52c6b56 Merge pull request #826 from lioncash/erpt 
service: Add erpt and eupld services
 2018-07-25 23:43:47 -05:00
Sebastian ValleandGitHub 0e05f98be2 Merge pull request #823 from lioncash/nifm 
service/nifm: Deduplicate interface code
 2018-07-25 23:43:03 -05:00
Subv c5b838aeef GPU: Use the right texture format for sRGBA framebuffers. 2018-07-25 09:52:39 -05:00
Subv ee8123bf13 GPU: Allow the use of Z24S8 as a texture format. 2018-07-25 09:41:24 -05:00
Subv daf2504d31 GPU: Implemented the Z32_S8_X24 depth buffer format. 2018-07-24 20:41:40 -05:00
Subv f747a7e35d GPU: Allow using Z32 as a texture format. 2018-07-24 19:54:23 -05:00
Subv 4f574201ea GPU: Allow the usage of R8 as a render target format. 2018-07-24 19:49:36 -05:00
Subv 8f2c4191ab GPU: Remove the assert that required the CODE_ADDRESS to be 0. 
Games usually just leave it at 0 but nouveau sets it to something else. This already works fine, the assert is useless.
 2018-07-24 13:54:12 -05:00
Subv 4cc1e180ec GPU: Implemented the R16 and R16F texture formats. 2018-07-24 13:39:16 -05:00
Subv ccc42702b5 GPU: Implement texture format R32F. 2018-07-23 22:21:31 -05:00
Subv 7841447cf0 Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel. 2018-07-22 12:27:24 -05:00
Subv ba2fb83d60 Frontend: Check for more required OpenGL extensions during startup. 2018-07-22 12:05:38 -05:00
Sebastian ValleandGitHub 3e2b32a3ee Merge pull request #772 from MerryMage/dynarmic 
externals: Update dynarmic to fc6b73bd
 2018-07-22 11:45:47 -05:00
Subv 5c49e56d41 GPU: Implement the NVGPU_IOCTL_CHANNEL_KICKOFF_PB ioctl2 command. 
This behaves quite similarly to the SubmitGPFIFO command. Referenced from Ryujinx.
Many thanks to @gdkchan for investigating this!
 2018-07-21 15:50:02 -05:00
Subv 966874e357 Loader: Only print the module names and addresses if they actually exist. 2018-07-20 19:59:15 -05:00
Subv d84eb9dac6 CPU: Save and restore the TPIDR_EL0 system register on every context switch. 
Note that there's currently a dynarmic bug preventing this register from being written.
 2018-07-20 19:57:45 -05:00
Subv 9c7321fe6d HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error. 
And make IManagerForApplication::CheckAvailability always return false.
Returning a bogus id from GetAccountId causes games to crash on boot.
We should investigate this with a hwtest and either stub it properly or implement it.
 2018-07-20 11:02:25 -05:00
Subv 05549e45c5 HLE/ACC: Return an IProfile that is consistent with what was requested. 
The default username for now is "yuzu".
We should eventually allow the creation of users in the emulator and have the ability to modify their parameters.
 2018-07-19 16:53:42 -05:00
Subv 50e2777724 HLE/ACC: Change the default user id to be consistent with what we tell games on startup. 
In IApplicationFunctions::PopLaunchParameter we tell the games that they were launched as user id 1.
 2018-07-19 16:51:55 -05:00
Subv b102815f1f HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers. 
We only emulate a single user id for now.
 2018-07-19 16:19:46 -05:00
Sebastian ValleandGitHub 78dd1cd441 Merge pull request #720 from Subv/getentrytype_root 
Filesystem: Return EntryType::Directory for the root directory.
 2018-07-19 15:23:32 -05:00
Sebastian ValleandGitHub 7eace8f512 Merge pull request #714 from lioncash/index 
hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads
 2018-07-19 14:36:34 -05:00
Subv e5c916a27c Filesystem: Return EntryType::Directory for the root directory. 
It is unknown if this is correct behavior, but it makes sense and fixes a regression with Stardew Valley.
 2018-07-19 13:11:09 -05:00
Subv 3d3b10adc7 GPU: Added register definitions for the stencil parameters. 2018-07-17 15:00:21 -05:00
Subv b07f4d6afb Services/BSD: Corrected the return for StartMonitoring according to SwIPC. 2018-07-14 12:34:07 -05:00
Subv 7e5e4f8d7a FileSys: Append the requested path to the filesystem base path in DeleteFile. 
We were trying to delete things in the current directory instead of the actual filesystem directory. This may fix some savedata issues in some games.
 2018-07-14 10:57:22 -05:00
Subv b37354cca8 GPU: Always enable the depth write when clearing the depth buffer. 
The GPU ignores that register when clearing, but OpenGL obeys the glDepthMask parameter, so we set the depth mask to GL_TRUE when clearing the depth buffer. It will be restored to the correct value automatically on the next draw call.
 2018-07-14 00:52:23 -05:00
Sebastian ValleandGitHub 274d1fb0fc Merge pull request #652 from Subv/fadd32i 
GPU: Implement the FADD32I shader instruction.
 2018-07-12 17:36:51 -05:00
Subv c1ae841f47 GPU: Implement the FADD32I shader instruction. 2018-07-12 12:00:31 -05:00
Subv 0cad310e12 GPU: Corrected the decoding of FFMA for immediate operands. 2018-07-12 10:15:48 -05:00
Subv 4633dd9505 GPU: Implemented the BC7U texture format. 
Note: Our version of glad exports GL_COMPRESSED_RGBA_BPTC_UNORM as GL_COMPRESSED_RGBA_BPTC_UNORM_ARB, maybe it's time we update it.
 2018-07-07 09:17:48 -05:00
Subv 9f6a5660e8 GPU: Allow using the old NV04 values for the depth test function. 
These seem to be just a valid as the GL token values. Thanks @ReinUsesLisp

This restores graphical output to Disgaea 5
 2018-07-05 13:01:31 -05:00
Subv b0c92b80b1 GPU: Implemented the IMNMX shader instruction. 
It's similar to the FMNMX instruction but it works on integers.
 2018-07-04 15:44:37 -05:00
Subv d800a02b4b GPU: Implemented the F2F 'round' rounding mode. 
It's implemented via the GLSL 'roundEven()' function.
 2018-07-04 15:43:21 -05:00
Subv 77cfe4f027 GPU: Stub the shader SYNC and DEPBAR instructions. 
It is unknown at this moment if we actually need to do something with these instructions or if the GLSL compiler takes care of that for us.
 2018-07-04 15:29:51 -05:00
Subv ce39ae3e57 GPU: Implement the Size_16_16 and Size_10_10_10_2 vertex attribute types. 
Both signed and unsigned variants.
 2018-07-04 15:22:34 -05:00
Subv 4bda9693be GPU: Ignore textures that the GLSL compiler deemed unused when binding textures to the shaders. 2018-07-04 15:20:12 -05:00
Subv c42b818cf9 GPU: Corrected the decoding for the TEX shader instruction. 2018-07-04 15:19:20 -05:00
Subv 53a55bd751 GPU: Implemented the PSETP shader instruction. 
It's similar to the isetp and fsetp instructions but it works on predicates instead.
 2018-07-04 15:15:03 -05:00
Subv 016e357c75 GPU: Implemented the 32 bit float depth buffer format. 2018-07-04 10:42:33 -05:00
Subv c1bebdef5e GPU: Flip the triangle front face winding if the GPU is configured to not flip the triangles. 
OpenGL's default behavior is already correct when the GPU is configured to flip the triangles.

This fixes 1-2 Switch's splash screen.
 2018-07-04 10:26:46 -05:00
Subv 5a9df3c675 GPU: Only configure the used framebuffers during clear. 
Don't try to configure the color buffer if it is not being cleared, it may not be completely valid at this point.
 2018-07-03 22:32:59 -05:00
Subv 78443a7f29 GPU: Factor out the framebuffer configuration code for both Clear and Draw commands. 2018-07-03 16:56:47 -05:00
Subv c1811ed3d1 GPU: Support clears that don't clear the color buffer. 2018-07-03 16:56:47 -05:00