H3cJP/citra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

log/backend: Use in-class initializer for FileBackend

Browse Source 
We can also avoid redundant constructions of the same string repeatedly.
This commit is contained in:
Lioncash 2021-04-20 12:57:45 -04:00 committed by GPUCode
parent 399f3d4e32
commit 5c86147ef4
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/common/logging/backend.cpp
View File

@ -145,12 +145,14 @@ void LogcatBackend::Write(const Entry& entry) {
PrintMessageToLogcat(entry);
}
FileBackend::FileBackend(const std::string& filename) : bytes_written(0) {
if (FileUtil::Exists(filename + ".old.txt")) {
FileUtil::Delete(filename + ".old.txt");
FileBackend::FileBackend(const std::string& filename) {
const auto old_filename = filename + ".old.txt";
if (FileUtil::Exists(old_filename)) {
FileUtil::Delete(old_filename);
}
if (FileUtil::Exists(filename)) {
FileUtil::Rename(filename, filename + ".old.txt");
FileUtil::Rename(filename, old_filename);
}
// _SH_DENYWR allows read only access to the file for other programs.

2
src/common/logging/backend.h
View File

@ -109,7 +109,7 @@ public:
private:
FileUtil::IOFile file;
std::size_t bytes_written;
std::size_t bytes_written = 0;
};
/**