mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-09-11 05:04:30 +00:00
byrongamatosandClaude Sonnet 4.6
ffbbf3fb94
Root cause: const sY was declared 371 lines after createScoreFx({..., sY})
inside createFactory(). The shorthand {sY} reads the binding immediately
(not a closure), so every factory call threw ReferenceError: Cannot access
'sY' before initialization. highway.js caught it, reverted to 2D, emitted
viz:reverted. THREE.js was never requested.
Fix: hoist sY declaration to just before createScoreFx. Also hoist
_invertedCached, nStr, curX, and highwayCanvas above their first lexical
reference (all were closure false positives, but hoisting makes the code
unambiguously safe and keeps the new ESLint gate clean with 0 errors).
Hoist _bcPanel in bc-panel.js for the same reason.
Regression gate: eslint no-use-before-define (variables:true, functions:false)
scoped over plugins/highway_3d/ (screen.js + src/). Statically catches any
const/let used before its declaration in the factory — the whole class, not
just this pair. RED at broken tip (sY flagged): GREEN after fix.
Pre-existing violations surfaced (all closure false positives, none true TDZ
runtime bugs): highwayCanvas in _v3TopRightChromeBottom body, _invertedCached
and nStr in sY arrow body and DI getters, curX in getCurX DI getter, _bcPanel
in bc-panel.js function bodies — all resolved by hoisting; no silenced errors.
Bump plugin.json 3.53.0→3.54.0 (viz factory change per standing rule).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW
21 lines
450 B
JSON
21 lines
450 B
JSON
{
|
|
"id": "highway_3d",
|
|
"name": "3D Highway",
|
|
"version": "3.54.0",
|
|
"type": "visualization",
|
|
"scriptType": "module",
|
|
"bundled": true,
|
|
"script": "screen.js",
|
|
"styles": "assets/plugin.css",
|
|
"settings": {
|
|
"html": "settings.html",
|
|
"category": "graphics",
|
|
"server_files": [
|
|
"plugin_uploads/highway_3d/current.mp4",
|
|
"plugin_uploads/highway_3d/current.webm"
|
|
]
|
|
},
|
|
"routes": "routes.py",
|
|
"tour": "tour.json"
|
|
}
|