mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-25 06:11:36 +00:00
e8db65afcb
The 2D highway drew pitched slides (sl) but ignored unpitched slides (slu) — drawNote read only opts.sl. The 3D highway already renders both (slideTrailEnd). drawNote now draws slu as a dashed diagonal with no arrowhead (no definite target pitch), keeping the solid arrow+arrowhead for pitched sl. The two are mutually exclusive in the data. Chord notes flow through the same drawNote, so chord-note unpitched slides are covered too. Also fixes a latent pre-existing bug flagged in review: `opts?.sl || -1` discarded a pitched slide-to-open (sl: 0); now `?? -1` preserves fret-0 targets and keeps pitched precedence. Codex-reviewed: no P1/P2; dash state reset on all paths, no pitched-slide regression. node --check clean. Closes #336. Part of got-feedback/feedback#334. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| assets/venue/themes/small-club | ||
| capabilities | ||
| lottie | ||
| svg | ||
| v3 | ||
| vendor | ||
| _tailwind.src.css | ||
| app.js | ||
| audio-mixer.js | ||
| capabilities.js | ||
| diagnostics.js | ||
| highway.js | ||
| index.html | ||
| lottie-api.js | ||
| style.css | ||
| tailwind.min.css | ||
| tour-engine.css | ||
| tour-engine.js | ||