Files
feedBack/static/v3/venue-scene-3d.js
T
d9fa6d3f55 refactor(highway): make the highway global explicit before the module flip (R3c) (#912)
73 bare `highway.x` references -> `window.highway.x`, across app.js and 10 other files.
Provably a NO-OP today. It is the precondition for flipping highway.js to a module.

━━━ WHY THIS HAS TO LAND FIRST ━━━

highway.js is a CLASSIC script. Its top-level `const highway = createHighway()` therefore
creates a GLOBAL LEXICAL BINDING — visible as a bare name to every other classic script AND
to every ES module. 73 call sites quietly rely on that.

The moment highway.js becomes a module, that binding is gone. `const` in a module is
module-scoped, not global. Every one of those 73 sites becomes a ReferenceError, and the
flip is impossible until they say what they mean.

`window.highway = highway` is already set, to the same object, on the same line. So this is
an identity rewrite — verified in the browser below.

━━━ THE REWRITE BIT ME THREE TIMES. REGEX IS NOT ENOUGH FOR THIS. ━━━

1. A SHADOWED LOCAL. capabilities/note-detection.js does `const highway = window.highway`.
   Its 9 bare uses are LOCAL and already correct; a blind rewrite would have emitted
   `const window.highway = window.highway`. Excluded.

2. HALF-CONVERTED GUARDS — the dangerous one. Six sites read
   `typeof highway !== 'undefined' && highway && typeof highway.setTime === 'function'`.
   The regex converted the CONSEQUENT and left the TEST, which is WORSE than not touching
   them: after the flip `typeof highway` is 'undefined', so each guard is PERMANENTLY FALSE
   and the code behind it silently never runs. transport.js's was the seek->setTime sync:
   the chart clock would have quietly desynced after every seek, with nothing failing.
   All six now test window.highway.

3. TWO MORE BARE REFERENCES, found by Codex [P2] and confirmed by an AST scan: app.js:3114
   and :3176 use `highway && typeof window.highway.getSections === 'function'`. My grep
   searched for `typeof highway`, not `highway &&`. After the flip these throw, the catch
   swallows it, and the editor silently falls back to a ±4s edit window and arrangement 0.

Regex missed a shadow, a half-conversion, and two bare reads. The final check is an
AST pass that resolves scopes and reports every `highway` identifier not bound locally.
It now reports ZERO.

VERIFIED. A/B against origin/main in two browsers, 15 probes, IDENTICAL, zero page errors:
window.highway is the same object as the bare global, the whole API surface resolves, a real
song plays, the chart clock advances, getPerf().drawMs > 0 — and `seek syncs chart` passes,
which is the exact guard I nearly broke in (2).

node 1045, pytest 2416, ESLint 0, Codex 0.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-12 11:56:07 +02:00

254 lines
8.1 KiB
JavaScript

/*
* fee[dB]ack v0.3.0 — Venue 3D scene bridge.
*
* Activates the highway_3d `venue` background style when Visualization = Venue.
* Reacts to v3:live-performance-state for lighting mood (read-only).
*/
(function (root) {
'use strict';
const THEME_ID = 'small-club';
const ASSET_BASE = '/static/assets/venue/themes/small-club/';
const BG_PLATE = 'bg-plate.png';
const BG_PLATE_WEBP = 'bg-plate.webp';
let _active = false;
let _assetsLoaded = false;
let _loadFailed = false;
let _lastMood = 'idle';
let _bound = false;
function isVenueViz() {
if (root && root.v3VenueViz && typeof root.v3VenueViz.isVenueVisualization === 'function') {
const sel = root.v3VenueViz.getSelectedVizId
? root.v3VenueViz.getSelectedVizId()
: root.v3VenueViz.readVizSelection();
return root.v3VenueViz.isVenueVisualization(sel);
}
try {
const sel = document.getElementById('viz-picker');
if (sel && sel.value) return String(sel.value) === 'venue';
return localStorage.getItem('vizSelection') === 'venue';
} catch (_) {
return false;
}
}
function h3dApi(name) {
return root && typeof root[name] === 'function' ? root[name] : null;
}
function setH3dActive(on) {
const fn = h3dApi('h3dVenueSceneSetActive');
if (fn) fn(!!on);
}
function setH3dMood(state) {
const fn = h3dApi('h3dVenueSceneSetMood');
if (fn) fn(state);
}
function readH3dState() {
const fn = h3dApi('h3dVenueSceneGetState');
return fn ? fn() : null;
}
function syncPlaceholderVisibility() {
try {
if (root && root.v3VenueViz && typeof root.v3VenueViz.syncPlayerVizClass === 'function') {
const id = root.v3VenueViz.getSelectedVizId
? root.v3VenueViz.getSelectedVizId()
: root.v3VenueViz.readVizSelection();
root.v3VenueViz.syncPlayerVizClass(id);
}
} catch (_) { /* visual-only */ }
try {
if (root && root.v3VenueMoodFx && typeof root.v3VenueMoodFx.onVenueVisualizationSelected === 'function' &&
isVenueViz()) {
root.v3VenueMoodFx.onVenueVisualizationSelected();
}
} catch (_) { /* visual-only */ }
}
function readArrangementSignal() {
// Intentional karaoke/vocals signal: active arrangement name from the
// highway WS (user selected Vocals in #arr-select). Do NOT use
// window.highway.getLyricsVisible() — lyrics overlay stays on during normal
// guitar practice and must not force vocals POV.
try {
const si = root.highway && typeof root.highway.getSongInfo === 'function'
? root.highway.getSongInfo()
: null;
if (si && si.arrangement) return si.arrangement;
const cs = root.feedBack && root.feedBack.currentSong;
if (cs && cs.arrangement) return cs.arrangement;
if (cs && cs.arrangementSmartName) return cs.arrangementSmartName;
} catch (_) { /* visual-only */ }
return '';
}
function syncInstrumentPov() {
const fn = h3dApi('h3dVenueSceneSetInstrumentPov');
if (fn) fn(readArrangementSignal());
}
function activate() {
if (_active) {
syncInstrumentPov();
syncVenueMotion();
return;
}
_active = true;
_assetsLoaded = false;
_loadFailed = false;
setH3dActive(true);
setH3dMood(_lastMood);
syncInstrumentPov();
syncVenueMotion();
}
function syncVenueMotion() {
const motionApi = root && root.v3VenueMoodFx;
const mode = motionApi && typeof motionApi.getMotion === 'function'
? motionApi.getMotion()
: 'subtle';
const fn = h3dApi('h3dVenueSceneSetMotionMode');
if (fn) fn(mode);
else if (motionApi && typeof motionApi.syncMotionToRenderer === 'function') {
motionApi.syncMotionToRenderer(mode);
}
}
function deactivate() {
if (!_active) {
setH3dActive(false);
return;
}
_active = false;
_assetsLoaded = false;
_loadFailed = false;
setH3dActive(false);
syncPlaceholderVisibility();
}
function syncViz(vizId) {
const id = String(vizId || '');
if (id === 'venue') {
activate();
} else {
deactivate();
}
}
function onPerformanceState(e) {
if (!_active) return;
const d = (e && e.detail) || {};
const state = String(d.state || 'idle').toLowerCase();
// v3:live-performance-state fires per note hit/miss; skip the renderer
// push when the mood is unchanged (e.g. a run of hits all in 'fire').
if (state === _lastMood) return;
_lastMood = state;
setH3dMood(state);
}
function onAssetsLoaded() {
_assetsLoaded = true;
_loadFailed = false;
syncPlaceholderVisibility();
}
function onAssetsFailed() {
_loadFailed = true;
_assetsLoaded = false;
syncPlaceholderVisibility();
}
function bindRuntime() {
if (_bound) return;
_bound = true;
const sm = root && root.feedBack;
if (sm && typeof sm.on === 'function') {
sm.on('v3:live-performance-state', onPerformanceState);
sm.on('song:loaded', () => {
if (_active) syncInstrumentPov();
});
sm.on('arrangement:changed', () => {
if (_active) syncInstrumentPov();
});
sm.on('song:arrangement-changed', () => {
if (_active) syncInstrumentPov();
});
sm.on('viz:renderer:ready', () => {
if (isVenueViz()) activate();
else deactivate();
});
sm.on('viz:reverted', () => deactivate());
}
if (isVenueViz()) activate();
}
function getState() {
const h3d = readH3dState();
const povApi = root && root.v3VenueInstrumentPov;
const arrangement = readArrangementSignal();
const instrumentPov = povApi && typeof povApi.resolveVenueInstrumentPov === 'function'
? povApi.resolveVenueInstrumentPov(arrangement)
: 'guitar';
return {
active: _active,
themeId: THEME_ID,
assetBase: ASSET_BASE,
arrangement,
instrumentPov,
assetsLoaded: _assetsLoaded || !!(h3d && h3d.assetsLoaded),
loadFailed: _loadFailed || !!(h3d && h3d.loadFailed),
mood: _lastMood,
h3dVenueState: h3d,
isVenueViz: isVenueViz(),
};
}
function shouldShowDomPlaceholder() {
// V2: no on-screen construction badge during Venue playback.
return false;
}
const api = {
THEME_ID,
ASSET_BASE,
BG_PLATE,
BG_PLATE_WEBP,
activate,
deactivate,
syncViz,
onAssetsLoaded,
onAssetsFailed,
onPerformanceState,
bindRuntime,
getState,
syncInstrumentPov,
syncVenueMotion,
readArrangementSignal,
shouldShowDomPlaceholder,
isSceneLoaded: () => {
if (_assetsLoaded) return true;
const h3d = readH3dState();
return !!(h3d && h3d.assetsLoaded);
},
};
if (root) root.v3VenueScene3d = api;
if (typeof module !== 'undefined' && module.exports) module.exports = api;
if (typeof document !== 'undefined') {
const boot = () => bindRuntime();
// `defer` runs this at readyState 'interactive' — later scripts have not
// evaluated yet, so wait for DOMContentLoaded (see static/v3/index.html).
if (document.readyState !== 'complete') {
document.addEventListener('DOMContentLoaded', boot);
} else {
boot();
}
}
}(typeof window !== 'undefined' ? window : (typeof globalThis !== 'undefined' ? globalThis : null)));