mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-25 06:11:36 +00:00
286c59707b
Two pre-existing failures the segfault had been masking (the run aborted at ~25%, so they never ran until #735 let the suite complete): 1) Tuner group (~24): plugins ship a bare-named routes.py, so sys.modules['routes'] leaked between plugin test dirs (achievements ran first, tuner got its module). Each plugin conftest now pops the stale 'routes' and an autouse fixture binds sys.modules['routes'] to that plugin's module for the duration of its tests (covers runtime 'import routes' in test bodies). 2) Diagnostics group (5): _SONG_FILENAME_RE never matched the tests' .feedpak/.archive filenames — it also lacked 'feedpak' (the current primary format), a real redaction gap. Added feedpak to the regex and switched the tests off the fake .archive to the real .feedpak. Verified: full suite 2183 passed, 0 failed. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
43 lines
1.2 KiB
Python
43 lines
1.2 KiB
Python
import sys
|
|
from pathlib import Path
|
|
sys.path.insert(0, str(Path(__file__).parent.parent.parent.parent / 'plugins' / 'tuner'))
|
|
|
|
import pytest
|
|
from fastapi import FastAPI
|
|
from fastapi.testclient import TestClient
|
|
# Drop a sibling 'routes' cached by another plugin's tests (bare-name collision).
|
|
sys.modules.pop('routes', None)
|
|
import routes as tuner_routes
|
|
|
|
|
|
@pytest.fixture
|
|
def config_dir(tmp_path):
|
|
return tmp_path
|
|
|
|
|
|
@pytest.fixture
|
|
def client(config_dir):
|
|
app = FastAPI()
|
|
tuner_routes.setup(app, {
|
|
"config_dir": str(config_dir),
|
|
"register_tuning_provider": lambda pid, fn: None,
|
|
"unregister_tuning_provider": lambda pid: None,
|
|
})
|
|
return TestClient(app)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _bind_tuner_routes():
|
|
"""Keep sys.modules['routes'] pointing at THIS plugin's routes for these
|
|
tests, so a runtime `import routes` in a test body resolves correctly
|
|
regardless of which other plugin's bare-named routes ran first."""
|
|
prev = sys.modules.get('routes')
|
|
sys.modules['routes'] = tuner_routes
|
|
try:
|
|
yield
|
|
finally:
|
|
if prev is not None:
|
|
sys.modules['routes'] = prev
|
|
else:
|
|
sys.modules.pop('routes', None)
|