mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-12 19:59:35 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
148 lines
5.7 KiB
JavaScript
148 lines
5.7 KiB
JavaScript
// Verify restartCurrentSong() uses the canonical _audioSeek / togglePlay /
|
|
// startCountIn paths without clearing loops or reloading the song.
|
|
//
|
|
// Same isolation strategy as song_seek.test.js — extract the function from
|
|
// app.js by brace-matching and run it in a vm sandbox with stubbed deps.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const { extractFunction } = require('./test_utils');
|
|
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
const V3_HTML = path.join(__dirname, '..', '..', 'static', 'v3', 'index.html');
|
|
const V2_HTML = path.join(__dirname, '..', '..', 'static', 'index.html');
|
|
|
|
function buildSandbox({ loopA = null, loopB = null, isPlaying = false } = {}) {
|
|
const sandbox = {
|
|
loopA,
|
|
loopB,
|
|
isPlaying,
|
|
__cancelCountInCalls: 0,
|
|
__seekCalls: [],
|
|
__startCountInCalls: [],
|
|
__togglePlayCalls: 0,
|
|
__clearLoopCalls: 0,
|
|
window: {
|
|
feedBack: {
|
|
getLoop() {
|
|
return { loopA: sandbox.loopA, loopB: sandbox.loopB };
|
|
},
|
|
},
|
|
},
|
|
__audioSeek(s, reason) {
|
|
sandbox.__seekCalls.push({ s, reason });
|
|
return Promise.resolve({ completed: true, from: 30, to: s });
|
|
},
|
|
__startCountIn(opts) {
|
|
sandbox.__startCountInCalls.push(opts);
|
|
return Promise.resolve();
|
|
},
|
|
__togglePlay() {
|
|
sandbox.__togglePlayCalls++;
|
|
sandbox.isPlaying = true;
|
|
return Promise.resolve();
|
|
},
|
|
};
|
|
vm.createContext(sandbox);
|
|
return sandbox;
|
|
}
|
|
|
|
function loadRestart(sandbox, src, { audioSeekImpl } = {}) {
|
|
const restartSrc = extractFunction(src, 'async function restartCurrentSong(');
|
|
const code = `
|
|
var isPlaying = ${sandbox.isPlaying};
|
|
function _cancelCountIn() { __cancelCountInCalls++; }
|
|
async function _audioSeek(s, reason) {
|
|
return (${audioSeekImpl || '__audioSeek'})(s, reason);
|
|
}
|
|
async function startCountIn(opts) { return __startCountIn(opts); }
|
|
async function togglePlay() { return __togglePlay(); }
|
|
function clearLoop() { __clearLoopCalls++; }
|
|
${restartSrc}
|
|
globalThis.__restartCurrentSong = restartCurrentSong;
|
|
`;
|
|
vm.runInContext(code, sandbox);
|
|
}
|
|
|
|
test('restartCurrentSong is exported on window and window.feedBack', () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
assert.match(src, /window\.restartCurrentSong\s*=\s*restartCurrentSong/);
|
|
assert.match(src, /window\.feedBack\.restartCurrentSong\s*=\s*restartCurrentSong/);
|
|
});
|
|
|
|
test('no loop: seeks to 0 with song-restart and starts playback when stopped', async () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const sandbox = buildSandbox({ isPlaying: false });
|
|
loadRestart(sandbox, src);
|
|
|
|
const ok = await sandbox.__restartCurrentSong();
|
|
assert.equal(ok, true);
|
|
assert.equal(sandbox.__cancelCountInCalls, 1);
|
|
assert.equal(sandbox.__seekCalls.length, 1);
|
|
assert.equal(sandbox.__seekCalls[0].s, 0);
|
|
assert.equal(sandbox.__seekCalls[0].reason, 'song-restart');
|
|
assert.equal(sandbox.__togglePlayCalls, 1);
|
|
assert.equal(sandbox.__startCountInCalls.length, 0);
|
|
assert.equal(sandbox.__clearLoopCalls, 0);
|
|
});
|
|
|
|
test('already playing, no loop: seeks to 0 and does not toggle play', async () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const sandbox = buildSandbox({ isPlaying: true });
|
|
loadRestart(sandbox, src);
|
|
|
|
const ok = await sandbox.__restartCurrentSong();
|
|
assert.equal(ok, true);
|
|
assert.equal(sandbox.__seekCalls[0].s, 0);
|
|
assert.equal(sandbox.__togglePlayCalls, 0);
|
|
assert.equal(sandbox.__clearLoopCalls, 0);
|
|
});
|
|
|
|
test('loop armed: seeks to loopA, preserves loop, re-enters via startCountIn immediate', async () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const sandbox = buildSandbox({ loopA: 12.5, loopB: 48, isPlaying: false });
|
|
loadRestart(sandbox, src);
|
|
|
|
const ok = await sandbox.__restartCurrentSong();
|
|
assert.equal(ok, true);
|
|
assert.equal(sandbox.__seekCalls.length, 1);
|
|
assert.equal(sandbox.__seekCalls[0].s, 12.5);
|
|
assert.equal(sandbox.__seekCalls[0].reason, 'song-restart');
|
|
assert.equal(sandbox.__startCountInCalls.length, 1);
|
|
assert.equal(sandbox.__startCountInCalls[0].immediate, true);
|
|
assert.equal(sandbox.__togglePlayCalls, 0);
|
|
assert.equal(sandbox.__clearLoopCalls, 0);
|
|
assert.equal(sandbox.loopB, 48, 'loopB must be preserved');
|
|
});
|
|
|
|
test('failed/incomplete seek: does not start playback or count-in', async () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const sandbox = buildSandbox({ isPlaying: false });
|
|
loadRestart(sandbox, src, {
|
|
audioSeekImpl: '(s, reason) => Promise.resolve({ completed: false, from: NaN, to: NaN })',
|
|
});
|
|
|
|
const ok = await sandbox.__restartCurrentSong();
|
|
assert.equal(ok, false);
|
|
assert.equal(sandbox.__togglePlayCalls, 0);
|
|
assert.equal(sandbox.__startCountInCalls.length, 0);
|
|
});
|
|
|
|
test('V3 transport restart button exists with correct attributes', () => {
|
|
const html = fs.readFileSync(V3_HTML, 'utf8');
|
|
assert.match(html, /v3-transport-mid[\s\S]*onclick="restartCurrentSong\(\)"/);
|
|
assert.match(html, /title="Restart song"/);
|
|
assert.match(html, /aria-label="Restart song"/);
|
|
});
|
|
|
|
test('V2 transport restart button exists with correct attributes', () => {
|
|
const html = fs.readFileSync(V2_HTML, 'utf8');
|
|
assert.match(html, /#player-controls|player-controls[\s\S]*onclick="restartCurrentSong\(\)"/);
|
|
assert.match(html, /title="Restart song"/);
|
|
assert.match(html, /aria-label="Restart song"/);
|
|
});
|