Files
feedBack/tests/js/song_event_payload.test.js
T
af2949677a rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:03:01 +02:00

148 lines
6.0 KiB
JavaScript

// Verify song:play / song:pause / song:ended carry the enriched
// payload { time, audioT, chartT, perfNow } so plugins can anchor
// their own clocks without a follow-up highway.getTime() call.
//
// Same isolation strategy as the other plugin-API tests — extract
// `_songEventPayload` and `_audioTime` from app.js and run them in a
// vm sandbox.
const { test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const vm = require('node:vm');
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
function extractFunction(src, signature) {
const start = src.indexOf(signature);
if (start === -1) throw new Error(`extractFunction: '${signature}' not found in app.js`);
const openBrace = src.indexOf('{', start);
let depth = 1;
let i = openBrace + 1;
while (i < src.length && depth > 0) {
const ch = src[i];
if (ch === '{') depth++;
else if (ch === '}') depth--;
i++;
}
if (depth !== 0) throw new Error(`extractFunction: unbalanced braces after '${signature}'`);
return src.slice(start, i);
}
function buildSandbox({ juceMode = false, audioT = 12.5, chartT = 11.8, juceT } = {}) {
// When juceT is omitted in JUCE mode, derive a value distinct from
// audioT so the JUCE-mode test actually proves _audioTime() reads
// from jucePlayer rather than the html5 audio element.
const jt = juceT !== undefined ? juceT : (juceMode ? audioT + 100 : audioT);
const sandbox = {
audio: { currentTime: audioT },
jucePlayer: { currentTime: jt, duration: 200 },
window: { _juceMode: juceMode },
highway: {
getTime: () => chartT,
},
performance: { now: () => 1000.123 },
};
vm.createContext(sandbox);
return sandbox;
}
function loadFunctions(sandbox, src) {
const code = `
${extractFunction(src, 'function _audioTime()')}
${extractFunction(src, 'function _audioDuration()')}
${extractFunction(src, 'function _songEventPayload()')}
globalThis.__payload = _songEventPayload;
`;
vm.runInContext(code, sandbox);
}
test('_songEventPayload returns { time, audioT, chartT, perfNow } (HTML5)', () => {
const src = fs.readFileSync(APP_JS, 'utf8');
const sandbox = buildSandbox({ juceMode: false, audioT: 12.5, chartT: 11.8 });
loadFunctions(sandbox, src);
const p = sandbox.__payload();
assert.equal(p.audioT, 12.5);
assert.equal(p.chartT, 11.8);
assert.equal(p.perfNow, 1000.123);
assert.equal(p.time, 12.5, 'time must be an alias for audioT');
assert.equal(Object.keys(p).length, 4);
});
test('_songEventPayload reads from JUCE in juce mode', () => {
const src = fs.readFileSync(APP_JS, 'utf8');
// audioT (audio.currentTime) and juceT (jucePlayer.currentTime) are
// distinct so the assertion proves we read from JUCE, not from the
// html5 audio element.
const sandbox = buildSandbox({ juceMode: true, audioT: 5, juceT: 42, chartT: 41 });
loadFunctions(sandbox, src);
const p = sandbox.__payload();
assert.equal(p.audioT, 42, 'JUCE mode must read jucePlayer.currentTime, not audio.currentTime');
assert.equal(p.time, 42);
assert.equal(p.chartT, 41);
});
test('time and audioT are the same number (not duplicated computation)', () => {
// Cache invariant: audioT is read once and assigned to both fields.
// If the implementation read _audioTime() twice and the underlying
// value drifted between reads, time !== audioT. Guard the cache.
const src = fs.readFileSync(APP_JS, 'utf8');
let reads = 0;
const sandbox = {
audio: { get currentTime() { reads++; return 5 + reads * 0.001; } },
jucePlayer: { currentTime: 0 },
window: { _juceMode: false },
highway: { getTime: () => 4.9 },
performance: { now: () => 1000 },
};
vm.createContext(sandbox);
loadFunctions(sandbox, src);
const p = sandbox.__payload();
assert.equal(p.time, p.audioT, 'time must equal audioT');
});
test('every song:play/pause/ended emit uses _songEventPayload', () => {
// Source-level guard: catch a future contributor adding a new emit
// site with a literal { time: x } payload — that would silently drop
// chartT/perfNow and break plugins that depend on the enriched shape.
// Accepts either a direct _songEventPayload() call or a captured
// `payload` var (used by JUCE teardown sites that snapshot before
// jucePlayer.stop() resets _pos to 0).
const src = fs.readFileSync(APP_JS, 'utf8');
const lines = src.split('\n');
// Accept aliased calls like `sm.emit(...)` (the JUCE shim caches
// window.feedBack in `sm`) — not just literal `window.feedBack.emit`.
const emitRe = /(?:window\.feedBack|\w+)\.emit\(\s*['"]song:(play|pause|ended)['"]/;
const okRe = /_songEventPayload\(\)|,\s*payload\s*\)/;
const offending = [];
for (const line of lines) {
if (!emitRe.test(line)) continue;
if (!okRe.test(line)) {
offending.push(line.trim());
}
}
assert.equal(
offending.length,
0,
`song:* emits not using _songEventPayload():\n${offending.join('\n')}`,
);
});
test('there are at least 8 song:* emit sites threaded through the helper', () => {
// Sanity-check that the helper actually got wired everywhere. If the
// count drops, someone removed an emit (regression) or refactored an
// event away (intentional — this test then needs updating).
const src = fs.readFileSync(APP_JS, 'utf8');
const matches = src.match(/(?:window\.feedBack|\w+)\.emit\(\s*['"]song:(play|pause|ended)['"][^)]*\)/g) || [];
assert.ok(
matches.length >= 8,
`expected ≥8 song:* emits, found ${matches.length}`,
);
// Same dual-form acceptance as the per-line check: either a direct
// _songEventPayload() call or a captured `payload` var.
for (const m of matches) {
assert.match(m, /_songEventPayload\(\)|,\s*payload\s*\)/, `emit not using helper: ${m}`);
}
});