Files
feedBack/static/v3/live-guitar-tone-source.js
T
af2949677a rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:03:01 +02:00

104 lines
3.3 KiB
JavaScript

/*
* fee[dB]ack v0.3.0 — live guitar tone source preference.
*
* Lets users who get guitar tone from external hardware (Spark LIVE, pedalboards,
* etc.) opt out of the desktop "no internal amp loaded" monitor-mute hint.
* Persisted in localStorage; desktop renderer reads the same key directly.
*/
(function (root) {
'use strict';
const KEY = 'feedBack-live-guitar-tone-source';
const SOURCES = Object.freeze({
INTERNAL: 'internal',
EXTERNAL_HARDWARE: 'external_hardware',
SPARK_CONTROL_X: 'spark_control_x',
});
const DEFAULT = SOURCES.INTERNAL;
const LABELS = Object.freeze({
[SOURCES.INTERNAL]: 'fee[dB]ack internal tone',
[SOURCES.EXTERNAL_HARDWARE]: 'External amp / hardware pedalboard',
[SOURCES.SPARK_CONTROL_X]: 'Spark LIVE + Spark Control X',
});
const HELP_TEXT =
'Choose External/Spark if your guitar tone comes from hardware like Spark LIVE. '
+ 'fee[dB]ack will still score your playing but won\u2019t warn that no internal amp tone is loaded.';
function normalize(value) {
if (value === SOURCES.EXTERNAL_HARDWARE || value === SOURCES.SPARK_CONTROL_X) return value;
return DEFAULT;
}
function get() {
try { return normalize(localStorage.getItem(KEY)); } catch (_) { return DEFAULT; }
}
function set(value) {
const next = normalize(value);
try { localStorage.setItem(KEY, next); } catch (_) { /* private mode / quota */ }
syncSelects(next);
return next;
}
function shouldSuppressMonitorMuteHint(source) {
const s = normalize(source == null ? get() : source);
return s === SOURCES.EXTERNAL_HARDWARE || s === SOURCES.SPARK_CONTROL_X;
}
function syncSelects(value) {
// Exported + required in tests; guard DOM access so set()/init() can be
// called in a non-browser environment without throwing.
if (typeof document === 'undefined') return;
const v = normalize(value == null ? get() : value);
document.querySelectorAll('[data-live-guitar-tone-source]').forEach((el) => {
if (el && el.value !== v) el.value = v;
});
}
function bindSelect(el) {
if (!el || el.dataset.liveGuitarToneBound === '1') return;
el.dataset.liveGuitarToneBound = '1';
el.setAttribute('data-live-guitar-tone-source', '1');
el.value = get();
el.addEventListener('change', () => { set(el.value); });
}
function init() {
if (typeof document === 'undefined') return;
bindSelect(document.getElementById('setting-live-guitar-tone-source'));
bindSelect(document.getElementById('player-live-guitar-tone-source'));
syncSelects();
}
const api = {
KEY,
SOURCES,
DEFAULT,
LABELS,
HELP_TEXT,
get,
set,
normalize,
shouldSuppressMonitorMuteHint,
init,
};
if (root) root.v3LiveGuitarToneSource = api;
if (typeof module !== 'undefined' && module.exports) {
module.exports = api;
}
if (typeof document !== 'undefined') {
if (document.readyState === 'loading') {
document.addEventListener('DOMContentLoaded', init);
} else {
init();
}
}
}(typeof window !== 'undefined' ? window : null));