mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-09-11 07:14:30 +00:00
byrongamatosandClaude Sonnet 4.6
a55dca7893
F1 (HIGH): _CV_KEY_TIME_MUL / _CV_KEY_TIME_SLOT were moved into the renderer.js closure at06e4fe3but _encodeChordVerdictKey (defined in screen.js IIFE scope, DI'd as fn-ref) still reads them from screen.js scope → ReferenceError on first chord-template chart frame. Fix: restore both consts to screen.js (declared before _encodeChordVerdictKey), add them as DI shorthands in renderer.js, remove closure copies. Single source of truth — no dual definitions. Kill test 23: asserts _CV_KEY_TIME_MUL / _SLOT are declared in screen.js before _encodeChordVerdictKey. RED at06e4fe3, GREEN here. F2 (MED): test #16 createRenderer regex /const \{ update \} = .../ did not match after F1-prewarm added _prewarmStatic/_prewarmChart to the destructure → vacuous pass (wiring block never extracted, 0 shorthands checked). Fix: updated regex to /const \{[^}]*update[^}]*\} = createRenderer\({...}\)/. Added anti-vacuity floor: assert extracted Set.size >= 150 so a future regex break fails loudly. P3 (LOW): added ⚠ comment on smoke tests 23-25 documenting the new Function sloppy-mode hole and naming eslint no-undef as the compensating layer. DI count: 313 → 315 (+2 shorthands for _CV_KEY_TIME_MUL / _CV_KEY_TIME_SLOT). Suite: 1406/1407 (test 46 pre-existing). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW