mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 11:19:24 +00:00
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
121 lines
4.2 KiB
TypeScript
121 lines
4.2 KiB
TypeScript
import { test, expect } from '@playwright/test';
|
|
|
|
test('left-handed setting reaches the 3D Highway renderer with a mocked song stream', async ({ page }) => {
|
|
const errors: string[] = [];
|
|
|
|
page.on('console', msg => {
|
|
if (msg.type() === 'error') errors.push(msg.text());
|
|
});
|
|
page.on('pageerror', error => {
|
|
errors.push(`PAGE ERROR: ${error.message}`);
|
|
});
|
|
|
|
await page.addInitScript(() => {
|
|
localStorage.setItem('lefty', '1');
|
|
localStorage.setItem('vizSelection', 'highway_3d');
|
|
|
|
class MockHighwayWebSocket {
|
|
static CONNECTING = 0;
|
|
static OPEN = 1;
|
|
static CLOSING = 2;
|
|
static CLOSED = 3;
|
|
|
|
url: string;
|
|
readyState = MockHighwayWebSocket.CONNECTING;
|
|
onopen: ((event: Event) => void) | null = null;
|
|
onmessage: ((event: MessageEvent) => void) | null = null;
|
|
onclose: ((event: CloseEvent) => void) | null = null;
|
|
onerror: ((event: Event) => void) | null = null;
|
|
|
|
constructor(url: string) {
|
|
this.url = url;
|
|
setTimeout(() => {
|
|
this.readyState = MockHighwayWebSocket.OPEN;
|
|
this.onopen?.(new Event('open'));
|
|
this.emitSong();
|
|
}, 0);
|
|
}
|
|
|
|
send() {}
|
|
|
|
close() {
|
|
this.readyState = MockHighwayWebSocket.CLOSED;
|
|
this.onclose?.(new CloseEvent('close'));
|
|
}
|
|
|
|
private emit(payload: unknown) {
|
|
this.onmessage?.(new MessageEvent('message', { data: JSON.stringify(payload) }));
|
|
}
|
|
|
|
private emitSong() {
|
|
this.emit({
|
|
type: 'song_info',
|
|
artist: 'Smoke Test',
|
|
title: 'Lefty Highway',
|
|
arrangement: 'Lead',
|
|
arrangement_smart_name: 'Lead',
|
|
arrangement_index: 0,
|
|
naming_mode: 'smart',
|
|
tuning: [0, 0, 0, 0, 0, 0],
|
|
stringCount: 6,
|
|
duration: 30,
|
|
audio_url: null,
|
|
});
|
|
this.emit({ type: 'beats', data: [{ time: 0 }, { time: 1 }] });
|
|
this.emit({ type: 'sections', data: [] });
|
|
this.emit({ type: 'anchors', data: [{ time: 0, fret: 1, width: 4 }] });
|
|
this.emit({ type: 'chord_templates', data: [] });
|
|
this.emit({ type: 'notes', data: [{ t: 1, s: 0, f: 3, d: 0 }] });
|
|
this.emit({ type: 'chords', data: [] });
|
|
this.emit({ type: 'handshapes', data: [] });
|
|
this.emit({ type: 'ready' });
|
|
}
|
|
}
|
|
|
|
Object.assign(MockHighwayWebSocket, {
|
|
CONNECTING: MockHighwayWebSocket.CONNECTING,
|
|
OPEN: MockHighwayWebSocket.OPEN,
|
|
CLOSING: MockHighwayWebSocket.CLOSING,
|
|
CLOSED: MockHighwayWebSocket.CLOSED,
|
|
});
|
|
|
|
window.WebSocket = MockHighwayWebSocket as unknown as typeof WebSocket;
|
|
});
|
|
|
|
await page.goto('/');
|
|
await page.waitForSelector('.screen.active', { timeout: 10000 });
|
|
await page.waitForFunction(() => typeof (window as any).playSong === 'function' && !!(window as any).highway);
|
|
await page.waitForFunction(() => {
|
|
const picker = document.getElementById('viz-picker') as HTMLSelectElement | null;
|
|
return picker?.value === 'highway_3d';
|
|
});
|
|
await expect(page.locator('#viz-picker')).toHaveValue('highway_3d');
|
|
await page.evaluate(() => {
|
|
(window as any).__h3dReadySeen = false;
|
|
(window as any).feedBack.on('viz:renderer:ready', () => {
|
|
(window as any).__h3dReadySeen = true;
|
|
}, { once: true });
|
|
});
|
|
|
|
await page.evaluate(() => (window as any).playSong('mock-lefty.sloppak', 0));
|
|
await page.waitForSelector('#player.active', { timeout: 10000 });
|
|
await page.waitForFunction(() => (window as any).highway?.getSongInfo?.().title === 'Lefty Highway');
|
|
await page.waitForFunction(() => (window as any).__h3dReadySeen === true, { timeout: 10000 });
|
|
await expect.poll(
|
|
async () => page.evaluate(() => !(window as any).highway.isDefaultRenderer()),
|
|
{ timeout: 5000 },
|
|
).toBe(true);
|
|
|
|
await expect.poll(
|
|
async () => page.evaluate(() => (window as any).highway.getLefty()),
|
|
{ timeout: 5000 },
|
|
).toBe(true);
|
|
|
|
await page.evaluate(() => (window as any).showScreen('settings'));
|
|
await page.waitForSelector('#settings.active', { timeout: 5000 });
|
|
await expect(page.locator('#setting-lefty')).toBeChecked();
|
|
|
|
const allowedErrors = ['favicon.ico'];
|
|
expect(errors.filter(e => !allowedErrors.some(allowed => e.includes(allowed)))).toEqual([]);
|
|
});
|