mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-09-11 03:14:29 +00:00
byrongamatosandClaude Sonnet 4.6
7623ad85e3
- createRenderer factory DI: 241 params (consts, fn-refs, 33 pool getters, material/settings/camera/ND getters, 35 setters) - screen.js: tombstone + createRenderer wiring after createNoteRenderer + createCamera wirings (§1 ruling: createNoteRenderer called from screen.js) - Restore createArp wiring + _resetStringDependentCaches to screen.js (accidentally dropped during carve; both needed in IIFE scope) - smoothNow: correction 3 — setter form setFrameNow(v); return v (no bare return (_frameNow = raw)) - _applyNoteCamTargets callers: 2 sites (7940/9923); correction 2 verified - lookaheadSmoothCamStep callers: 3 sites (9963/9974/9978); correction 2 verified - plugin.json: bump 3.50.0 → 3.51.0 Tests (16 files updated to scan renderer.js): - highway_3d_renderer.test.js: new, 15 tests — export contract, DI count (241), tombstone, caller-list corrections, smoothNow semantics, ordering - highway_3d_arp_deferral.test.js: add renderer.js scan (deferChordGems / noteStreamCoversArpShape moved to renderer.js) - highway_3d_lean_sustain.test.js: add renderer.js scan; update to setLeanSus/getLeanSus() getter form - highway_3d_smooth_clock_pause.test.js: fix literal-newline syntax error; update to setClkAudioT/setClkPerf/setFrameNow setter form; update new-sample regex to match getClkAudioT() - highway_3d_slide_target.test.js: add renderer.js to src scan - highway_3d_sustain_rail.test.js: assert against rendererSrc (pattern moved from U-section) - highway_chart_transform.test.js: add utils.js scan (_openStringPitchLabels- ForTuning moved to src/utils.js by h3d-carve-3) - highway_note_state.test.js: add renderer.js scan (_ndGetNoteState / _ndHasProvider captures in renderer.js update()) - highway_3d_camera_bootstrap.test.js: setter form for camSnapped/curX/ measureStarts; renderer.js added to scan - highway_3d_camera_framing.test.js: renderer.js added; setMeasureStarts/ setCamSnapped setter form in assertions Suite: 1395/1396 (test 46 pre-existing failure unrelated to carve-15) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW
67 lines
3.2 KiB
JavaScript
67 lines
3.2 KiB
JavaScript
// Pins slide-target gem suppression in plugins/highway_3d/screen.js (PR #329).
|
|
// A note that is the slide/link destination of a preceding sustained note has
|
|
// its gem body suppressed (skipBody=true) so it does not render a duplicate
|
|
// gem on top of the slide trail — but the sustain/slide trail itself still
|
|
// renders so the slide motion stays visible. A refactor that drops the
|
|
// _slideTargetSet pre-pass, stops threading _isSlideTgt into drawNote, or
|
|
// moves the trail back inside the !skipBody gate would silently reintroduce
|
|
// duplicate gems or erase slide trails.
|
|
//
|
|
// Source-level only — same strategy as the other tests/js/ files.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'screen.js');
|
|
// h3d-carve-14: V-section moved to note-renderer.js
|
|
const NOTE_RENDERER_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'note-renderer.js');
|
|
const RENDERER_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'renderer.js');
|
|
const _noteSrc = fs.readFileSync(NOTE_RENDERER_JS, 'utf8');
|
|
|
|
test('a _slideTargetSet pre-pass builds the suppressed-gem set from bundle.notes', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + _noteSrc + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/const\s+checkSrc\s*=\s*\([^)]*\)\s*=>\s*\{[\s\S]*?stSet\.add\(/,
|
|
'pre-pass checkSrc must populate the slide-target set',
|
|
);
|
|
assert.match(
|
|
src,
|
|
/if\s*\(\s*stSet\.size\s*>\s*0\s*\)\s*_slideTargetSet\s*=\s*stSet/,
|
|
'_slideTargetSet must be assigned from the pre-pass result',
|
|
);
|
|
});
|
|
|
|
test('_isSlideTgt is derived from _slideTargetSet membership', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + _noteSrc + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/_isSlideTgt\s*=\s*!!\(\s*_slideTargetSet\s*&&\s*_slideTargetSet\.has\(/,
|
|
'_isSlideTgt must test _slideTargetSet membership',
|
|
);
|
|
});
|
|
|
|
test('_isSlideTgt is threaded into drawNote as the skipBody argument', () => {
|
|
// drawNote(n, now, openX, skipLabel, skipBody, ...) — _isSlideTgt sits in
|
|
// the 5th (skipBody) position so the gem body is suppressed.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + _noteSrc + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/drawNote\(\s*n\s*,\s*now\s*,\s*singleOpenX\s*,\s*skipLabel\s*,\s*_isSlideTgt\s*,/,
|
|
'_isSlideTgt must be passed as drawNote\'s skipBody argument',
|
|
);
|
|
});
|
|
|
|
test('the sustain trail renders for all notes, including skipBody slide targets', () => {
|
|
// The trail block must stay outside the !skipBody gem gate so suppressed
|
|
// slide-target gems still show their slide trail.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + _noteSrc + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/Rendered for ALL notes with sustain, including skipBody=true/,
|
|
'the sustain-trail comment contract must remain, marking the trail as unconditional',
|
|
);
|
|
});
|