mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
5fb28d5c5a
static/js/player-state.js — one exported object, two fields. app.js's 70 reference
sites rewritten. Provably a no-op; nothing shrinks.
WHY NOW. Every slice carved out of app.js so far only ever READ the state it shared
(loopA/loopB, _audioSeekGen, currentFilename), so a read-only getter hook was enough
and no container was needed — twice I checked and twice I got away with it. That
runs out at count-in: it genuinely WRITES `isPlaying` (it starts and stops playback,
4 sites) and `lastAudioTime` (2). `import { isPlaying }` then `isPlaying = true`
THROWS — an imported binding cannot be assigned to. So the state has to live on an
object: `S.isPlaying = true` is a property write, and works from any module holding
the same S. Same shape stems, studio, and editor all converged on.
DELIBERATELY SMALL. app.js has ~104 top-level `let` scalars; lifting all of them is
a ~977-site rewrite for no benefit, because most are private to one cluster and
travel with it. Only what a carved module must WRITE goes here. Add on demand.
THE REWRITE IS AST-DRIVEN, NOT TEXTUAL — and that is not fussiness. Of 100 textual
occurrences of these two names, only 70 resolve to the module binding:
* 22 are member accesses (`someObj.isPlaying`, `window.feedBack.isPlaying`)
* 4 are the LOCAL PARAMETER of `function setPlayButtonState(isPlaying)` — a blind
replace yields `function setPlayButtonState(S.isPlaying)`
* 1 is an object key
* 2 are shorthand properties `{ isPlaying }`, which must become
`{ isPlaying: S.isPlaying }` — and acorn gives a shorthand's key and value the
SAME range, so rewriting both produced `isPlaying: S.isPlaying: S.isPlaying`
until I deduped by range
A find-and-replace corrupts all 29. The rewrite walks the AST, skips shadows, member
properties and keys, and replaces identifier RANGES.
`window.feedBack.isPlaying` — the PUBLIC mirror — is a different thing and is
untouched. Two test sandboxes stub it; those were left alone deliberately.
VERIFIED WITH REAL PLAYBACK. A/B against origin/main in two browsers, real song:
togglePlay -> the public mirror goes true -> false -> true across two toggles, the
audio element's paused state follows, seekBy works — IDENTICAL, zero page errors.
Harnesses: 8 vm-sandbox suites slice playback code out of app.js and now see
S.isPlaying — juce_engine_reroute, loop_restart, play_button_reroute_guard,
playback_app_adapter, song_restart, song_seek, speed_reset, and the python
idempotence source-assert. Each gets the same container in its sandbox; every
assertion is unchanged.
pytest 2396, node 1040/1040, ESLint 0, tailwind clean, Codex 0.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
92 lines
3.4 KiB
JavaScript
92 lines
3.4 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
const APP_JS = path.join(__dirname, '..', '..', 'static', 'app.js');
|
|
|
|
function extractFunction(src, signature) {
|
|
const start = src.indexOf(signature);
|
|
if (start === -1) throw new Error(`extractFunction: '${signature}' not found in app.js`);
|
|
const openBrace = src.indexOf('{', start);
|
|
let depth = 1;
|
|
let i = openBrace + 1;
|
|
while (i < src.length && depth > 0) {
|
|
const ch = src[i];
|
|
if (ch === '{') depth++;
|
|
else if (ch === '}') depth--;
|
|
i++;
|
|
}
|
|
if (depth !== 0) throw new Error(`extractFunction: unbalanced braces after '${signature}'`);
|
|
return src.slice(start, i);
|
|
}
|
|
|
|
function buildReadySandbox() {
|
|
const listeners = new Map();
|
|
const sandbox = {
|
|
window: {
|
|
feedBack: {
|
|
on(event, fn) { listeners.set(event, fn); },
|
|
off(event, fn) { if (listeners.get(event) === fn) listeners.delete(event); },
|
|
},
|
|
},
|
|
setTimeout,
|
|
clearTimeout,
|
|
Promise,
|
|
__emit(event) {
|
|
const fn = listeners.get(event);
|
|
if (fn) fn();
|
|
},
|
|
};
|
|
vm.createContext(sandbox);
|
|
return sandbox;
|
|
}
|
|
|
|
function loadReadyHelper(sandbox, src) {
|
|
const code = `
|
|
let _audioSeekGen = 10;
|
|
${extractFunction(src, 'function _waitForSongReady(')}
|
|
globalThis.__waitForSongReady = _waitForSongReady;
|
|
globalThis.__setAudioSeekGen = value => { _audioSeekGen = value; };
|
|
`;
|
|
vm.runInContext(code, sandbox);
|
|
}
|
|
|
|
test('_waitForSongReady rejects a ready event from a different audio generation', async () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const sandbox = buildReadySandbox();
|
|
loadReadyHelper(sandbox, src);
|
|
|
|
const stale = sandbox.__waitForSongReady(11, 1000);
|
|
sandbox.__emit('song:ready');
|
|
assert.equal(await stale, false);
|
|
|
|
sandbox.__setAudioSeekGen(11);
|
|
const current = sandbox.__waitForSongReady(11, 1000);
|
|
sandbox.__emit('song:ready');
|
|
assert.equal(await current, true);
|
|
});
|
|
|
|
test('playback adapter scopes startTime readiness and validates seek targets', () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const fn = extractFunction(src, 'function _installPlaybackTransportAdapter()');
|
|
|
|
assert.match(fn, /const expectedSeekGen\s*=\s*_audioSeekGen\s*\+\s*1;/);
|
|
assert.match(fn, /_waitForSongReady\(expectedSeekGen\)/);
|
|
assert.match(fn, /const seconds\s*=\s*Number\(time\);/);
|
|
assert.match(fn, /!Number\.isFinite\(seconds\)\s*\|\|\s*seconds\s*<\s*0/);
|
|
assert.match(fn, /throw new Error\(`Invalid seek time:/);
|
|
assert.match(fn, /return _audioSeek\(seconds, reason \|\| 'playback-command'\);/);
|
|
});
|
|
|
|
test('playback adapter suppresses duplicate HTML5 pause events before emitting canonical pause', () => {
|
|
const src = fs.readFileSync(APP_JS, 'utf8');
|
|
const fn = extractFunction(src, 'function _installPlaybackTransportAdapter()');
|
|
|
|
// isPlaying moved onto the shared player-state container so a carved module can
|
|
// WRITE it (an imported binding is read-only). window.feedBack.isPlaying — the
|
|
// public mirror — is unchanged.
|
|
assert.match(fn, /if \(!window\._juceMode && wasPlaying\) \{\s*S\.isPlaying = false;\s*window\.feedBack\.isPlaying = false;\s*audio\.pause\(\);\s*_markPlaybackPaused\(\);\s*\}/);
|
|
});
|