feedBack/tests
Byron Gamatos 4dc5936712
feat(player): global autoplay & auto-exit option (songs + lessons) (#558)
* fix(v3): pedal click opens the plugin's screen, not its settings

The v3 Pedalboard's settingsTarget() resolved settings-first, so a
plugin that ships both a screen and a settings panel (notably the
bundled Audio Engine) could only ever reach its settings from the
pedalboard — its actual page was unreachable.

Flip to screen-first (stompbox metaphor: step on the pedal, see the
pedal), falling back to settings when there is no screen. Keep a
settings fallback in openPluginSettings() when a declared screen
isn't mounted yet (installing/failed) so settings-bearing plugins are
never stranded on a toast. Drive the pedal aria-label off the same
target so it never promises the wrong surface. Update the unit test
contract to screen > settings > none.

Fixes #555

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(player): global autoplay & auto-exit option (songs + lessons)

Single Settings toggle (autoplayExit, default ON) that auto-starts a song
once it's ready and returns to the launching menu when it ends. Auto-exit
defers while a results/score overlay is on top (heuristic + holdAutoExit()
contract) so a scoring plugin's screen drives the exit. Player origin is now
context-aware (lessons return to the lessons screen via setReturnScreen()),
fixing lesson completion bouncing to the library.

Core-only; songs and lessons share the playSong -> highway path. Adds a
read-only window.slopsmith.autoplayExit getter + holdAutoExit()/setReturnScreen()
for plugins. Unit tests for the pure helpers (_autoplayExitEnabled,
_resolvePlayerOrigin, _resultsOverlayVisible).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 11:04:03 +02:00
..
browser Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
fixtures Remove unused binary test fixture; correct stale scan comments 2026-06-16 18:49:40 +01:00
js feat(player): global autoplay & auto-exit option (songs + lessons) (#558) 2026-06-22 11:04:03 +02:00
plugins Clean release snapshot 2026-06-16 18:47:13 +02:00
__init__.py Clean release snapshot 2026-06-16 18:47:13 +02:00
conftest.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_audio_bundled.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_audio_effect_mappings.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_audio_local_path.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_audio.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_builtin_diagnostic_seed.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_correlation_id.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_demo_mode.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_diagnostics_bundle.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_diagnostics_hardware.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_diagnostics_redact.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_drums_lib.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_gp2midi.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_gp2notation.py feat(core): adopt feedpak_version — read on load + stamp on manifest writes (spec §4) (#530) 2026-06-20 21:59:04 +02:00
test_gp2rs_drums.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_gp2rs_gpx.py feat(core): teaching marks fg/ch/sd — wire + GP import + sd derivation (§6.2.2) (#536) 2026-06-21 07:57:50 +02:00
test_gp2rs.py feat(core): teaching marks fg/ch/sd — wire + GP import + sd derivation (§6.2.2) (#536) 2026-06-21 07:57:50 +02:00
test_gp_audio_sync.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_highway_3d_routes.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_highway_ws_notation.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_library_filters.py Improve wording in terminology cleanup 2026-06-16 19:43:45 +01:00
test_library_providers.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_lift_keys_notation.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_logging_setup.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_loose_traversal.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_loosefolder.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_lyrics_transcribe.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_midi_import_drums.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_midi_import.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_minigames_routes.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_notation_lib.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_notation_lift.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_notation_to_notes.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_parse_arrangement.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_playlists_api.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_plugin_manifest_contract.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_plugin_runtime_idempotence.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_plugins.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_profile_api.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_profile_domains.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_progression_api.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_progression.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_safepath.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_settings_api.py Make the library loader sloppak/loose-only 2026-06-16 19:09:53 +01:00
test_settings_export.py Make the library loader sloppak/loose-only 2026-06-16 19:09:53 +01:00
test_settings_instrument.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_cent_offset.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_cover_art.py Fix slow library cover loading: serve sloppak art without unpacking + revalidated caching (#534) 2026-06-20 00:22:43 +02:00
test_sloppak_drumtab_load.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_feedpak_version.py feat(core): adopt feedpak_version — read on load + stamp on manifest writes (spec §4) (#530) 2026-06-20 21:59:04 +02:00
test_sloppak_file_traversal.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_keys_load.py feat(core): consume keys.json — song-level key/scale track (loader + WS) (#528) 2026-06-20 21:23:48 +02:00
test_sloppak_notation_load.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_song_timeline_load.py feat(core): consume song_timeline tempos + time_signatures + per-chart tempos (feedpak 1.2.0) (#529) 2026-06-20 21:35:07 +02:00
test_song_score.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_song_stats_api.py fix(profile): wire "Your best scores" panel to real song stats (#549) (#550) 2026-06-21 20:55:02 +02:00
test_song.py fix(song): sanitize caged + guideTones on emit, not just decode (#544 follow-up) (#547) 2026-06-21 12:04:08 +02:00
test_songmeta.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_startup_status.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_tailwind_rebuild.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_tones.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_tunings.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_version_endpoint.py Repoint dead slopsmith URLs -> got-feedback 2026-06-17 11:02:04 +02:00
test_vocal_pitch.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_xp.py Clean release snapshot 2026-06-16 18:47:13 +02:00