mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-09-11 04:44:31 +00:00
byrongamatosandClaude Sonnet 4.6
4bb5d21a40
VERBATIM-MOVE: initScene() (4215-5704), bg-helper functions (5706-6221), and
buildBoard() (6242-6571) extracted from screen.js into a new ES module
src/scene-init.js as createSceneInit({...~200 DI params}) → { initScene,
buildBoard, _bgUnmountStyle, _bcSyncMode }.
All factory-scope variables that other modules read go through getter+setter
pairs (no plain-value shorthands) to avoid the fork-class bug from cut-15.
Local alias pattern applied throughout: const _x = new T.Thing(); setX(_x);
closures use getX() to read current value.
Test retargets: highway_3d_context_loss, fret_spacing, pool_warm,
render_order, score_fx, sustain_bloom, sustain_rail, wide_fov — all updated
to search src/scene-init.js alongside screen.js, and patterns broadened for
DI forms (getRen().domElement, getFretG(), getFretTubeGeo(), etc.).
414/414 tests pass. ESLint: scene-init.js 0 errors, 1 max-lines warning.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW
55 lines
2.9 KiB
JavaScript
55 lines
2.9 KiB
JavaScript
// Pins the chord sustain-length rail indicator in plugins/highway_3d/screen.js
|
|
// (PR #303). The rails are left/right edge plane meshes showing how long a
|
|
// chord is held. A refactor that drops the !isRepeat gate, mixes up the
|
|
// arpeggio/teal color choice, or changes the rail renderOrder would silently
|
|
// regress the indicator (rails on every repeat frame, wrong tint, or rails
|
|
// occluding note gems).
|
|
//
|
|
// Source-level only — same strategy as the other tests/js/ files.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'screen.js');
|
|
const SCENE_INIT_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'scene-init.js'); // h3d-carve-16
|
|
const RENDERER_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'renderer.js');
|
|
|
|
test('sustain rails are gated on multi-note chords with a known box width within AHEAD', () => {
|
|
// Each chord in a sequence (including repeats) draws a rail from its onset
|
|
// to the next chord's onset, chaining together to cover the full handshape
|
|
// duration visually. Single notes have no chord frame to anchor a rail to.
|
|
// h3d-carve-15: sustain-rail block moved to renderer.js
|
|
const rendererSrc = fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
rendererSrc,
|
|
/if\s*\(\s*chShape\.size\s*>\s*1\s*&&\s*chordOpenBoxW\s*!=\s*null\s*&&\s*chDt\s*<\s*AHEAD\s*\)/,
|
|
'sustain-rail block must stay gated on chShape.size > 1, chordOpenBoxW and chDt < AHEAD',
|
|
);
|
|
});
|
|
|
|
test('sustain rails pick arpeggio color for arpeggio frames, teal otherwise', () => {
|
|
// h3d-carve-15: rail color expression moved to renderer.js
|
|
const rendererSrc = fs.readFileSync(RENDERER_JS, 'utf8');
|
|
assert.match(
|
|
rendererSrc,
|
|
/chordHighwayLavenderArpVisual\s*\?\s*ARPEGGIO_RIM_BLUE_HEX\s*:\s*CHORD_BOX_TEAL_HEX/,
|
|
'rail color must select ARPEGGIO_RIM_BLUE_HEX for arpeggio frames and CHORD_BOX_TEAL_HEX for chords',
|
|
);
|
|
});
|
|
|
|
test('sustain-rail pool meshes keep renderOrder 5 so strings (7) stay on top', () => {
|
|
// renderOrder 5 sits below string-line glows (7) so strings render on top
|
|
// of the rail. Chord frame edges are Z-proportional [48,698] and note gems
|
|
// are Z-proportional [50,700], so the flat seed value does not conflict —
|
|
// emitSusStrip() assigns its own Z-proportional RO per segment at draw time.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + fs.readFileSync(SCENE_INIT_JS, 'utf8');
|
|
// h3d-carve-16: DI form uses _pSusRail (local alias); pool first arg may be a getter call
|
|
assert.match(
|
|
src,
|
|
/(?:_p)?SusRail\s*=\s*pool\([\s\S]{0,100}?,\s*\(\)\s*=>\s*\{[\s\S]*?m\.renderOrder\s*=\s*5\s*;[\s\S]*?\}\s*\)/,
|
|
'pSusRail pool must seed meshes with renderOrder = 5',
|
|
);
|
|
});
|