mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-21 20:31:21 +00:00
a883f9213f
The biggest router yet — 12 playlist routes + custom covers — and the first that needs the config-path seam. server.py: 9,302 -> 9,085 (-217). Three causally-linked pieces, all required for playlists: - `config_dir` joins the appstate seam (the plan always put the path constants there; deferred in S3, needed now). It's env-derived, so the ~49 pop-and-reimport fixtures reconfigure it for free — ZERO setattr retargeting. STATIC_DIR/SLOPPAK_CACHE_DIR (patched via setattr) stay in server.py until a router that reads them is extracted, and get retargeted then. - `_clean_str` (pure request-field sanitizer, 14 callers) -> lib/reqfields.py; server.py imports it back. Unblocks wanted/saved/collections/profile/... later. - routers/playlists.py: bodies verbatim, `@app`->`@router`, `meta_db`-> `appstate.meta_db`, `CONFIG_DIR`->`appstate.config_dir`, `_clean_str` from reqfields, `_ART_CACHE_HEADERS` as a local const (art keeps server.py's). The two exclusive cover helpers (_playlist_cover_path/_url) move with it. include_router at the original site; full 143-route table identical to origin/main. One test retarget: test_playlists_api called `server._playlist_cover_path` directly -> now imports it from routers.playlists (reads appstate.config_dir, which the `server` fixture configures). Verified: pyflakes clean; route table identical; pytest 2401 passed (28 in playlists+collections+appstate); packaging guard 51 (auto-picked up reqfields); eslint 0; boot smoke drives create/rename/add-song/cover-upload/serve/delete — the cover writes 1.png under CONFIG_DIR THROUGH appstate.config_dir and serves 200 with an mtime cache-bust token; a wrong-typed name field still 400s via _clean_str; demo untouched. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
178 lines
8.3 KiB
Python
178 lines
8.3 KiB
Python
"""Tests for playlists, Saved-for-Later, and the Continue-Playing endpoint (P16)."""
|
|
|
|
import importlib
|
|
import sys
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
|
|
# Moved to routers/playlists in R3; reads appstate.config_dir, which the
|
|
# `server` fixture configures via CONFIG_DIR before this is called.
|
|
from routers.playlists import _playlist_cover_path
|
|
|
|
|
|
@pytest.fixture()
|
|
def server(tmp_path, monkeypatch, isolate_logging):
|
|
monkeypatch.setenv("CONFIG_DIR", str(tmp_path))
|
|
monkeypatch.setenv("FEEDBACK_SKIP_STARTUP_TASKS", "1")
|
|
sys.modules.pop("server", None)
|
|
srv = importlib.import_module("server")
|
|
try:
|
|
yield srv
|
|
finally:
|
|
conn = getattr(getattr(srv, "meta_db", None), "conn", None)
|
|
if conn is not None:
|
|
getattr(__import__("sys").modules.get("server"), "_join_background_db_threads", lambda: None)()
|
|
conn.close()
|
|
sys.modules.pop("server", None)
|
|
|
|
|
|
@pytest.fixture()
|
|
def client(server):
|
|
return TestClient(server.app)
|
|
|
|
|
|
def test_create_list_rename_delete(client):
|
|
pl = client.post("/api/playlists", json={"name": "Warmups"}).json()
|
|
pid = pl["id"]
|
|
assert pl["name"] == "Warmups" and pl["songs"] == []
|
|
listing = client.get("/api/playlists").json()
|
|
assert any(p["id"] == pid and p["count"] == 0 for p in listing)
|
|
# rename
|
|
r = client.patch(f"/api/playlists/{pid}", json={"name": "Warm Ups"})
|
|
assert r.json()["name"] == "Warm Ups"
|
|
# delete
|
|
assert client.delete(f"/api/playlists/{pid}").json() == {"ok": True}
|
|
assert client.get(f"/api/playlists/{pid}").status_code == 404
|
|
|
|
|
|
def test_create_requires_name(client):
|
|
assert client.post("/api/playlists", json={"name": " "}).status_code == 400
|
|
|
|
|
|
def test_add_remove_reorder_persists(client, server):
|
|
for fn in ("a.archive", "b.archive", "c.archive"):
|
|
server.meta_db.put(fn, 0, 0, {})
|
|
pid = client.post("/api/playlists", json={"name": "Set"}).json()["id"]
|
|
client.post(f"/api/playlists/{pid}/songs", json={"filename": "a.archive"})
|
|
client.post(f"/api/playlists/{pid}/songs", json={"filename": "b.archive"})
|
|
client.post(f"/api/playlists/{pid}/songs", json={"filename": "c.archive"})
|
|
songs = client.get(f"/api/playlists/{pid}").json()["songs"]
|
|
assert [s["filename"] for s in songs] == ["a.archive", "b.archive", "c.archive"]
|
|
# reorder
|
|
client.post(f"/api/playlists/{pid}/reorder", json={"order": ["c.archive", "a.archive", "b.archive"]})
|
|
songs2 = client.get(f"/api/playlists/{pid}").json()["songs"]
|
|
assert [s["filename"] for s in songs2] == ["c.archive", "a.archive", "b.archive"]
|
|
# remove
|
|
client.request("DELETE", f"/api/playlists/{pid}/songs/b.archive")
|
|
songs3 = client.get(f"/api/playlists/{pid}").json()["songs"]
|
|
assert [s["filename"] for s in songs3] == ["c.archive", "a.archive"]
|
|
|
|
|
|
def test_saved_for_later_toggle_and_protection(client):
|
|
# Toggle creates the system playlist on first use.
|
|
assert client.post("/api/saved/toggle", json={"filename": "x.archive"}).json() == {"saved": True}
|
|
assert client.post("/api/saved/toggle", json={"filename": "x.archive"}).json() == {"saved": False}
|
|
saved = next(p for p in client.get("/api/playlists").json() if p["system_key"] == "saved_for_later")
|
|
# Cannot delete or rename the system playlist.
|
|
assert client.delete(f"/api/playlists/{saved['id']}").status_code == 400
|
|
assert client.patch(f"/api/playlists/{saved['id']}", json={"name": "Nope"}).status_code == 400
|
|
|
|
|
|
def test_continue_session(client, server):
|
|
assert client.get("/api/session/continue").json() is None
|
|
for fn in ("one.archive", "two.archive"):
|
|
server.meta_db.put(fn, 0, 0, {})
|
|
client.post("/api/stats", json={"filename": "one.archive", "score": 100, "accuracy": 0.5, "lastPlayPosition": 12.0})
|
|
client.post("/api/stats", json={"filename": "two.archive", "score": 200, "accuracy": 0.7, "lastPlayPosition": 30.0})
|
|
cont = client.get("/api/session/continue").json()
|
|
assert cont["filename"] == "two.archive"
|
|
assert cont["last_position"] == 30.0
|
|
assert "art_url" in cont and "title" in cont
|
|
|
|
|
|
def test_add_song_to_missing_playlist_is_404(client, server):
|
|
# add_playlist_song() must not insert an orphan row for a non-existent
|
|
# playlist (the concurrent-delete TOCTOU); it returns None → handler 404s.
|
|
assert server.meta_db.add_playlist_song(999999, "x.archive") is None
|
|
r = client.post("/api/playlists/999999/songs", json={"filename": "x.archive"})
|
|
assert r.status_code == 404
|
|
|
|
|
|
def test_playlist_hides_dead_songs_when_library_populated(client, server):
|
|
# A playlist song whose file no longer exists is hidden from contents + count
|
|
# (mirrors the stats read-filter), but only while the library is populated.
|
|
db = server.meta_db
|
|
db.put("live.archive", 0, 0, {"title": "Live"})
|
|
pid = client.post("/api/playlists", json={"name": "P"}).json()["id"]
|
|
client.post(f"/api/playlists/{pid}/songs", json={"filename": "live.archive"})
|
|
client.post(f"/api/playlists/{pid}/songs", json={"filename": "ghost.archive"}) # never in songs
|
|
pl = client.get(f"/api/playlists/{pid}").json()
|
|
names = [s["filename"] for s in pl["songs"]]
|
|
assert "live.archive" in names and "ghost.archive" not in names
|
|
assert [p for p in client.get("/api/playlists").json() if p["id"] == pid][0]["count"] == 1
|
|
|
|
|
|
# ── Playlist covers (content-dependent art + custom upload) ──────────────────
|
|
|
|
def _png_b64():
|
|
"""A tiny base64 PNG with the data-URL prefix, like the browser sends."""
|
|
import base64
|
|
import io
|
|
from PIL import Image
|
|
buf = io.BytesIO()
|
|
Image.new("RGB", (4, 4), (200, 30, 60)).save(buf, "PNG")
|
|
return "data:image/png;base64," + base64.b64encode(buf.getvalue()).decode()
|
|
|
|
|
|
def test_list_includes_song_art_urls_for_content_cover(client, server):
|
|
for fn in ("x.archive", "y.archive"):
|
|
server.meta_db.put(fn, 0, 0, {})
|
|
pid = client.post("/api/playlists", json={"name": "Arts"}).json()["id"]
|
|
client.post(f"/api/playlists/{pid}/songs", json={"filename": "x.archive"})
|
|
client.post(f"/api/playlists/{pid}/songs", json={"filename": "y.archive"})
|
|
pl = [p for p in client.get("/api/playlists").json() if p["id"] == pid][0]
|
|
assert pl["art_urls"] == ["/api/song/x.archive/art", "/api/song/y.archive/art"]
|
|
assert pl["cover_url"] is None # no custom cover yet
|
|
|
|
|
|
def test_custom_cover_roundtrip(client):
|
|
pid = client.post("/api/playlists", json={"name": "Cover"}).json()["id"]
|
|
r = client.post(f"/api/playlists/{pid}/cover", json={"image": _png_b64()})
|
|
assert r.status_code == 200 and r.json()["ok"] is True
|
|
assert r.json()["cover_url"].startswith(f"/api/playlists/{pid}/cover")
|
|
# list + detail both report it
|
|
assert [p for p in client.get("/api/playlists").json() if p["id"] == pid][0]["cover_url"]
|
|
assert client.get(f"/api/playlists/{pid}").json()["cover_url"]
|
|
# served as a real PNG
|
|
img = client.get(f"/api/playlists/{pid}/cover")
|
|
assert img.status_code == 200 and img.headers["content-type"] == "image/png"
|
|
assert img.content[:8] == b"\x89PNG\r\n\x1a\n"
|
|
# removed
|
|
assert client.delete(f"/api/playlists/{pid}/cover").json() == {"ok": True}
|
|
assert client.get(f"/api/playlists/{pid}/cover").status_code == 404
|
|
assert client.get(f"/api/playlists/{pid}").json()["cover_url"] is None
|
|
|
|
|
|
def test_cover_rejects_non_image(client):
|
|
pid = client.post("/api/playlists", json={"name": "Bad"}).json()["id"]
|
|
assert client.post(f"/api/playlists/{pid}/cover",
|
|
json={"image": "data:text/plain;base64,bm90IGFuIGltYWdl"}).status_code == 400
|
|
assert client.post(f"/api/playlists/{pid}/cover", json={"image": ""}).status_code == 400
|
|
|
|
|
|
def test_cover_rejects_non_string_image_with_400_not_500(client):
|
|
# A non-string `image` (number / null / object) must be a clean 400, not a
|
|
# 500 from `"," in <non-str>` raising TypeError before the type check.
|
|
pid = client.post("/api/playlists", json={"name": "Typed"}).json()["id"]
|
|
for bad in (123, None, {"x": 1}, ["a"]):
|
|
assert client.post(f"/api/playlists/{pid}/cover", json={"image": bad}).status_code == 400
|
|
|
|
|
|
def test_deleting_playlist_removes_custom_cover(client, server):
|
|
pid = client.post("/api/playlists", json={"name": "Doomed"}).json()["id"]
|
|
client.post(f"/api/playlists/{pid}/cover", json={"image": _png_b64()})
|
|
assert _playlist_cover_path(pid).exists()
|
|
client.delete(f"/api/playlists/{pid}")
|
|
assert not _playlist_cover_path(pid).exists()
|