mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-12 03:41:40 +00:00
Sin
4148b0e72e
Reword comments/docstrings/strings and rename identifiers that referenced the external game and its file formats: - format-id "psarc" -> "archive"; local vars psarc_path -> song_path, psarc_base -> tone_base - lyrics provenance value "sng" -> "notechart" (legacy "sng" still accepted) - highway_3d fret-ghost scope value "rocksmith" -> "chords" (invalid/legacy values fall back to the default, preserving behaviour) - neutralise references in prose, test names/data, .gitattributes and docs No functional change beyond the renamed identifiers; all Python compiles.
45 lines
2.1 KiB
JavaScript
45 lines
2.1 KiB
JavaScript
// Pins the fret-spacing setting in plugins/highway_3d/screen.js (PR #329).
|
|
// The board can render fret columns either Uniform (equal width, the source game
|
|
// Remastered style) or Logarithmic (real instrument geometry), switchable at
|
|
// runtime via window.h3dSetFretSpacing and persisted in localStorage. A
|
|
// refactor that renames the storage key, drops the uniform/log branch in
|
|
// fretX, or stops validating the mode would silently regress the setting.
|
|
//
|
|
// Source-level only — same strategy as the other tests/js/ files.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'screen.js');
|
|
|
|
test('fret-spacing mode is read from the highway_3d.fretSpacing localStorage key', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/_h3dFretUniform\s*=\s*localStorage\.getItem\(\s*'highway_3d\.fretSpacing'\s*\)\s*!==\s*'logarithmic'/,
|
|
'startup must read highway_3d.fretSpacing and treat anything but "logarithmic" as uniform',
|
|
);
|
|
});
|
|
|
|
test('fretX switches between the uniform and logarithmic implementations', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/const\s+fretX\s*=\s*f\s*=>\s*_h3dFretUniform\s*\?\s*_fretXUni\(f\)\s*:\s*_fretXLog\(f\)/,
|
|
'fretX must pick _fretXUni when _h3dFretUniform else _fretXLog',
|
|
);
|
|
});
|
|
|
|
test('h3dSetFretSpacing validates the mode against the two supported values', () => {
|
|
// An unexpected input must not be persisted verbatim — it is coerced to
|
|
// one of 'logarithmic' | 'uniform' before writing to localStorage.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/window\.h3dSetFretSpacing\s*=\s*mode\s*=>\s*\{[\s\S]*?mode\s*===\s*'logarithmic'\s*\?\s*'logarithmic'\s*:\s*'uniform'[\s\S]*?localStorage\.setItem\(\s*'highway_3d\.fretSpacing'/,
|
|
'h3dSetFretSpacing must coerce mode to a supported value before persisting',
|
|
);
|
|
});
|