got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-07-22 04:41:23 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
37aedd4251
feedBack/tests
History
Sin 37aedd4251
Restore GP6/7/8 tremolo picking on import (#572) 
* Map GP7/8 tremolo picking on import

GP7/8 (GPIF) encodes tremolo picking as a beat-level <Tremolo> element,
which the importer ignored — so tremolo was silently dropped on .gp import,
while note vibrato and the GP3-5 path were unaffected. Read the beat-level
<Tremolo> and set the note tremolo flag across the beat, independent of
vibrato (a note can carry both).

Signed-off-by: Sin <deathlysin@outlook.com>

* test: cover GP6/7/8 tremolo-picking import

Extract the beat-level <Tremolo> detection into a pure _beat_has_tremolo
helper (mirroring the tested _note_has_vibrato) so it's unit-testable in
this suite's fixture-free style, then add:

- 4 unit tests on _beat_has_tremolo: direct <Tremolo> child detected
  (rate-agnostic), absent -> False, direct-child-only (nested Tremolo
  ignored), independent of the VibratoWTremBar whammy property.
- 1 end-to-end test driving convert_file via a crafted GPIF (monkeypatched
  _load_gpif): a tremolo-picked beat's note serializes tremolo="1" while a
  plain beat stays "0".

Both the detection and integration tests fail without the fix; full GP
suite 238 passed. Refactor is behavior-identical.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Signed-off-by: Sin <deathlysin@outlook.com>
Co-authored-by: Byron Gamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 21:14:43 +02:00
..
browser Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
fixtures Remove unused binary test fixture; correct stale scan comments 2026-06-16 18:49:40 +01:00
js fix(highway): stop stale viz frame bleeding through after switching visualizations (#565) 2026-06-22 13:27:21 +02:00
plugins Clean release snapshot 2026-06-16 18:47:13 +02:00
__init__.py Clean release snapshot 2026-06-16 18:47:13 +02:00
conftest.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_audio_bundled.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_audio_effect_mappings.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_audio_local_path.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_audio.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_builtin_diagnostic_seed.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_correlation_id.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_demo_mode.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_diagnostics_bundle.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_diagnostics_hardware.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_diagnostics_redact.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_drums_lib.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_feedpak_extension.py feat: save as .feedpak; discover and load both .feedpak and .sloppak (#553) 2026-06-22 20:47:56 +02:00
test_gp2midi.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_gp2notation.py feat(core): adopt feedpak_version — read on load + stamp on manifest writes (spec §4) (#530) 2026-06-20 21:59:04 +02:00
test_gp2rs_drums.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_gp2rs_gpx.py Restore GP6/7/8 tremolo picking on import (#572) 2026-06-22 21:14:43 +02:00
test_gp2rs.py feat(core): teaching marks fg/ch/sd — wire + GP import + sd derivation (§6.2.2) (#536) 2026-06-21 07:57:50 +02:00
test_gp_audio_sync.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_highway_3d_routes.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_highway_ws_notation.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_library_filters.py Improve wording in terminology cleanup 2026-06-16 19:43:45 +01:00
test_library_providers.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_lift_keys_notation.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_logging_setup.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_loose_traversal.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_loosefolder.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_lyrics_transcribe.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_midi_import_drums.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_midi_import.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_minigames_routes.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_notation_lib.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_notation_lift.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_notation_to_notes.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_parse_arrangement.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_playlists_api.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_plugin_manifest_contract.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_plugin_runtime_idempotence.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_plugins.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_profile_api.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_profile_domains.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_progression_api.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_progression.py Purge external-format terminology from code, tests and docs 2026-06-16 19:36:53 +01:00
test_safepath.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_settings_api.py Make the library loader sloppak/loose-only 2026-06-16 19:09:53 +01:00
test_settings_export.py Make the library loader sloppak/loose-only 2026-06-16 19:09:53 +01:00
test_settings_instrument.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_cent_offset.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_cover_art.py Fix slow library cover loading: serve sloppak art without unpacking + revalidated caching (#534) 2026-06-20 00:22:43 +02:00
test_sloppak_drumtab_load.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_feedpak_version.py feat(core): adopt feedpak_version — read on load + stamp on manifest writes (spec §4) (#530) 2026-06-20 21:59:04 +02:00
test_sloppak_file_traversal.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_keys_load.py feat(core): consume keys.json — song-level key/scale track (loader + WS) (#528) 2026-06-20 21:23:48 +02:00
test_sloppak_notation_load.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_sloppak_song_timeline_load.py feat(core): consume song_timeline tempos + time_signatures + per-chart tempos (feedpak 1.2.0) (#529) 2026-06-20 21:35:07 +02:00
test_song_score.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_song_stats_api.py fix(stats): decode song_stats filenames so "Your best scores" reads real data (#564) 2026-06-22 12:29:54 +02:00
test_song.py fix(song): sanitize caged + guideTones on emit, not just decode (#544 follow-up) (#547) 2026-06-21 12:04:08 +02:00
test_songmeta.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_startup_status.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_tailwind_rebuild.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_tones.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_tunings.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_version_endpoint.py Repoint dead slopsmith URLs -> got-feedback 2026-06-17 11:02:04 +02:00
test_vocal_pitch.py Clean release snapshot 2026-06-16 18:47:13 +02:00
test_xp.py Clean release snapshot 2026-06-16 18:47:13 +02:00