mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
2281cac438
* refactor(highway): lift 79 per-instance closure vars into `hwState` (R3c H lift) Collapses createHighway()'s 79 mutable closure `let`s into one per-instance `hwState` object. Scope-resolved rewrite via acorn + eslint-scope: 1059 edits (1057 references + 79 defs - the deleted `let canvas, ctx, ws`), with the four names shadowed in inner scopes (chartTime/ctx/notes/chordTemplates) resolved correctly so only closure-bound refs move. Enables the later module split: extracted renderer/ws modules close over `hwState` as a factory arg, so multi-panel plugins (highway_3d, note_detect, splitscreen) don't share one highway's state. Container is `hwState`, NOT `H` — `H` is already canvas height (70 uses). The frame-time gate caught that collision instantly (0 draws, `H._drawHooks is not iterable` in the shared draw-hook path). PERF (the whole risk): identical to the pre-lift baseline. Draw p50 2.1-2.2 ms, p95 2.7-3.0 ms (pre-lift 2.7-3.2), measured on the Arcturus feedpak, headless. Each closure-slot read became a `hwState.<slot>` monomorphic property load; the hot loop pays nothing. On-device: Byron confirmed the 2D highway plays smoothly. Tests: the ~30 highway JS suites brace-extract functions/patterns from the source; their state references + the monotonic-clock vm sandbox now use `hwState.<slot>` (the const _CHART_MAX_INTERP_MS etc. stay top-level, not lifted). node --test: 1030/1030 green. Two self-inflicted over-replacements caught and reverted (`_lefty` is a prefix of the 3D-local `_leftyCached`; `STRING_COLORS` a suffix of `DEFAULT_STRING_COLORS`) — substring replaces on the brace-extract regexes need word care. Transformer saved at ~/.local/share/feedback-editor/highway-h-lift.mjs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(highway): pin the setNoteStateProvider assertion to hwState._noteStateProvider (CodeRabbit) The [^}]* form matched an unqualified _noteStateProvider =, so a regression to closure-level state could still pass. Require the hwState-qualified assignment. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
50 lines
1.9 KiB
JavaScript
50 lines
1.9 KiB
JavaScript
// Source-level tests for highway.getPhrases() and getMastery() public API getters.
|
|
// The createHighway closure is too heavy for a Node sandbox, so tests inspect
|
|
// source text to lock in correct wiring — same pattern as highway_filtered_notes.test.js.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const highwayJs = path.join(__dirname, '..', '..', 'static', 'highway.js');
|
|
|
|
test('highway public API exposes getPhrases', () => {
|
|
const src = fs.readFileSync(highwayJs, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/getPhrases\s*\(\s*\)\s*\{[^}]*_phrases/,
|
|
'getPhrases must reference _phrases',
|
|
);
|
|
});
|
|
|
|
test('getPhrases returns null when _phrases is falsy or empty', () => {
|
|
const src = fs.readFileSync(highwayJs, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/getPhrases\s*\(\s*\)\s*\{[^}]*!\s*hwState\._phrases[^}]*return null/,
|
|
'getPhrases must return null when no phrase data is available',
|
|
);
|
|
});
|
|
|
|
test('getPhrases maps phrases to index, start_time, end_time, max_difficulty', () => {
|
|
const src = fs.readFileSync(highwayJs, 'utf8');
|
|
// Match all four fields within a reasonable window after getPhrases
|
|
const match = src.match(/getPhrases\s*\(\s*\)([\s\S]{0,400})/);
|
|
assert.ok(match, 'getPhrases not found in highway.js');
|
|
const block = match[1];
|
|
assert.ok(block.includes('start_time'), 'getPhrases must expose start_time');
|
|
assert.ok(block.includes('end_time'), 'getPhrases must expose end_time');
|
|
assert.ok(block.includes('max_difficulty'), 'getPhrases must expose max_difficulty');
|
|
assert.ok(block.includes('index'), 'getPhrases must expose index');
|
|
});
|
|
|
|
test('highway public API exposes getMastery', () => {
|
|
const src = fs.readFileSync(highwayJs, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/getMastery\s*\(\s*\)\s*\{[^}]*_mastery/,
|
|
'getMastery must reference _mastery',
|
|
);
|
|
});
|