mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 19:29:33 +00:00
6 functions, 53 lines. highway.js 4,158 -> 4,105. NOT ONE CALL SITE CHANGES. project, roundRect, bnvNormalizedPoints, teachingFingerLabel, teachingDegreeLabel, chordHarmonyLabels — the shared primitives every drawing function leans on. ━━━ PURITY IS THE WHOLE POINT OF THIS SLICE ━━━ Every one of these is a pure function of its arguments. None touches hwState. None closes over the canvas context — roundRect() already took `ctx` explicitly, and the rest need nothing but numbers. project() reads only the module-level constants from #914. That matters because createHighway() is a FACTORY: a plugin can build a second highway for its own panel, so anything holding per-instance state must be PASSED hwState rather than importing it, or two panels silently share one clock and palette. These six hold no state at all, so they move VERBATIM — the module boundary is invisible to every caller. The asserts are mechanical and in the extractor: it REFUSES to move a function whose body mentions hwState, or that references `ctx` without taking it as a parameter. Purity is checked, not assumed. ━━━ WHAT IS DELIBERATELY LEFT BEHIND ━━━ The four primitives that DO need hwState — fretX, fillTextReadable, _noteState, _paintGemGlow — stay in the factory for now. They need an explicit hwState parameter threaded through 53 call sites, which is a real behavioural change and belongs in its own commit rather than smuggled in beside a provably-identical move. Separating the provable from the risky is the whole discipline of this epic. TESTS. Three harnesses brace-match these functions out of the source and run them in a sandbox; they now read static/js/highway-geometry.js. `export function x` still contains `function x`, so the extractor needed no change — only the path. VERIFIED. A/B against origin/main: 15 probes IDENTICAL, zero page errors. PERF GATE PASSES AT 1.91ms against its 12ms budget — and this is the one that could plausibly have cost something: project() runs for every visible note on every frame and is now a CROSS-MODULE call. It costs nothing measurable. That is the answer #910 was built to give. node 1045, pytest 2416, ESLint 0, Codex 0. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
93 lines
4.3 KiB
JavaScript
93 lines
4.3 KiB
JavaScript
// Behavioural tests for the per-note bend-curve (bnv, §6.2.1) render helpers:
|
|
// `bnvNormalizedPoints` (static/highway.js, 2D glyph) and `bnvSampleAt`
|
|
// (plugins/highway_3d/screen.js, 3D Y gesture). Both are pure, so we extract
|
|
// the function source by brace-matching and eval it in isolation.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
function extractFn(src, name) {
|
|
const start = src.indexOf('function ' + name);
|
|
assert.ok(start >= 0, `function ${name} must exist`);
|
|
const open = src.indexOf('{', start);
|
|
let depth = 0;
|
|
for (let i = open; i < src.length; i++) {
|
|
if (src[i] === '{') depth++;
|
|
else if (src[i] === '}' && --depth === 0) return src.slice(start, i + 1);
|
|
}
|
|
throw new Error(`unbalanced braces extracting ${name}`);
|
|
}
|
|
|
|
function loadFn(file, name) {
|
|
const src = fs.readFileSync(path.join(__dirname, '..', '..', file), 'utf8');
|
|
return new Function('"use strict";' + extractFn(src, name) + `\nreturn ${name};`)();
|
|
}
|
|
|
|
// R3c: the PURE geometry/label primitives were carved out of highway.js into
|
|
// static/js/highway-geometry.js. Same bodies, byte-for-byte — only the file moved.
|
|
const bnvNormalizedPoints = loadFn('static/js/highway-geometry.js', 'bnvNormalizedPoints');
|
|
const bnvSampleAt = loadFn('plugins/highway_3d/screen.js', 'bnvSampleAt');
|
|
|
|
// ── bnvNormalizedPoints (2D) ─────────────────────────────────────────────────
|
|
|
|
test('bnvNormalizedPoints normalizes t to 0..1 across the curve span (no sus)', () => {
|
|
const pts = bnvNormalizedPoints([
|
|
{ t: 0.5, v: 0 }, { t: 1.0, v: 2 }, { t: 1.5, v: 0 }]);
|
|
assert.deepEqual(pts, [
|
|
{ x: 0, v: 0 }, { x: 0.5, v: 2 }, { x: 1, v: 0 }]);
|
|
});
|
|
|
|
test('bnvNormalizedPoints maps t over the note sus span when given', () => {
|
|
// A bend that completes at t=0.4 of a 0.5s note draws to x=0.8, not x=1 —
|
|
// i.e. it stops short of the glyph's right edge (correct timing shape).
|
|
assert.deepEqual(
|
|
bnvNormalizedPoints([{ t: 0, v: 0 }, { t: 0.25, v: 1 }, { t: 0.4, v: 0 }], 0.5),
|
|
[{ x: 0, v: 0 }, { x: 0.5, v: 1 }, { x: 0.8, v: 0 }]);
|
|
// Points beyond sus clamp to 1; sus<=0 falls back to curve-span mapping.
|
|
assert.deepEqual(bnvNormalizedPoints([{ t: 0, v: 0 }, { t: 1, v: 2 }], 0.5),
|
|
[{ x: 0, v: 0 }, { x: 1, v: 2 }]);
|
|
assert.deepEqual(bnvNormalizedPoints([{ t: 0, v: 0 }, { t: 1, v: 2 }], 0),
|
|
[{ x: 0, v: 0 }, { x: 1, v: 2 }]);
|
|
});
|
|
|
|
test('bnvNormalizedPoints handles degenerate/empty input', () => {
|
|
assert.deepEqual(bnvNormalizedPoints([]), []);
|
|
assert.deepEqual(bnvNormalizedPoints(null), []);
|
|
// All-same-t span collapses x to 0 (no divide-by-zero).
|
|
assert.deepEqual(bnvNormalizedPoints([{ t: 1, v: 1 }, { t: 1, v: 2 }]),
|
|
[{ x: 0, v: 1 }, { x: 0, v: 2 }]);
|
|
});
|
|
|
|
// ── bnvSampleAt (3D) ─────────────────────────────────────────────────────────
|
|
|
|
test('bnvSampleAt linearly interpolates between points', () => {
|
|
const bnv = [{ t: 0, v: 0 }, { t: 1, v: 2 }];
|
|
assert.equal(bnvSampleAt(bnv, 0.5), 1); // midpoint
|
|
assert.equal(bnvSampleAt(bnv, 0.25), 0.5);
|
|
});
|
|
|
|
test('bnvSampleAt clamps to the endpoints', () => {
|
|
const bnv = [{ t: 0.2, v: 1 }, { t: 0.8, v: 3 }];
|
|
assert.equal(bnvSampleAt(bnv, 0), 1); // before first
|
|
assert.equal(bnvSampleAt(bnv, 5), 3); // after last
|
|
});
|
|
|
|
test('bnvSampleAt traces a round-trip curve up then back down', () => {
|
|
const bnv = [{ t: 0, v: 0 }, { t: 0.5, v: 2 }, { t: 1, v: 0 }];
|
|
assert.equal(bnvSampleAt(bnv, 0.25), 1); // rising
|
|
assert.equal(bnvSampleAt(bnv, 0.5), 2); // peak
|
|
assert.equal(bnvSampleAt(bnv, 0.75), 1); // falling
|
|
});
|
|
|
|
test('bnvSampleAt returns 0 for an empty/invalid curve', () => {
|
|
assert.equal(bnvSampleAt([], 0.5), 0);
|
|
assert.equal(bnvSampleAt(null, 0.5), 0);
|
|
});
|
|
|
|
test('bnvSampleAt tolerates a zero-width segment (duplicate t)', () => {
|
|
const bnv = [{ t: 0, v: 0 }, { t: 0.5, v: 1 }, { t: 0.5, v: 2 }, { t: 1, v: 2 }];
|
|
assert.equal(bnvSampleAt(bnv, 0.5), 1); // first matching segment wins
|
|
});
|