mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
fe8d30ce3e
window.h3dSetFretSpacing was the only 3D-highway setting that applied via location.reload(). The SPA boots with #home as the active screen and has no restore-last-screen mechanism, so the reload ejected the user from Settings onto the home screen. Apply it live like every other 3D-highway setting: rebind the module-scope _h3dFretUniform flag (so panels mounted later this session pick up the new mode), recompute the two fretX-derived scalars baked at init (_fretLabelScaleRefW, FRET_WIDTH_MID), and broadcast a 'fretSpacing' change over the existing _bgEmitChange pub-sub so every mounted panel rebuilds its board via buildBoard(). Per-frame note geometry already reads fretX live. Settings copy updated (no longer reloads) and tests/js pin the no-reload / live-rebuild behavior. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
75 lines
3.4 KiB
JavaScript
75 lines
3.4 KiB
JavaScript
// Pins the fret-spacing setting in plugins/highway_3d/screen.js (PR #329).
|
|
// The board can render fret columns either Uniform (equal width, the chart
|
|
// Remastered style) or Logarithmic (real instrument geometry), switchable at
|
|
// runtime via window.h3dSetFretSpacing and persisted in localStorage. A
|
|
// refactor that renames the storage key, drops the uniform/log branch in
|
|
// fretX, or stops validating the mode would silently regress the setting.
|
|
//
|
|
// Source-level only — same strategy as the other tests/js/ files.
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'screen.js');
|
|
|
|
test('fret-spacing mode is read from the highway_3d.fretSpacing localStorage key', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/_h3dFretUniform\s*=\s*localStorage\.getItem\(\s*'highway_3d\.fretSpacing'\s*\)\s*!==\s*'logarithmic'/,
|
|
'startup must read highway_3d.fretSpacing and treat anything but "logarithmic" as uniform',
|
|
);
|
|
});
|
|
|
|
test('fretX switches between the uniform and logarithmic implementations', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/const\s+fretX\s*=\s*f\s*=>\s*_h3dFretUniform\s*\?\s*_fretXUni\(f\)\s*:\s*_fretXLog\(f\)/,
|
|
'fretX must pick _fretXUni when _h3dFretUniform else _fretXLog',
|
|
);
|
|
});
|
|
|
|
test('h3dSetFretSpacing validates the mode against the two supported values', () => {
|
|
// An unexpected input must not be persisted verbatim — it is coerced to
|
|
// one of 'logarithmic' | 'uniform' before writing to localStorage.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/window\.h3dSetFretSpacing\s*=\s*mode\s*=>\s*\{[\s\S]*?mode\s*===\s*'logarithmic'\s*\?\s*'logarithmic'\s*:\s*'uniform'[\s\S]*?localStorage\.setItem\(\s*'highway_3d\.fretSpacing'/,
|
|
'h3dSetFretSpacing must coerce mode to a supported value before persisting',
|
|
);
|
|
});
|
|
|
|
test('h3dSetFretSpacing applies the change live, not via a page reload', () => {
|
|
// A reload reboots the SPA to the home screen, ejecting the user from
|
|
// Settings. The setter must instead rebind the spacing flag and broadcast
|
|
// a 'fretSpacing' change so mounted panels rebuild in place — same path as
|
|
// every other 3D-highway setting. Reintroducing location.reload() here is
|
|
// the regression this guards against.
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
|
const setter = src.match(/window\.h3dSetFretSpacing\s*=\s*mode\s*=>\s*\{[\s\S]*?\n \};/);
|
|
assert.ok(setter, 'h3dSetFretSpacing assignment must be present');
|
|
assert.doesNotMatch(
|
|
setter[0],
|
|
/location\.reload/,
|
|
'h3dSetFretSpacing must not reload the page (it ejects the user from Settings)',
|
|
);
|
|
assert.match(
|
|
setter[0],
|
|
/_bgEmitChange\(\s*'fretSpacing'\s*\)/,
|
|
'h3dSetFretSpacing must broadcast a live fretSpacing change',
|
|
);
|
|
});
|
|
|
|
test('the fretSpacing change rebuilds a mounted board live', () => {
|
|
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
|
assert.match(
|
|
src,
|
|
/changedKey\s*===\s*'fretSpacing'[\s\S]*?if\s*\(fretG\)\s*buildBoard\(\)/,
|
|
'the panel bg listener must rebuild the board when fretSpacing changes',
|
|
);
|
|
});
|