mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-07-22 21:01:40 +00:00
270cb39f41
Some checks are pending
ship-ci / ci (push) Waiting to run
* fix(settings): enable Linux nightly AppImage auto-update in System settings
Fixes the Settings → System "App updates" panel so it actually works on
Linux, and adds Nightly as a selectable channel — previously missing
entirely, so Linux self-update couldn't be reached from this UI at all.
- The channel dropdown no longer gets permanently disabled the moment
the desktop bridge reports 'unsupported', which is the normal state
whenever the channel isn't Nightly on Linux. It stays enabled so the
user can switch to Nightly, the only way out of that state.
- Shows live download progress ("Downloading update… N%") and an
explicit button state machine (Check → grayed out while busy →
Restart now once staged), instead of a frozen "Checking…" during the
~1.5GB background download.
- Renders every status update from the triggering action's own return
value (checkNow()/setChannel()'s result) rather than a separate
follow-up getStatus() call, which can race against other state
changes and show a stale result even after a real success.
- setupAppUpdates() no longer re-syncs the channel to the backend on
every Settings-panel re-render — only once per page load — so a
redundant sync can no longer stomp an in-flight download's state.
- Routes update-flow events into the existing diagnostics.js
console-capture + contribute() snapshot API, so the user's existing
"Export Diagnostics" button now captures the full update decision
trace end to end — no new UI or log file. This diagnostic tracing is
what actually root-caused the bugs above, from real on-device
captures rather than guesswork.
Companion PR in feedBack-desktop (the underlying update engine).
Verified end-to-end on a Steam Deck: channel switch → check → live
download progress → restart button → relaunch onto the new build,
confirmed via a real Export Diagnostics capture showing a clean,
fully-accounted-for trace.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* refactor(settings): extract + unit-test the app-update status view; dedupe diag log
- Extract the status→UI state machine from renderFrom into a pure, exported
_appUpdateStatusView() (DOM-free) and cover it with tests/js — settings.js's
large module graph made importing it for a full harness impractical, so the
pure function is the testable seam. Behavior-preserving; renderFrom applies
the returned shape to the DOM exactly as before.
- Dedupe the [update-diag] renderFrom console line so the ~1.5s download poll
no longer floods the diagnostics ring buffer with byte-identical entries;
every real state/percent change still logs, and the structured contribute()
snapshot stays unconditional.
Left the 'audio_engine' diagnostics key as-is: the server export filters
client contributions to loaded plugin ids (diagnostics_bundle.py path-traversal
guard), so a dedicated key would be silently dropped from the bundle.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Byron Gamatos <xasiklas@gmail.com>
---------
Signed-off-by: Byron Gamatos <xasiklas@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Byron Gamatos <xasiklas@gmail.com>
34 lines
1.7 KiB
Bash
Executable File
34 lines
1.7 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Regenerate static/tailwind.min.css from the project's content globs.
|
|
# This is a maintainer task — the generated CSS is committed, so end
|
|
# users / Docker / desktop builds never run this. Required when adding
|
|
# new Tailwind utility classes that aren't yet present in committed
|
|
# source.
|
|
#
|
|
# Pin to Tailwind 3.x so the input/config syntax matches what was
|
|
# already shipped via the Play CDN (Tailwind 4 has breaking changes).
|
|
#
|
|
# Run this from a checkout with NO untracked plugin directories present (a
|
|
# `git worktree add --detach` of this branch is the safest way). The content
|
|
# glob (tailwind.config.js) scans `./plugins/**` on disk regardless of
|
|
# .gitignore — a dev machine with private/out-of-tree plugins checked out
|
|
# locally (e.g. audio_engine, plugin_manager) will silently bake their classes
|
|
# into the committed CSS, which CI's clean checkout can never reproduce and
|
|
# will permanently fail the tailwind-fresh gate.
|
|
set -euo pipefail
|
|
cd "$(dirname "$0")/.."
|
|
# Byte-stable rebuilds require the exact same resolved dependency tree, not
|
|
# just the same top-level tailwindcss version: `npx -y tailwindcss@x.y.z`
|
|
# installs into a scratch npx cache and lets npm re-resolve transitive deps
|
|
# (postcss, cssnano, autoprefixer) to whatever's current on the registry at
|
|
# invocation time — those drift independently of the pinned version and
|
|
# silently produced non-reproducible output between two machines. tailwindcss
|
|
# is now a pinned devDependency (package.json/package-lock.json); `npm ci`
|
|
# before this script (both here and in CI) is what actually makes the output
|
|
# reproducible.
|
|
exec npx tailwindcss \
|
|
-c tailwind.config.js \
|
|
-i static/_tailwind.src.css \
|
|
-o static/tailwind.min.css \
|
|
--minify
|