3 people 115c3529e9 fix(midi): guard non-positive division in the legacy inline tempo path (#805) ...

convert_midi_track_to_keys_wire builds its own inline tempo map and
divides by the raw midi.ticks_per_beat at two sites (the tempo-table
precompute and the tick_to_seconds closure). A malformed header with
division == 0 raised ZeroDivisionError, and an SMPTE division (which
mido returns as a NEGATIVE signed short) produced negative/garbage
note times.

Guard the divisor with `ticks_per_beat if ticks_per_beat > 0 else 480`
so both the zero and negative cases fall back to the SMF default. The
`> 0` form (not `or 480`) is required because a negative value is
truthy and would slip past `or`. Positive-division behavior is
unchanged.

Follow-up to #796, which fixed the same class of bug in the newer
convert_midi_tempo_map / _build_tick_to_seconds path.

Adds two focused tests: division == 0 no longer crashes and emits a
non-negative time, and a negative/SMPTE division yields sane
non-negative times.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-07 10:27:45 +02:00

..

browser

feat(v3): DOM-virtualize the Songs grid (#636 item 3 stage 2) (#643)

2026-06-29 12:26:29 +02:00

fixtures

Remove unused binary test fixture; correct stale scan comments

2026-06-16 18:49:40 +01:00

js

feat(v3): choose handedness in the instrument selector + onboarding (give lefties a break) (#793)

2026-07-05 23:50:30 +02:00

plugins

fix(tuner): anchor injectPlayerButton to a direct-child button (feedBack#800)

2026-07-07 09:54:06 +02:00

__init__.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

conftest.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_acoustid_match.py

feat(enrichment): AcoustID audio-fingerprint identification (opt-in) (#759)

2026-07-05 00:17:43 +02:00

test_albums_view.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_art_candidates.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_art_layer.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_artist_alias.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_artist_page.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_artist_sort_title_order.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_audio_bundled.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_audio_effect_mappings.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_audio_local_path.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_audio.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_batch_user_meta.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_builtin_diagnostic_seed.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_builtin_starter_seed.py

feat(library): add Star-Spangled Banner + Ode to Joy starter content (#744)

2026-07-03 22:58:39 +02:00

test_collections_api.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_context_menu_api.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_correlation_id.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_curated_album.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_demo_mode.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_diagnostics_bundle.py

fix(tests): isolate plugin routes modules + redact .feedpak filenames (#736)

2026-07-03 13:01:07 +02:00

test_diagnostics_hardware.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_diagnostics_redact.py

fix(tests): isolate plugin routes modules + redact .feedpak filenames (#736)

2026-07-03 13:01:07 +02:00

test_dlc_junction.py

fix(library): serve art/load for songs mounted through a library junction (#766)

2026-07-05 00:15:50 +02:00

test_drums_lib.py

Purge external-format terminology from code, tests and docs

2026-06-16 19:36:53 +01:00

test_enrichment_plumbing.py

feat(v3 library): "Refresh Metadata" button + per-view re-match + filename-artist seed (#764)

2026-07-05 00:18:18 +02:00

test_env_compat.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_feedpak_extension.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_field_overrides.py

feat(v3 library): batch→popup handoff + English-base romaji (metadata-curation capstone) (#782)

2026-07-05 23:35:58 +02:00

test_gap_fill.py

feat(v3 library): "Fix metadata" popup — per-song override + lock, cover picker, MusicBrainz + AcoustID (#777)

2026-07-05 21:09:38 +02:00

test_gp2midi.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_gp2notation.py

fix: correctly import and notate multi-staff (piano/keys) tracks from GP8 (#692)

2026-07-02 08:40:20 +02:00

test_gp2rs_drums.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_gp2rs_gpx.py

fix(gpx): clamp partial final BCFS sector so GP6 .gpx import works (#749)

2026-07-05 00:20:31 +02:00

test_gp2rs.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_gp_audio_sync.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_gp_autosync_warp.py

feat(gp_autosync): piecewise time-warp helpers + refine_sync onset pass (#787)

2026-07-05 20:08:19 +02:00

test_group_filter_law.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_highway_3d_routes.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_highway_ws_authors.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_highway_ws_instrument_routing.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_highway_ws_notation.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_library_filters.py

feat(v3 library): persistent "no match" badge + Unmatched quick filter (#781)

2026-07-05 21:00:30 +02:00

test_library_keyset.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_library_providers.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_lift_keys_notation.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_logging_setup.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_loose_traversal.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_loosefolder.py

Purge external-format terminology from code, tests and docs

2026-06-16 19:36:53 +01:00

test_lyrics_transcribe.py

Purge external-format terminology from code, tests and docs

2026-06-16 19:36:53 +01:00

test_mb_enrichment.py

feat(v3 library): "Fix metadata" popup — per-song override + lock, cover picker, MusicBrainz + AcoustID (#777)

2026-07-05 21:09:38 +02:00

test_mb_match.py

feat(enrichment): alias-aware scoring — auto-confirm non-Latin-primary artists (#772)

2026-07-05 01:11:38 +02:00

test_midi_import_drums.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_midi_import.py

fix(midi): guard non-positive division in the legacy inline tempo path (#805)

2026-07-07 10:27:45 +02:00

test_midi_tempo_map.py

feat(midi): convert_midi_tempo_map — extract tempos, time signatures, beat grid (#796)

2026-07-07 10:27:17 +02:00

test_minigames_routes.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_notation_lib.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_notation_lift.py

fix: correctly import and notate multi-staff (piano/keys) tracks from GP8 (#692)

2026-07-02 08:40:20 +02:00

test_notation_to_notes.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_parse_arrangement.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_playlists_api.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_plugin_manifest_contract.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_plugin_runtime_idempotence.py

fix(plugins): don't treat transient absence from /api/plugins as uninstall (#741)

2026-07-03 14:45:30 +02:00

test_plugins.py

feat(plugins): full-screen (immersive) plugin screens via manifest opt-in (#590)

2026-06-25 00:02:16 +02:00

test_practice_suggestions.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_profile_api.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_profile_domains.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_progression_api.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_progression.py

Purge external-format terminology from code, tests and docs

2026-06-16 19:36:53 +01:00

test_safepath.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_scraper_options.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_settings_api.py

fix(settings): don't let a stale DLC path block saving the Demucs server address (#795)

2026-07-06 20:35:51 +02:00

test_settings_export_library_db.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_settings_export.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_settings_instrument.py

settings: add host instrument profiles (#753)

2026-07-05 00:16:42 +02:00

test_sloppak_cent_offset.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_sloppak_cover_art.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_sloppak_drumtab_load.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_sloppak_feedpak_version.py

feat(core): adopt feedpak_version — read on load + stamp on manifest writes (spec §4) (#530)

2026-06-20 21:59:04 +02:00

test_sloppak_file_traversal.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_sloppak_jsonc_load.py

feat(core): read .jsonc data files (strip C-style comments) (feedpak-spec §8)

2026-06-20 14:10:04 -07:00

test_sloppak_keys_load.py

feat(core): consume keys.json — song-level key/scale track (loader + WS) (#528)

2026-06-20 21:23:48 +02:00

test_sloppak_notation_load.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_sloppak_original_audio_load.py

feat(sloppak): expose full-mix original_audio alongside stems (#583)

2026-06-23 18:05:45 +02:00

test_sloppak_song_timeline_load.py

feat(core): consume song_timeline tempos + time_signatures + per-chart tempos (feedpak 1.2.0) (#529)

2026-06-20 21:35:07 +02:00

test_song_score.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_song_stats_api.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_song_user_meta.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_song.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_songmeta.py

fix: Edit Metadata persists into .feedpak files (suffix gate predated the rename) (#725)

2026-07-02 20:51:57 +02:00

test_starter_suggestions.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_startup_status.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_tailwind_rebuild.py

rename: slopsmith → feedBack, byron → got-feedBack (#537)

2026-06-23 11:03:01 +02:00

test_tones.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_tunings.py

settings: add host instrument profiles (#753)

2026-07-05 00:16:42 +02:00

test_version_endpoint.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_vocal_pitch.py

Clean release snapshot

2026-06-16 18:47:13 +02:00

test_wanted_api.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_work_charts_api.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_work_grouping.py

fix(tests): join background scan/enrich workers before closing the DB (#735)

2026-07-03 12:15:43 +02:00

test_xp.py

Clean release snapshot

2026-06-16 18:47:13 +02:00