mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
Kris AndersonandClaude Opus 4.8
0d4d8229c7
Three review findings on the per-panel camera work: - highway_3d: _bgPanelKey() resolved splitscreen via window.feedBackSplitscreen only, while _freeCamFor() uses the feedBackSplitscreen||slopsmithSplitscreen alias it claims to "mirror". If the rename lands, per-panel background settings would silently stop being per-panel while the camera stayed per-panel. Resolve the alias the same way in _bgPanelKey. - drum_highway_3d: applyCamera()'s "before first positionCamera()" guard tested `_camBaseH == null`, but _camBaseH/_camBaseD were initialized to 0, so the guard never fired (and could apply a base-0 pose for a frame). Initialize to null. - keys + drum: the PR claimed the Camera Director resolver was unit-checked, but nothing exercised it. Extract the resolver into pure, exported helpers (_resolveFreeCam + _ssApi), delegate the per-instance _freeCamFor to them, and add tests/camera_bridge.test.js covering per-panel select, global fallback, null-when-absent, throw-safety, and the slopsmith-alias resolution. Drum 15→21, keys 50→56, all pass; behavior unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Kris Anderson <topkoa@gmail.com>
69 lines
2.9 KiB
JavaScript
69 lines
2.9 KiB
JavaScript
// Camera Director bridge resolver tests: per-panel select, global fallback,
|
|
// null-when-absent, throw-safety, and the splitscreen global-name alias. Loads
|
|
// screen.js in a bare vm window and exercises the __test exports (no DOM/WebGL).
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const vm = require('node:vm');
|
|
|
|
function load() {
|
|
const window = {
|
|
console,
|
|
location: { protocol: 'http:', host: 'localhost' },
|
|
slopsmith: {},
|
|
};
|
|
window.window = window;
|
|
window.globalThis = window;
|
|
const context = vm.createContext(window);
|
|
const src = fs.readFileSync(path.join(__dirname, '..', 'screen.js'), 'utf8');
|
|
vm.runInContext(src, context, { filename: 'screen.js' });
|
|
return { window, __test: window.slopsmithViz_keys_highway_3d.__test };
|
|
}
|
|
|
|
test('_resolveFreeCam: per-panel camera under splitscreen', () => {
|
|
const { __test } = load();
|
|
const c0 = {}, c1 = {};
|
|
const ss = { panelIndexFor: (c) => (c === c0 ? 0 : 1) };
|
|
const map = { 0: { id: 'p0' }, 1: { id: 'p1' } };
|
|
assert.equal(__test._resolveFreeCam(c0, ss, map, { id: 'g' }).id, 'p0');
|
|
assert.equal(__test._resolveFreeCam(c1, ss, map, { id: 'g' }).id, 'p1');
|
|
});
|
|
|
|
test('_resolveFreeCam: falls back to global when there is no panel map', () => {
|
|
const { __test } = load();
|
|
const g = { id: 'global' };
|
|
assert.equal(__test._resolveFreeCam({}, { panelIndexFor: () => 0 }, null, g), g);
|
|
});
|
|
|
|
test('_resolveFreeCam: falls back to global when the panel has no map entry', () => {
|
|
const { __test } = load();
|
|
const g = { id: 'global' };
|
|
const ss = { panelIndexFor: () => 3 }; // index 3 absent from map
|
|
assert.equal(__test._resolveFreeCam({}, ss, { 0: {} }, g), g);
|
|
});
|
|
|
|
test('_resolveFreeCam: null when Camera Director is absent (no global)', () => {
|
|
const { __test } = load();
|
|
assert.equal(__test._resolveFreeCam({}, null, null, null), null);
|
|
assert.equal(__test._resolveFreeCam({}, { panelIndexFor: () => 0 }, {}, undefined), null);
|
|
});
|
|
|
|
test('_resolveFreeCam: throw-safe on panelIndexFor → falls back to global', () => {
|
|
const { __test } = load();
|
|
const g = { id: 'global' };
|
|
const ss = { panelIndexFor: () => { throw new Error('boom'); } };
|
|
assert.equal(__test._resolveFreeCam({}, ss, { 0: {} }, g), g);
|
|
});
|
|
|
|
test('_ssApi: null when neither global set; slopsmith alias; feedBack canonical wins', () => {
|
|
const { window, __test } = load();
|
|
assert.equal(__test._ssApi(), null);
|
|
const legacy = { panelIndexFor: () => 0 };
|
|
window.slopsmithSplitscreen = legacy;
|
|
assert.equal(__test._ssApi(), legacy); // legacy alias picked up
|
|
const current = { panelIndexFor: () => 1 };
|
|
window.feedBackSplitscreen = current;
|
|
assert.equal(__test._ssApi(), current); // canonical name takes precedence
|
|
});
|